[dpdk-test-report] |WARNING| pw35264 [PATCH 07/80] net/sfc/base: add Medford2 support to NIC module

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35264

_coding style issues_


WARNING:MISSING_BREAK: Possible switch case/default not preceded by break or fallthrough comment
#242: FILE: drivers/net/sfc/base/efx_impl.h:832:
+		case EFX_FAMILY_MEDFORD2:				\

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#264: FILE: drivers/net/sfc/base/efx_nic.c:78:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#268: FILE: drivers/net/sfc/base/efx_nic.c:82:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#272: FILE: drivers/net/sfc/base/efx_nic.c:86:
+			return (0);

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#358: FILE: drivers/net/sfc/base/medford2_impl.h:26:
+extern	__checkReturn	efx_rc_t

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#397: FILE: drivers/net/sfc/base/medford2_nic.c:24:
+	memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#434: FILE: drivers/net/sfc/base/medford2_nic.c:61:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#441: FILE: drivers/net/sfc/base/medford2_nic.c:68:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#456: FILE: drivers/net/sfc/base/medford2_nic.c:83:
+	if ((rc = efx_mcdi_get_port_modes(enp, &port_modes,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#463: FILE: drivers/net/sfc/base/medford2_nic.c:90:
+	if ((rc = ef10_nic_get_port_mode_bandwidth(current_mode,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#470: FILE: drivers/net/sfc/base/medford2_nic.c:97:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#475: FILE: drivers/net/sfc/base/medford2_nic.c:102:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#482: FILE: drivers/net/sfc/base/medford2_nic.c:109:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#483: FILE: drivers/net/sfc/base/medford2_nic.c:110:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#487: FILE: drivers/net/sfc/base/medford2_nic.c:114:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#503: FILE: drivers/net/sfc/base/medford2_nic.c:130:
+	if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#512: FILE: drivers/net/sfc/base/medford2_nic.c:139:
+	if ((rc = ef10_external_port_mapping(enp, port,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#522: FILE: drivers/net/sfc/base/medford2_nic.c:149:
+	if ((rc = efx_mcdi_get_function_info(enp, &pf, &vf)) != 0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc == 0'
#538: FILE: drivers/net/sfc/base/medford2_nic.c:165:
+		if ((rc == 0) && (mac_addr[0] & 0x02)) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#570: FILE: drivers/net/sfc/base/medford2_nic.c:197:
+	if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#574: FILE: drivers/net/sfc/base/medford2_nic.c:201:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc == 0'
#614: FILE: drivers/net/sfc/base/medford2_nic.c:241:
+	if ((rc == 0) || (rc == EACCES))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc == EACCES'
#614: FILE: drivers/net/sfc/base/medford2_nic.c:241:
+	if ((rc == 0) || (rc == EACCES))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#622: FILE: drivers/net/sfc/base/medford2_nic.c:249:
+	if ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#634: FILE: drivers/net/sfc/base/medford2_nic.c:261:
+	if ((rc = ef10_get_datapath_caps(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#641: FILE: drivers/net/sfc/base/medford2_nic.c:268:
+	if ((rc = efx_mcdi_get_rxdp_config(enp, &end_padding)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#693: FILE: drivers/net/sfc/base/medford2_nic.c:320:
+	if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#698: FILE: drivers/net/sfc/base/medford2_nic.c:325:
+	if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#727: FILE: drivers/net/sfc/base/medford2_nic.c:354:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#758: FILE: drivers/net/sfc/base/medford2_nic.c:385:
+	return (rc);

total: 21 errors, 2 warnings, 7 checks, 685 lines checked