[dpdk-test-report] |WARNING| pw35286 [PATCH 42/80] net/sfc/base: decode Medford2 FEC stats if available

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 20 08:48:20 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35286

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#39: FILE: drivers/net/sfc/base/ef10_mac.c:531:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]
#61: FILE: drivers/net/sfc/base/ef10_mac.c:901:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_UNCORRECTED_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_ERRORS]
#64: FILE: drivers/net/sfc/base/ef10_mac.c:904:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]
#68: FILE: drivers/net/sfc/base/ef10_mac.c:908:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE0]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]
#73: FILE: drivers/net/sfc/base/ef10_mac.c:913:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE1]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]
#78: FILE: drivers/net/sfc/base/ef10_mac.c:918:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE2]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]
#83: FILE: drivers/net/sfc/base/ef10_mac.c:923:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_FEC_CORRECTED_SYMBOLS_LANE3]),

total: 1 errors, 0 warnings, 6 checks, 76 lines checked


More information about the test-report mailing list