[dpdk-test-report] |WARNING| pw35332 [PATCH v2 2/2] Add autotests for RIB library

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35332

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#67: FILE: test/test/test_rib.c:17:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tests)
#93: FILE: test/test/test_rib.c:43:
+#define NUM_RIB_TESTS (sizeof(tests)/sizeof(tests[0]))

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#156: FILE: test/test/test_rib.c:106:
+ * */

WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'?
#231: FILE: test/test/test_rib.c:181:
+	/*Create vaild rib to use in rest of test. */

WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'?
#266: FILE: test/test/test_rib.c:216:
+	/*Create vaild rib to use in rest of test. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#327: FILE: test/test/test_rib.c:277:
+/*
+

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#366: FILE: test/test/test_rib.c:316:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#649: FILE: test/test/test_rib_generate_rt.c:263:
+	unsigned i, j;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#657: FILE: test/test/test_rib_generate_rt.c:271:
+		unsigned depth_counter = 0;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#754: FILE: test/test/test_rib_lpm_comp.c:21:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#806: FILE: test/test/test_rib_lpm_comp.c:73:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#835: FILE: test/test/test_rib_lpm_comp.c:102:
+	printf("No. routes = %u
", (unsigned) num_routes);

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#947: FILE: test/test/test_rib_perf.c:21:
+#define TEST_RIB_ASSERT(cond) do {				\
+	if (!(cond)) {						\
+		printf("Error at line %d:
", __LINE__);	\
+		return -1;					\
+	}							\
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#968: FILE: test/test/test_rib_perf.c:42:
+	unsigned i, j;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#989: FILE: test/test/test_rib_perf.c:63:
+	printf("No. routes = %u
", (unsigned) num_routes);

total: 0 errors, 15 warnings, 1026 lines checked