[dpdk-test-report] |WARNING| pw33352 [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jan 10 08:07:10 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33352

_coding style issues_


CHECK:ARCH_DEFINES: architecture specific defines should be avoided
#1965: FILE: drivers/net/tap/tap_bpf_insns.c:1760:
+# if defined(__i386__)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#2078: FILE: drivers/net/tap/tap_bpf_program.c:22:
+#define IPv4(a, b, c, d) ((__u32)(((a) & 0xff) << 24) | \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2272: FILE: drivers/net/tap/tap_bpf_program.c:216:
+		return rss_ ## L (skb);			\

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(a)
#2286: FILE: drivers/net/tap/tap_flow.h:53:
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#2286: FILE: drivers/net/tap/tap_flow.h:53:
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

total: 0 errors, 2 warnings, 3 checks, 2212 lines checked


More information about the test-report mailing list