[dpdk-test-report] |WARNING| pw42381 [v4, 16/23] net/softnic: add cli for pipeline table entries

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jul 5 17:50:34 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42381

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#2056: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3392:
+				cmd_softnic_softnic_pipeline_table_rule_add_default(softnic, tokens,

WARNING:LONG_LINE: line over 90 characters
#2083: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3419:
+				cmd_softnic_softnic_pipeline_table_rule_delete_default(softnic, tokens,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->ip_version == 0'
#2443: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+		if ((r->ip_version && (t->ip_version == 0)) ||
+			((r->ip_version == 0) && t->ip_version))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2443: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:709:
+		if ((r->ip_version && (t->ip_version == 0)) ||
+			((r->ip_version == 0) && t->ip_version))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 4'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+		if ((r->ip_version && (t->key_size != 4)) ||
+			((r->ip_version == 0) && (t->key_size != 16)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r->ip_version == 0'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+		if ((r->ip_version && (t->key_size != 4)) ||
+			((r->ip_version == 0) && (t->key_size != 16)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 't->key_size != 16'
#2470: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:736:
+		if ((r->ip_version && (t->key_size != 4)) ||
+			((r->ip_version == 0) && (t->key_size != 16)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version0 == 0'
#2551: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+		if ((ip_version1 && (ip_version0 == 0)) ||
+			((ip_version1 == 0) && ip_version0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ip_version1 == 0'
#2551: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:817:
+		if ((ip_version1 && (ip_version0 == 0)) ||
+			((ip_version1 == 0) && ip_version0))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2986: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1298:
+				status = match_convert_ipv6_depth(

WARNING:LONG_LINE: line over 90 characters
#3356: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1668:
+			(struct rte_pipeline_table_entry *)&action_ll[i * TABLE_RULE_ACTION_SIZE_MAX];

total: 0 errors, 3 warnings, 8 checks, 3536 lines checked


More information about the test-report mailing list