[dpdk-test-report] |WARNING| pw42550 [v5, 12/23] net/softnic: add cli interface

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jul 6 19:23:15 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/42550

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#439: FILE: drivers/net/softnic/parser.c:376:
+		if (pch != NULL) {
[...]
+		} else if (ch == '.' && saw_digit) {
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#455: FILE: drivers/net/softnic/parser.c:392:
+		} else

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#497: FILE: drivers/net/softnic/parser.c:434:
+	saw_xdigit = count_xdigit = 0;

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(o)
#591: FILE: drivers/net/softnic/parser.c:528:
+	} while (++i != sizeof(o) / sizeof(o[0]) && end[0] != 0);

CHECK:BRACES: braces {} should be used on all arms of this statement
#598: FILE: drivers/net/softnic/parser.c:535:
+	if (i == ETHER_ADDR_LEN) {
[...]
+	} else if (i == ETHER_ADDR_LEN / 2) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#613: FILE: drivers/net/softnic/parser.c:550:
+	} else

total: 0 errors, 1 warnings, 5 checks, 905 lines checked


More information about the test-report mailing list