[dpdk-test-report] |WARNING| pw41211 [v2] [PATCH 17/22] net/softnic: add cli to read pipeline port and table stats

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/41211

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#37: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1495:
+	"Pkts in: %" PRIu64 "
"                           \

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7'
#53: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1511:
+	if ((n_tokens != 7) && (n_tokens != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 8'
#53: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1511:
+	if ((n_tokens != 7) && (n_tokens != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7'
#138: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1685:
+	if ((n_tokens != 7) && (n_tokens != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 8'
#138: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1685:
+	if ((n_tokens != 7) && (n_tokens != 8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 6'
#219: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1766:
+	if ((n_tokens != 6) && (n_tokens != 7)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens != 7'
#219: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1766:
+	if ((n_tokens != 6) && (n_tokens != 7)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#309: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3603:
+		if ((n_tokens >= 6) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "in") == 0) &&
 			(strcmp(tokens[5], "enable") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#319: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3621:
+		if ((n_tokens >= 6) &&
+			(strcmp(tokens[2], "port") == 0) &&
+			(strcmp(tokens[3], "out") == 0) &&
+			(strcmp(tokens[5], "stats") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#328: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3630:
+		if ((n_tokens >= 5) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "stats") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#344: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:3682:
+		if ((n_tokens >= 7) &&
+			(strcmp(tokens[2], "table") == 0) &&
+			(strcmp(tokens[4], "rule") == 0) &&
+			(strcmp(tokens[5], "read") == 0) &&
+			(strcmp(tokens[6], "stats") == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#532: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:661:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#532: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:661:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#537: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#537: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_in'
#537: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:666:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_in))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#589: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:796:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#589: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:796:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#594: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_out))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#594: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_out))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port_id >= p->n_ports_out'
#594: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:801:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(port_id >= p->n_ports_out))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#638: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:845:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#638: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:845:
+	if ((pipeline_name == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#643: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:850:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline_name == NULL'
#695: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'data == NULL'
#695: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stats == NULL'
#695: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1319:
+	if ((pipeline_name == NULL) ||
+		(data == NULL) ||
+		(stats == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#701: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->enabled == 0'
#701: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table_id >= p->n_tables'
#701: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1325:
+	if ((p == NULL) ||
+		(p->enabled == 0) ||
+		(table_id >= p->n_tables))

CHECK:SPACING: No space is necessary after a cast
#743: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1388:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#767: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1430:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#783: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:1446:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

CHECK:SPACING: No space is necessary after a cast
#806: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:2166:
+	struct pipeline_msg_rsp *rsp = (struct pipeline_msg_rsp *) req;

total: 0 errors, 0 warnings, 36 checks, 802 lines checked