[dpdk-test-report] |WARNING| pw35693 [PATCH v2 03/14] net/sfc/base: support VXLAN filter creation

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 6 16:28:04 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35693

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#31: FILE: drivers/net/sfc/base/efx.h:2627:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'inner_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+	if ((inner_addr == NULL) && (outer_addr == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'outer_addr == NULL'
#65: FILE: drivers/net/sfc/base/efx_filter.c:487:
+	if ((inner_addr == NULL) && (outer_addr == NULL))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#66: FILE: drivers/net/sfc/base/efx_filter.c:488:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#82: FILE: drivers/net/sfc/base/efx_filter.c:504:
+	return (0);

total: 1 errors, 1 warnings, 3 checks, 55 lines checked


More information about the test-report mailing list