[dpdk-test-report] |WARNING| pw35825 [PATCH v3 06/18] net/axgbe: add phy programming apis
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Mar 9 09:44:31 CET 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35825
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#536: FILE: drivers/net/axgbe/axgbe_mdio.c:591:
+ if (!(pdata->phy.advertising & ADVERTISED_1000baseKX_Full) &&
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#537: FILE: drivers/net/axgbe/axgbe_mdio.c:592:
+ !(pdata->phy.advertising & ADVERTISED_2500baseX_Full))
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#545: FILE: drivers/net/axgbe/axgbe_mdio.c:600:
+ if (!(pdata->phy.advertising & ADVERTISED_10000baseKR_Full))
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseR_FEC>
#683: FILE: drivers/net/axgbe/axgbe_mdio.c:738:
+ if (advertising & ADVERTISED_10000baseR_FEC)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#707: FILE: drivers/net/axgbe/axgbe_mdio.c:762:
+ if (advertising & ADVERTISED_Pause)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#712: FILE: drivers/net/axgbe/axgbe_mdio.c:767:
+ if (advertising & ADVERTISED_Asym_Pause)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pdata->phy.autoneg != AUTONEG_ENABLE'
#892: FILE: drivers/net/axgbe/axgbe_mdio.c:947:
+ if ((pdata->phy.autoneg != AUTONEG_ENABLE) || pdata->parallel_detect)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#1273: FILE: drivers/net/axgbe/axgbe_phy_impl.c:581:
+ pdata->phy.advertising &= ~ADVERTISED_Autoneg;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#1276: FILE: drivers/net/axgbe/axgbe_phy_impl.c:584:
+ pdata->phy.advertising &= ~ADVERTISED_100baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#1277: FILE: drivers/net/axgbe/axgbe_phy_impl.c:585:
+ pdata->phy.advertising &= ~ADVERTISED_1000baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#1278: FILE: drivers/net/axgbe/axgbe_phy_impl.c:586:
+ pdata->phy.advertising &= ~ADVERTISED_10000baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Backplane>
#1647: FILE: drivers/net/axgbe/axgbe_phy_impl.c:955:
+ pdata->phy.lp_advertising |= ADVERTISED_Backplane;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->port_mode == AXGBE_PORT_MODE_SFP'
#1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX'
#1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR'
#1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
total: 0 errors, 0 warnings, 15 checks, 2428 lines checked
More information about the test-report
mailing list