[dpdk-test-report] |WARNING| pw39572 [PATCH 2/2] app/testpmd: add set topology on the fly command

checkpatch at dpdk.org checkpatch at dpdk.org
Wed May 9 14:35:28 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39572

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#44: FILE: app/test-pmd/cmdline.c:7656:
+                cmdline_fixed_string_t set;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#44: FILE: app/test-pmd/cmdline.c:7656:
+                cmdline_fixed_string_t set;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#45: FILE: app/test-pmd/cmdline.c:7657:
+                cmdline_fixed_string_t fwd_topo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: app/test-pmd/cmdline.c:7657:
+                cmdline_fixed_string_t fwd_topo;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#46: FILE: app/test-pmd/cmdline.c:7658:
+                cmdline_fixed_string_t topo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: app/test-pmd/cmdline.c:7658:
+                cmdline_fixed_string_t topo;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#50: FILE: app/test-pmd/cmdline.c:7662:
+                                __attribute__((unused)) struct cmdline *cl,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#50: FILE: app/test-pmd/cmdline.c:7662:
+                                __attribute__((unused)) struct cmdline *cl,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#51: FILE: app/test-pmd/cmdline.c:7663:
+                                __attribute__((unused)) void *data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: app/test-pmd/cmdline.c:7663:
+                                __attribute__((unused)) void *data)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: app/test-pmd/cmdline.c:7665:
+        struct cmd_set_fwd_topo_result *res = parsed_result;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: app/test-pmd/cmdline.c:7665:
+        struct cmd_set_fwd_topo_result *res = parsed_result;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: app/test-pmd/cmdline.c:7667:
+        if (test_done == 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: app/test-pmd/cmdline.c:7667:
+        if (test_done == 0) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#56: FILE: app/test-pmd/cmdline.c:7668:
+                printf("Please stop forwarding first
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: app/test-pmd/cmdline.c:7668:
+                printf("Please stop forwarding first
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#57: FILE: app/test-pmd/cmdline.c:7669:
+                return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: app/test-pmd/cmdline.c:7669:
+                return;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#58: FILE: app/test-pmd/cmdline.c:7670:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: app/test-pmd/cmdline.c:7670:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#59: FILE: app/test-pmd/cmdline.c:7671:
+        if (!strcmp(res->fwd_topo, "fwd-topo")) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#59: FILE: app/test-pmd/cmdline.c:7671:
+        if (!strcmp(res->fwd_topo, "fwd-topo")) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#60: FILE: app/test-pmd/cmdline.c:7672:
+                set_set_fwd_topo(res->topo);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: app/test-pmd/cmdline.c:7672:
+                set_set_fwd_topo(res->topo);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#61: FILE: app/test-pmd/cmdline.c:7673:
+                fwd_config_setup();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: app/test-pmd/cmdline.c:7673:
+                fwd_config_setup();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#62: FILE: app/test-pmd/cmdline.c:7674:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#62: FILE: app/test-pmd/cmdline.c:7674:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#73: FILE: app/test-pmd/cmdline.c:7685:
+        .f = cmd_set_fwd_topo_parsed,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#73: FILE: app/test-pmd/cmdline.c:7685:
+        .f = cmd_set_fwd_topo_parsed,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#74: FILE: app/test-pmd/cmdline.c:7686:
+        .data = NULL,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: app/test-pmd/cmdline.c:7686:
+        .data = NULL,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: app/test-pmd/cmdline.c:7687:
+        .help_str = "set fwd-topo loop|paired|chained|custom",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: app/test-pmd/cmdline.c:7687:
+        .help_str = "set fwd-topo loop|paired|chained|custom",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#76: FILE: app/test-pmd/cmdline.c:7688:
+        .tokens = {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#76: FILE: app/test-pmd/cmdline.c:7688:
+        .tokens = {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#77: FILE: app/test-pmd/cmdline.c:7689:
+                (void *)&cmd_set_fwd_topo_set,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: app/test-pmd/cmdline.c:7689:
+                (void *)&cmd_set_fwd_topo_set,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#78: FILE: app/test-pmd/cmdline.c:7690:
+                (void *)&cmd_set_fwd_topo_fwd_topo,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: app/test-pmd/cmdline.c:7690:
+                (void *)&cmd_set_fwd_topo_fwd_topo,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#79: FILE: app/test-pmd/cmdline.c:7691:
+                (void *)&cmd_set_fwd_topo_topo,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: app/test-pmd/cmdline.c:7691:
+                (void *)&cmd_set_fwd_topo_topo,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#80: FILE: app/test-pmd/cmdline.c:7692:
+                NULL,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#80: FILE: app/test-pmd/cmdline.c:7692:
+                NULL,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#81: FILE: app/test-pmd/cmdline.c:7693:
+        },$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#81: FILE: app/test-pmd/cmdline.c:7693:
+        },$

ERROR:SPACING: space required before the open parenthesis '('
#111: FILE: app/test-pmd/config.c:2392:
+	else if(!strcmp(topology, "loop"))

ERROR:SPACING: space required before the open parenthesis '('
#113: FILE: app/test-pmd/config.c:2394:
+	else if(!strcmp(topology, "chained"))

ERROR:SPACING: space required before the open parenthesis '('
#115: FILE: app/test-pmd/config.c:2396:
+	else if(!strcmp(topology, "paired"))

ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: app/test-pmd/config.c:2404:
+        set_fwd_ports_list(portlist, nb_pt);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: app/test-pmd/config.c:2404:
+        set_fwd_ports_list(portlist, nb_pt);$

total: 27 errors, 24 warnings, 105 lines checked


More information about the test-report mailing list