[dpdk-test-report] |WARNING| pw39724 [PATCH RFC] vhost: new rte_vhost API proposal

checkpatch at dpdk.org checkpatch at dpdk.org
Thu May 10 11:50:02 CEST 2018
Previous message: [dpdk-test-report] |SUCCESS| pw39567[dpdk-dev] net/bonding: update link status on slave add
Next message: [dpdk-test-report] |SUCCESS| pw39570[dpdk-dev, v2] ethdev: fix comments for offload capabilities
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/39724

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: lib/librte_virtio/rte_virtio.h:38:
+ uint64_t guest_phys_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: lib/librte_virtio/rte_virtio.h:39:
+ uint64_t guest_user_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: lib/librte_virtio/rte_virtio.h:40:
+ uint64_t host_user_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: lib/librte_virtio/rte_virtio.h:41:
+ uint64_t size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: lib/librte_virtio/rte_virtio.h:42:
+ void *mmap_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: lib/librte_virtio/rte_virtio.h:43:
+ uint64_t mmap_size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: lib/librte_virtio/rte_virtio.h:44:
+ int fd;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: lib/librte_virtio/rte_virtio.h:48:
+ uint32_t nregions;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: lib/librte_virtio/rte_virtio.h:49:
+ struct rte_virtio_mem_region regions[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: lib/librte_virtio/rte_virtio.h:59:
+ struct rte_virtio_memory *mem;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: lib/librte_virtio/rte_virtio.h:60:
+ uint64_t features;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: lib/librte_virtio/rte_virtio.h:68:
+ struct vring_desc *desc;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: lib/librte_virtio/rte_virtio.h:69:
+ struct vring_avail *avail;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: lib/librte_virtio/rte_virtio.h:70:
+ struct vring_used *used;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: lib/librte_virtio/rte_virtio.h:72:
+ void *log;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: lib/librte_virtio/rte_virtio.h:73:
+ uint16_t size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: lib/librte_virtio/rte_virtio.h:82:
+ void (*device_create)(struct rte_virtio_dev *vdev);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#159: FILE: lib/librte_virtio/rte_virtio.h:84:
+ /**
+ * Device is ready to operate. vdev->mem is now available.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_virtio/rte_virtio.h:89:
+ void (*device_init)(struct rte_virtio_dev *vdev);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#166: FILE: lib/librte_virtio/rte_virtio.h:91:
+ /**
+ * Features have changed in runtime. Queues might be still running

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: lib/librte_virtio/rte_virtio.h:94:
+ void (*device_features_changed)(struct rte_virtio_dev *vdev);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#171: FILE: lib/librte_virtio/rte_virtio.h:96:
+ /**
+ * Start processing vq. The `vq` is guaranteed not to be modified before

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: lib/librte_virtio/rte_virtio.h:99:
+ void (*queue_start)(struct rte_virtio_dev *vdev, struct rte_virtio_vq *vq);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#176: FILE: lib/librte_virtio/rte_virtio.h:101:
+ /**
+ * Stop processing vq. It shouldn't be accessed after this callback

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#180: FILE: lib/librte_virtio/rte_virtio.h:105:
+ void (*queue_stop)(struct rte_virtio_dev *vdev, struct rte_virtio_vq *vq);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: lib/librte_virtio/rte_virtio.h:107:
+ void (*device_destroy)(struct rte_virtio_dev *vdev);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#184: FILE: lib/librte_virtio/rte_virtio.h:109:
+ /**
+ * Custom message handler. `vdev` and `vq` can be NULL. This is called

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: lib/librte_virtio/rte_virtio.h:114:
+ void (*custom_msg)(struct rte_virtio_dev *vdev, struct rte_virtio_vq *vq,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: lib/librte_virtio/rte_virtio.h:115:
+   char *id, void *ctx);$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#193: FILE: lib/librte_virtio/rte_virtio.h:118:
+ /**
+ * Interrupt handler, synchronous. If this callback is set to NULL,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: lib/librte_virtio/rte_virtio.h:121:
+ void (*queue_kick)(struct rte_virtio_dev *vdev, struct rte_virtio_vq *vq);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: lib/librte_virtio/rte_virtio.h:123:
+ int (*get_config)(struct rte_virtio_dev *vdev, uint8_t *config,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: lib/librte_virtio/rte_virtio.h:124:
+  uint32_t config_len);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/librte_virtio/rte_virtio.h:126:
+ int (*set_config)(struct rte_virtio_dev *vdev, uint8_t *config,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: lib/librte_virtio/rte_virtio.h:127:
+  uint32_t offset, uint32_t len, uint32_t flags);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: lib/librte_virtio/rte_virtio.h:148:
+   struct rte_virtio_tgt_ops *tgt_ops,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: lib/librte_virtio/rte_virtio.h:149:
+   uint64_t features);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: lib/librte_virtio/rte_virtio.h:167:
+      void (*cb_fn)(void *arg), void *cb_arg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: lib/librte_virtio/rte_virtio.h:182:
+ struct rte_virtio_mem_region *r;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#258: FILE: lib/librte_virtio/rte_virtio.h:183:
+ uint32_t i;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: lib/librte_virtio/rte_virtio.h:185:
+ for (i = 0; i < mem->nregions; i++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#260: FILE: lib/librte_virtio/rte_virtio.h:185:
+ for (i = 0; i < mem->nregions; i++) {
+ r = &mem->regions[i];

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: lib/librte_virtio/rte_virtio.h:186:
+ r = &mem->regions[i];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: lib/librte_virtio/rte_virtio.h:187:
+ if (gpa >= r->guest_phys_addr &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#262: FILE: lib/librte_virtio/rte_virtio.h:187:
+ if (gpa >= r->guest_phys_addr &&
[...]
+ if (unlikely(*len > r->guest_phys_addr + r->size - gpa)) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: lib/librte_virtio/rte_virtio.h:188:
+    gpa <  r->guest_phys_addr + r->size) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: lib/librte_virtio/rte_virtio.h:190:
+ if (unlikely(*len > r->guest_phys_addr + r->size - gpa)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#265: FILE: lib/librte_virtio/rte_virtio.h:190:
+ if (unlikely(*len > r->guest_phys_addr + r->size - gpa)) {
+ *len = r->guest_phys_addr + r->size - gpa;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#265: FILE: lib/librte_virtio/rte_virtio.h:190:
+ if (unlikely(*len > r->guest_phys_addr + r->size - gpa)) {
+ *len = r->guest_phys_addr + r->size - gpa;
+ }

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#266: FILE: lib/librte_virtio/rte_virtio.h:191:
+ *len = r->guest_phys_addr + r->size - gpa;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: lib/librte_virtio/rte_virtio.h:192:
+ }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: lib/librte_virtio/rte_virtio.h:194:
+ return gpa - r->guest_phys_addr +$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: lib/librte_virtio/rte_virtio.h:195:
+       r->host_user_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: lib/librte_virtio/rte_virtio.h:196:
+ }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: lib/librte_virtio/rte_virtio.h:197:
+ }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: lib/librte_virtio/rte_virtio.h:198:
+ *len = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#275: FILE: lib/librte_virtio/rte_virtio.h:200:
+ return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: lib/librte_virtio/rte_virtio.h:221:
+      uint64_t iova, uint32_t *len, uint8_t perm)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: lib/librte_virtio/rte_virtio.h:223:
+ void *__vhost_iova_to_vva(struct virtio_net * dev, struct vhost_virtqueue * vq,$

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#298: FILE: lib/librte_virtio/rte_virtio.h:223:
+ void *__vhost_iova_to_vva(struct virtio_net * dev, struct vhost_virtqueue * vq,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#298: FILE: lib/librte_virtio/rte_virtio.h:223:
+ void *__vhost_iova_to_vva(struct virtio_net * dev, struct vhost_virtqueue * vq,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#299: FILE: lib/librte_virtio/rte_virtio.h:224:
+  uint64_t iova, uint64_t size, uint8_t perm);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: lib/librte_virtio/rte_virtio.h:226:
+ if (!(vdev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#301: FILE: lib/librte_virtio/rte_virtio.h:226:
+ if (!(vdev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) {
+ return rte_virtio_gpa_to_vva(vdev->mem, iova, len);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#301: FILE: lib/librte_virtio/rte_virtio.h:226:
+ if (!(vdev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) {
+ return rte_virtio_gpa_to_vva(vdev->mem, iova, len);
+ }

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: lib/librte_virtio/rte_virtio.h:227:
+ return rte_virtio_gpa_to_vva(vdev->mem, iova, len);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: lib/librte_virtio/rte_virtio.h:228:
+ }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#305: FILE: lib/librte_virtio/rte_virtio.h:230:
+ return __vhost_iova_to_vva(vdev, vq, iova, len, perm);$

total: 2 errors, 66 warnings, 245 lines checked
Previous message: [dpdk-test-report] |SUCCESS| pw39567[dpdk-dev] net/bonding: update link status on slave add
Next message: [dpdk-test-report] |SUCCESS| pw39570[dpdk-dev, v2] ethdev: fix comments for offload capabilities
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list