[dpdk-test-report] |WARNING| pw40342 [PATCH v2] kni: fix build on Centos 7.4 when Ethtool enabled

checkpatch at dpdk.org checkpatch at dpdk.org
Tue May 22 20:13:22 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40342

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#51: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
                                              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#51: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \
                                                ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#51: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

ERROR:SPACING: space prohibited before that close parenthesis ')'
#51: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#51: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3903:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) ) \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))
                                                     ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

ERROR:SPACING: space prohibited before that close parenthesis ')'
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3904:
+    || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,4) ))

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3922:
+     (SLE_VERSION_CODE && SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0)) || \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#62: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3923:
+     (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)))$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#62: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3923:
+     (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#65: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3925:
+#if (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#67: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3927:
+ * is in the struct net_device_ops_extended */

total: 7 errors, 8 warnings, 26 lines checked


More information about the test-report mailing list