[dpdk-test-report] |WARNING| pw40509 [PATCH] rte_ring: clarify preemptable nature of ring algorithm

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40509

_coding style issues_


WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#5: 
Subject: [dpdk-dev] [PATCH] rte_ring: clarify preemptable nature of ring algorithm

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
But rte_ring is not as basic as spinlock. IMO, existing note results in more questions than answers.

WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#21: 
Subject: Re: [dpdk-dev] [PATCH] [PATCH] rte_ring: clarify preemptable nature of ring algorithm

WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#26: 
rte_ring implementation is not preemptable only under certain circumstances.

WARNING:BAD_SIGN_OFF: email address 'Honnappa Nagarahalli <honnappa.nagarahalli at arm.com<mailto:honnappa.nagarahalli at arm.com>>
' might be better as '"Honnappa Nagarahalli <honnappa.nagarahalli at arm.com" <mailto:honnappa.nagarahalli at arm.com>
'
#30: 
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com<mailto:honnappa.nagarahalli at arm.com>>

WARNING:BAD_SIGN_OFF: email address 'Gavin Hu <gavin.hu at arm.com<mailto:gavin.hu at arm.com>>
' might be better as '"Gavin Hu <gavin.hu at arm.com" <mailto:gavin.hu at arm.com>
'
#31: 
Reviewed-by: Gavin Hu <gavin.hu at arm.com<mailto:gavin.hu at arm.com>>

WARNING:BAD_SIGN_OFF: email address 'Ola Liljedahl <ola.liljedahl at arm.com<mailto:ola.liljedahl at arm.com>>
' might be better as '"Ola Liljedahl <ola.liljedahl at arm.com" <mailto:ola.liljedahl at arm.com>
'
#32: 
Reviewed-by: Ola Liljedahl <ola.liljedahl at arm.com<mailto:ola.liljedahl at arm.com>>

ERROR:TRAILING_WHITESPACE: trailing whitespace
#51: FILE: lib/librte_ring/rte_ring.h:29:
+ * Note: the ring implementation can block threads from completing their^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#52: FILE: lib/librte_ring/rte_ring.h:30:
+ * operation under the following circumstances.^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#53: FILE: lib/librte_ring/rte_ring.h:31:
+ * A preempted thread can block other threads (operating on the same ring)^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#54: FILE: lib/librte_ring/rte_ring.h:32:
+ * from completing their operations, only if those threads are performing^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#55: FILE: lib/librte_ring/rte_ring.h:33:
+ * the same ring operation (enqueue/dequeue) as the preempted thread.^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#56: FILE: lib/librte_ring/rte_ring.h:34:
+ * In other words, a preempted consumer thread will not block any producer^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#57: FILE: lib/librte_ring/rte_ring.h:35:
+ * threads and vice versa.^M$

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#60: FILE: lib/librte_ring/rte_ring.h:37:


total: 8 errors, 7 warnings, 15 lines checked