[dpdk-test-report] |WARNING| pw48055 net/i40e: fix X710 Rx issue after reading some registers

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Nov 14 05:10:56 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48055

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x2b800'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x2bb00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x38700'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x38a00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x3d800'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x3db00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x208e00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x209000'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x20be00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x20c000'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x263c00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x264000'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset >= 0x265c00'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_offset <= 0x266000'
#52: FILE: drivers/net/i40e/i40e_ethdev.c:11625:
+	if (((reg_offset >= 0x2b800) && (reg_offset <= 0x2bb00)) ||
+	    ((reg_offset >= 0x38700) && (reg_offset <= 0x38a00)) ||
+	    ((reg_offset >= 0x3d800) && (reg_offset <= 0x3db00)) ||
+	    ((reg_offset >= 0x208e00) && (reg_offset <= 0x209000)) ||
+	    ((reg_offset >= 0x20be00) && (reg_offset <= 0x20c000)) ||
+	    ((reg_offset >= 0x263c00) && (reg_offset <= 0x264000)) ||
+	    ((reg_offset >= 0x265c00) && (reg_offset <= 0x266000)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type != I40E_MAC_X722'
#73: FILE: drivers/net/i40e/i40e_ethdev.c:11678:
+				if ((hw->mac.type != I40E_MAC_X722) &&
+				    !i40e_valid_regs(reg_offset))

total: 0 errors, 0 warnings, 15 checks, 45 lines checked


More information about the test-report mailing list