[dpdk-test-report] |WARNING| pw48240 [RFC, 2/3] tqs: add thread quiescent state library

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Nov 22 04:33:11 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48240

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#148: FILE: lib/librte_tqs/rte_tqs.c:32:
+struct rte_tqs * __rte_experimental

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#420: FILE: lib/librte_tqs/rte_tqs.h:49:
+#define TQS_RETURN_IF_TRUE(cond, retval) do { \
+	if ((cond)) \
+		return retval; \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#429: FILE: lib/librte_tqs/rte_tqs.h:58:
+#define TQS_ERR_LOG_IF_TRUE(cond) do { \
+	if ((cond)) { \
+		RTE_LOG(ERR, TQS, "Invalid parameters
"); \
+		return; \
+	} \
+} while (0)

total: 1 errors, 2 warnings, 680 lines checked


More information about the test-report mailing list