[dpdk-test-report] |WARNING| pw48286 [02/19] net/ice: support device initialization
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Nov 23 07:52:45 CET 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48286
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno != 0'
#215: FILE: drivers/net/ice/ice_ethdev.c:58:
+ if (!num || (*end == '-') || (errno != 0)) {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#449: FILE: drivers/net/ice/ice_ethdev.c:292:
+ if (!is_unicast_ether_addr(
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1033: FILE: drivers/net/ice/ice_ethdev.h:225:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1059: FILE: drivers/net/ice/ice_ethdev.h:251:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1060: FILE: drivers/net/ice/ice_ethdev.h:252:
+ bool adapter_stopped;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1071: FILE: drivers/net/ice/ice_ethdev.h:263:
+ bool rx_bulk_alloc_allowed;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1072: FILE: drivers/net/ice/ice_ethdev.h:264:
+ bool tx_simple_allowed;
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pf' may be better as '(pf)' to avoid precedence issues
#1114: FILE: drivers/net/ice/ice_ethdev.h:306:
+#define ICE_PF_TO_ADAPTER(pf) \
+ ((struct ice_adapter *)pf->adapter)
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1245: FILE: drivers/net/ice/ice_rxtx.h:62:
+ bool q_set; /* indicate if rx queue has been configured */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1246: FILE: drivers/net/ice/ice_rxtx.h:63:
+ bool rx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1284: FILE: drivers/net/ice/ice_rxtx.h:101:
+ bool tx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1285: FILE: drivers/net/ice/ice_rxtx.h:102:
+ bool q_set; /* indicate if tx queue has been configured */
total: 0 errors, 1 warnings, 1233 lines checked
More information about the test-report
mailing list