[dpdk-test-report] |WARNING| pw47311 [RFC, 03/14] net: add rte prefix to ether structures

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47311

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#1468: FILE: drivers/net/ark/ark_global.h:79:
+	void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_ether_addr *' should also have an identifier name
#1468: FILE: drivers/net/ark/ark_global.h:79:
+	void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#1468: FILE: drivers/net/ark/ark_global.h:79:
+	void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#2029: FILE: drivers/net/bonding/rte_eth_bond_alb.c:75:
+void bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset,
 		struct bond_dev_private *internals) {

WARNING:LONG_LINE: line over 90 characters
#2073: FILE: drivers/net/bonding/rte_eth_bond_alb.c:166:
+				client_info->vlan_count = offset / sizeof(struct rte_vlan_hdr);

WARNING:LONG_LINE: line over 90 characters
#2369: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1128:
+				pkt_size = sizeof(struct rte_ether_hdr) + sizeof(struct rte_arp_hdr)

WARNING:LONG_LINE: line over 90 characters
#2370: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1129:
+						+ client_info->vlan_count * sizeof(struct rte_vlan_hdr);

WARNING:LONG_LINE: line over 90 characters
#2379: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1160:
+				eth_h = rte_pktmbuf_mtod(slave_bufs[i][j], struct rte_ether_hdr *);

WARNING:LONG_LINE: line over 90 characters
#2388: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1177:
+				eth_h = rte_pktmbuf_mtod(update_bufs[i][j], struct rte_ether_hdr *);

CHECK:SPACING: No space is necessary after a cast
#2691: FILE: drivers/net/e1000/em_ethdev.c:296:
+	ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,

WARNING:LONG_LINE: line over 90 characters
#2763: FILE: drivers/net/e1000/igb_ethdev.c:822:
+	ether_addr_copy((struct rte_ether_addr *)hw->mac.addr, &eth_dev->data->mac_addrs[0]);

CHECK:SPACING: No space is necessary after a cast
#2781: FILE: drivers/net/e1000/igb_ethdev.c:1042:
+	ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,

CHECK:SPACING: No space is necessary after a cast
#3003: FILE: drivers/net/enic/enic_main.c:1678:
+	ether_addr_copy((struct rte_ether_addr *) enic->mac_addr,

CHECK:SPACING: No space is necessary after a cast
#3162: FILE: drivers/net/i40e/i40e_ethdev.c:1460:
+	ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,

CHECK:SPACING: No space is necessary after a cast
#3163: FILE: drivers/net/i40e/i40e_ethdev.c:1461:
+			(struct rte_ether_addr *) hw->mac.perm_addr);

CHECK:SPACING: No space is necessary after a cast
#3821: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1218:
+	ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,

CHECK:SPACING: No space is necessary after a cast
#3839: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1559:
+	struct rte_ether_addr *perm_addr = (struct rte_ether_addr *) hw->mac.perm_addr;

CHECK:SPACING: No space is necessary after a cast
#3903: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6017:
+	struct rte_ether_addr *perm_addr = (struct rte_ether_addr *) hw->mac.perm_addr;

CHECK:SPACING: No space is necessary after a cast
#5324: FILE: drivers/net/virtio/virtio_ethdev.c:1486:
+	ether_addr_copy((struct rte_ether_addr *) hw->mac_addr,

CHECK:SPACING: No space is necessary after a cast
#5368: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:314:
+	ether_addr_copy((struct rte_ether_addr *) hw->perm_addr,

WARNING:LONG_LINE: line over 90 characters
#6183: FILE: examples/ipv4_multicast/main.c:287:
+	ethdr = (struct rte_ether_hdr *)rte_pktmbuf_prepend(pkt, (uint16_t)sizeof(*ethdr));

WARNING:LONG_LINE: line over 90 characters
#6197: FILE: examples/ipv4_multicast/main.c:319:
+	iphdr = (struct ipv4_hdr *)rte_pktmbuf_adj(m, (uint16_t)sizeof(struct rte_ether_hdr));

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#8547: FILE: lib/librte_ethdev/rte_ethdev_core.h:600:
+	struct rte_ether_addr* mac_addrs;/**< Device Ethernet Link address. */

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#8551: FILE: lib/librte_ethdev/rte_ethdev_core.h:603:
+	struct rte_ether_addr* hash_mac_addrs;

WARNING:LONG_LINE: line over 90 characters
#9415: FILE: test/test/packet_burst_generator.c:296:
+			eth_hdr_size = sizeof(struct rte_ether_hdr) + sizeof(struct rte_vlan_hdr);

WARNING:LONG_LINE: line over 90 characters
#9806: FILE: test/test/test_link_bonding.c:1271:
+				(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_1,

WARNING:LONG_LINE: line over 90 characters
#9811: FILE: test/test/test_link_bonding.c:1275:
+				(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,

WARNING:LONG_LINE: line over 90 characters
#9847: FILE: test/test/test_link_bonding.c:2033:
+			(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,

WARNING:LONG_LINE: line over 90 characters
#9874: FILE: test/test/test_link_bonding.c:2567:
+			(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,

WARNING:LONG_LINE: line over 90 characters
#9883: FILE: test/test/test_link_bonding.c:2582:
+			(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_1,

WARNING:LONG_LINE: line over 90 characters
#9910: FILE: test/test/test_link_bonding.c:3405:
+			(struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,

WARNING:LONG_LINE: line over 90 characters
#9939: FILE: test/test/test_link_bonding.c:3989:
+					(struct rte_ether_addr *)dst_mac_0, ETHER_TYPE_IPv4, 0, 0);

WARNING:LONG_LINE: line over 90 characters
#9944: FILE: test/test/test_link_bonding.c:3992:
+					(struct rte_ether_addr *)test_params->default_slave_mac,

WARNING:LONG_LINE: line over 90 characters
#9945: FILE: test/test/test_link_bonding.c:3993:
+					(struct rte_ether_addr *)dst_mac_0, ETHER_TYPE_IPv4, 0, 0);

WARNING:LONG_LINE: line over 90 characters
#10040: FILE: test/test/test_link_bonding.c:4548:
+			eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);

WARNING:LONG_LINE: line over 90 characters
#10041: FILE: test/test/test_link_bonding.c:4549:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct rte_ether_hdr));

WARNING:LONG_LINE: line over 90 characters
#10123: FILE: test/test/test_link_bonding.c:4669:
+			eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);

WARNING:LONG_LINE: line over 90 characters
#10124: FILE: test/test/test_link_bonding.c:4670:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct rte_ether_hdr));

WARNING:LONG_LINE: line over 90 characters
#10167: FILE: test/test/test_link_bonding.c:4761:
+			eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);

ERROR:SPACING: space prohibited before that close parenthesis ')'
#10419: FILE: test/test/test_sched.c:87:
+	vlan1 = (struct rte_vlan_hdr *)(&eth_hdr->ether_type );

WARNING:LONG_LINE: line over 90 characters
#10420: FILE: test/test/test_sched.c:88:
+	vlan2 = (struct rte_vlan_hdr *)((uintptr_t)&eth_hdr->ether_type + sizeof(struct rte_vlan_hdr));

WARNING:LONG_LINE: line over 90 characters
#10421: FILE: test/test/test_sched.c:89:
+	eth_hdr = (struct rte_ether_hdr *)((uintptr_t)&eth_hdr->ether_type + 2 *sizeof(struct rte_vlan_hdr));

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#10421: FILE: test/test/test_sched.c:89:
+	eth_hdr = (struct rte_ether_hdr *)((uintptr_t)&eth_hdr->ether_type + 2 *sizeof(struct rte_vlan_hdr));
 	                                                                       ^

total: 5 errors, 28 warnings, 8377 lines checked