[dpdk-test-report] |WARNING| pw44395 [01/21] net/atlantic: atlantic PMD driver skeleton

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:24:39 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44395

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC	(8*1024-8)
                          	  ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC	(8*1024-8)
                          	       ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#401: FILE: drivers/net/atlantic/atl_ethdev.c:154:
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+		return 0;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#469: FILE: drivers/net/atlantic/atl_ethdev.c:222:
+		if (intr_vector > ATL_MAX_INTR_QUEUE_NUM) {
+			return -ENOTSUP;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#472: FILE: drivers/net/atlantic/atl_ethdev.c:225:
+		if (rte_intr_efd_enable(intr_handle, intr_vector)) {
+			return -1;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#480: FILE: drivers/net/atlantic/atl_ethdev.c:233:
+		if (intr_handle->intr_vec == NULL) {
+			return -ENOMEM;
+		}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#498: FILE: drivers/net/atlantic/atl_ethdev.c:251:
+{
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#499: FILE: drivers/net/atlantic/atl_ethdev.c:252:
+
+}

total: 0 errors, 4 warnings, 526 lines checked


More information about the test-report mailing list