[dpdk-test-report] |WARNING| pw44409 [14/21] net/atlantic: eeprom and register manipulation routines

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:24:59 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44409

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#35: FILE: drivers/net/atlantic/atl_ethdev.c:71:
+static int atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

WARNING:LONG_LINE: line over 90 characters
#36: FILE: drivers/net/atlantic/atl_ethdev.c:72:
+static int atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#82: FILE: drivers/net/atlantic/atl_ethdev.c:880:
+
+}

ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

total: 2 errors, 4 warnings, 1 checks, 95 lines checked


More information about the test-report mailing list