[dpdk-test-report] |WARNING| pw44487 [24/37] net/sfc/base: add routine to check for hardware presence

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44487

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#69: FILE: drivers/net/sfc/base/ef10_impl.h:193:
+extern	__checkReturn	boolean_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#70: FILE: drivers/net/sfc/base/ef10_impl.h:194:
+ef10_nic_hw_unavailable(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#85: FILE: drivers/net/sfc/base/ef10_nic.c:2308:
+ef10_nic_hw_unavailable(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#97: FILE: drivers/net/sfc/base/ef10_nic.c:2320:
+	return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#103: FILE: drivers/net/sfc/base/ef10_nic.c:2326:
+	return (B_TRUE);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/efx.h:159:
+efx_nic_hw_unavailable(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#140: FILE: drivers/net/sfc/base/efx_impl.h:360:
+	boolean_t	(*eno_hw_unavailable)(efx_nic_t *);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#155: FILE: drivers/net/sfc/base/efx_mcdi.c:502:
+		return (B_FALSE);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#202: FILE: drivers/net/sfc/base/efx_nic.c:660:
+efx_nic_hw_unavailable(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around function pointer (enop->eno_hw_unavailable)
#211: FILE: drivers/net/sfc/base/efx_nic.c:669:
+		if ((enop->eno_hw_unavailable)(enp) != B_FALSE)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enop->eno_hw_unavailable'
#211: FILE: drivers/net/sfc/base/efx_nic.c:669:
+		if ((enop->eno_hw_unavailable)(enp) != B_FALSE)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#220: FILE: drivers/net/sfc/base/efx_nic.c:678:
+	return (B_TRUE);

total: 4 errors, 1 warnings, 7 checks, 153 lines checked