[dpdk-test-report] |WARNING| pw44503 [37/37] net/sfc/base: add helper API to make Geneve filter spec

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Sep 10 11:40:29 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44503

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#34: FILE: drivers/net/sfc/base/efx.h:2962:
+efx_filter_spec_set_vxlan(

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#41: FILE: drivers/net/sfc/base/efx.h:2968:
+extern	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#42: FILE: drivers/net/sfc/base/efx.h:2969:
+efx_filter_spec_set_geneve(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#49: FILE: drivers/net/sfc/base/efx.h:2976:
+efx_filter_spec_set_nvgre(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#72: FILE: drivers/net/sfc/base/efx_filter.c:497:
+efx_filter_spec_set_tunnel(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'inner_addr == NULL'
#99: FILE: drivers/net/sfc/base/efx_filter.c:521:
+	if ((inner_addr == NULL) && (outer_addr == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'outer_addr == NULL'
#99: FILE: drivers/net/sfc/base/efx_filter.c:521:
+	if ((inner_addr == NULL) && (outer_addr == NULL)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#128: FILE: drivers/net/sfc/base/efx_filter.c:549:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#136: FILE: drivers/net/sfc/base/efx_filter.c:557:
+efx_filter_spec_set_vxlan(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#151: FILE: drivers/net/sfc/base/efx_filter.c:572:
+efx_filter_spec_set_geneve(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#166: FILE: drivers/net/sfc/base/efx_filter.c:587:
+efx_filter_spec_set_nvgre(

total: 1 errors, 0 warnings, 10 checks, 141 lines checked


More information about the test-report mailing list