[dpdk-test-report] |WARNING| pw52705 [PATCH v4 07/13] net/enetc: remove forward declarations

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 12 14:29:55 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52705

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#176: FILE: drivers/net/enetc/enetc_ethdev.c:521:
+static void^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#177: FILE: drivers/net/enetc/enetc_ethdev.c:522:
+enetc_dev_close(struct rte_eth_dev *dev)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#178: FILE: drivers/net/enetc/enetc_ethdev.c:523:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#179: FILE: drivers/net/enetc/enetc_ethdev.c:524:
+^Iuint16_t i;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#180: FILE: drivers/net/enetc/enetc_ethdev.c:525:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#181: FILE: drivers/net/enetc/enetc_ethdev.c:526:
+^IPMD_INIT_FUNC_TRACE();^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#182: FILE: drivers/net/enetc/enetc_ethdev.c:527:
+^Ienetc_dev_stop(dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#183: FILE: drivers/net/enetc/enetc_ethdev.c:528:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#184: FILE: drivers/net/enetc/enetc_ethdev.c:529:
+^Ifor (i = 0; i < dev->data->nb_rx_queues; i++) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#185: FILE: drivers/net/enetc/enetc_ethdev.c:530:
+^I^Ienetc_rx_queue_release(dev->data->rx_queues[i]);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#186: FILE: drivers/net/enetc/enetc_ethdev.c:531:
+^I^Idev->data->rx_queues[i] = NULL;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#187: FILE: drivers/net/enetc/enetc_ethdev.c:532:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#188: FILE: drivers/net/enetc/enetc_ethdev.c:533:
+^Idev->data->nb_rx_queues = 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#189: FILE: drivers/net/enetc/enetc_ethdev.c:534:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#190: FILE: drivers/net/enetc/enetc_ethdev.c:535:
+^Ifor (i = 0; i < dev->data->nb_tx_queues; i++) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#191: FILE: drivers/net/enetc/enetc_ethdev.c:536:
+^I^Ienetc_tx_queue_release(dev->data->tx_queues[i]);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#192: FILE: drivers/net/enetc/enetc_ethdev.c:537:
+^I^Idev->data->tx_queues[i] = NULL;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#193: FILE: drivers/net/enetc/enetc_ethdev.c:538:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#194: FILE: drivers/net/enetc/enetc_ethdev.c:539:
+^Idev->data->nb_tx_queues = 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#195: FILE: drivers/net/enetc/enetc_ethdev.c:540:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#196: FILE: drivers/net/enetc/enetc_ethdev.c:541:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#197: FILE: drivers/net/enetc/enetc_ethdev.c:542:
+/*^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#198: FILE: drivers/net/enetc/enetc_ethdev.c:543:
+ * The set of PCI devices this driver supports^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#199: FILE: drivers/net/enetc/enetc_ethdev.c:544:
+ */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#200: FILE: drivers/net/enetc/enetc_ethdev.c:545:
+static const struct rte_pci_id pci_id_enetc_map[] = {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#201: FILE: drivers/net/enetc/enetc_ethdev.c:546:
+^I{ RTE_PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, ENETC_DEV_ID) },^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#202: FILE: drivers/net/enetc/enetc_ethdev.c:547:
+^I{ RTE_PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, ENETC_DEV_ID_VF) },^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#203: FILE: drivers/net/enetc/enetc_ethdev.c:548:
+^I{ .vendor_id = 0, /* sentinel */ },^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#204: FILE: drivers/net/enetc/enetc_ethdev.c:549:
+};^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#205: FILE: drivers/net/enetc/enetc_ethdev.c:550:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#206: FILE: drivers/net/enetc/enetc_ethdev.c:551:
+/* Features supported by this driver */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#207: FILE: drivers/net/enetc/enetc_ethdev.c:552:
+static const struct eth_dev_ops enetc_ops = {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#208: FILE: drivers/net/enetc/enetc_ethdev.c:553:
+^I.dev_configure        = enetc_dev_configure,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#209: FILE: drivers/net/enetc/enetc_ethdev.c:554:
+^I.dev_start            = enetc_dev_start,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#210: FILE: drivers/net/enetc/enetc_ethdev.c:555:
+^I.dev_stop             = enetc_dev_stop,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#211: FILE: drivers/net/enetc/enetc_ethdev.c:556:
+^I.dev_close            = enetc_dev_close,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#212: FILE: drivers/net/enetc/enetc_ethdev.c:557:
+^I.link_update          = enetc_link_update,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#213: FILE: drivers/net/enetc/enetc_ethdev.c:558:
+^I.stats_get            = enetc_stats_get,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#214: FILE: drivers/net/enetc/enetc_ethdev.c:559:
+^I.stats_reset          = enetc_stats_reset,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#215: FILE: drivers/net/enetc/enetc_ethdev.c:560:
+^I.dev_infos_get        = enetc_dev_infos_get,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#216: FILE: drivers/net/enetc/enetc_ethdev.c:561:
+^I.rx_queue_setup       = enetc_rx_queue_setup,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#217: FILE: drivers/net/enetc/enetc_ethdev.c:562:
+^I.rx_queue_release     = enetc_rx_queue_release,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#218: FILE: drivers/net/enetc/enetc_ethdev.c:563:
+^I.tx_queue_setup       = enetc_tx_queue_setup,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#219: FILE: drivers/net/enetc/enetc_ethdev.c:564:
+^I.tx_queue_release     = enetc_tx_queue_release,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#220: FILE: drivers/net/enetc/enetc_ethdev.c:565:
+^I.dev_supported_ptypes_get = enetc_supported_ptypes_get,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#221: FILE: drivers/net/enetc/enetc_ethdev.c:566:
+};^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#222: FILE: drivers/net/enetc/enetc_ethdev.c:567:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#223: FILE: drivers/net/enetc/enetc_ethdev.c:568:
+/**^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#224: FILE: drivers/net/enetc/enetc_ethdev.c:569:
+ * Initialisation of the enetc device^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#225: FILE: drivers/net/enetc/enetc_ethdev.c:570:
+ *^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#226: FILE: drivers/net/enetc/enetc_ethdev.c:571:
+ * @param eth_dev^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#227: FILE: drivers/net/enetc/enetc_ethdev.c:572:
+ *   - Pointer to the structure rte_eth_dev^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#228: FILE: drivers/net/enetc/enetc_ethdev.c:573:
+ *^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#229: FILE: drivers/net/enetc/enetc_ethdev.c:574:
+ * @return^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#230: FILE: drivers/net/enetc/enetc_ethdev.c:575:
+ *   - On success, zero.^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#231: FILE: drivers/net/enetc/enetc_ethdev.c:576:
+ *   - On failure, negative value.^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#232: FILE: drivers/net/enetc/enetc_ethdev.c:577:
+ */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#233: FILE: drivers/net/enetc/enetc_ethdev.c:578:
+static int^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#234: FILE: drivers/net/enetc/enetc_ethdev.c:579:
+enetc_dev_init(struct rte_eth_dev *eth_dev)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#235: FILE: drivers/net/enetc/enetc_ethdev.c:580:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#236: FILE: drivers/net/enetc/enetc_ethdev.c:581:
+^Iint error = 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#237: FILE: drivers/net/enetc/enetc_ethdev.c:582:
+^Istruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#238: FILE: drivers/net/enetc/enetc_ethdev.c:583:
+^Istruct enetc_eth_hw *hw =^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#239: FILE: drivers/net/enetc/enetc_ethdev.c:584:
+^I^IENETC_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#240: FILE: drivers/net/enetc/enetc_ethdev.c:585:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#241: FILE: drivers/net/enetc/enetc_ethdev.c:586:
+^IPMD_INIT_FUNC_TRACE();^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#242: FILE: drivers/net/enetc/enetc_ethdev.c:587:
+^Ieth_dev->dev_ops = &enetc_ops;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#243: FILE: drivers/net/enetc/enetc_ethdev.c:588:
+^Ieth_dev->rx_pkt_burst = &enetc_recv_pkts;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#244: FILE: drivers/net/enetc/enetc_ethdev.c:589:
+^Ieth_dev->tx_pkt_burst = &enetc_xmit_pkts;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#245: FILE: drivers/net/enetc/enetc_ethdev.c:590:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#246: FILE: drivers/net/enetc/enetc_ethdev.c:591:
+^I/* Retrieving and storing the HW base address of device */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#247: FILE: drivers/net/enetc/enetc_ethdev.c:592:
+^Ihw->hw.reg = (void *)pci_dev->mem_resource[0].addr;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#248: FILE: drivers/net/enetc/enetc_ethdev.c:593:
+^Ihw->device_id = pci_dev->id.device_id;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#249: FILE: drivers/net/enetc/enetc_ethdev.c:594:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#250: FILE: drivers/net/enetc/enetc_ethdev.c:595:
+^Ierror = enetc_hardware_init(hw);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#251: FILE: drivers/net/enetc/enetc_ethdev.c:596:
+^Iif (error != 0) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#252: FILE: drivers/net/enetc/enetc_ethdev.c:597:
+^I^IENETC_PMD_ERR("Hardware initialization failed");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#253: FILE: drivers/net/enetc/enetc_ethdev.c:598:
+^I^Ireturn -1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#254: FILE: drivers/net/enetc/enetc_ethdev.c:599:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#255: FILE: drivers/net/enetc/enetc_ethdev.c:600:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#256: FILE: drivers/net/enetc/enetc_ethdev.c:601:
+^I/* Allocate memory for storing MAC addresses */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#257: FILE: drivers/net/enetc/enetc_ethdev.c:602:
+^Ieth_dev->data->mac_addrs = rte_zmalloc("enetc_eth", ETHER_ADDR_LEN, 0);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#258: FILE: drivers/net/enetc/enetc_ethdev.c:603:
+^Iif (!eth_dev->data->mac_addrs) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#259: FILE: drivers/net/enetc/enetc_ethdev.c:604:
+^I^IENETC_PMD_ERR("Failed to allocate %d bytes needed to "^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#260: FILE: drivers/net/enetc/enetc_ethdev.c:605:
+^I^I^I      "store MAC addresses",^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#261: FILE: drivers/net/enetc/enetc_ethdev.c:606:
+^I^I^I      ETHER_ADDR_LEN * 1);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#262: FILE: drivers/net/enetc/enetc_ethdev.c:607:
+^I^Ierror = -ENOMEM;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#263: FILE: drivers/net/enetc/enetc_ethdev.c:608:
+^I^Ireturn -1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#264: FILE: drivers/net/enetc/enetc_ethdev.c:609:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#265: FILE: drivers/net/enetc/enetc_ethdev.c:610:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#266: FILE: drivers/net/enetc/enetc_ethdev.c:611:
+^I/* Copy the permanent MAC address */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#267: FILE: drivers/net/enetc/enetc_ethdev.c:612:
+^Iether_addr_copy((struct ether_addr *)hw->mac.addr,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#268: FILE: drivers/net/enetc/enetc_ethdev.c:613:
+^I^I^I&eth_dev->data->mac_addrs[0]);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#269: FILE: drivers/net/enetc/enetc_ethdev.c:614:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#270: FILE: drivers/net/enetc/enetc_ethdev.c:615:
+^IENETC_PMD_DEBUG("port_id %d vendorID=0x%x deviceID=0x%x",^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#271: FILE: drivers/net/enetc/enetc_ethdev.c:616:
+^I^I^Ieth_dev->data->port_id, pci_dev->id.vendor_id,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#272: FILE: drivers/net/enetc/enetc_ethdev.c:617:
+^I^I^Ipci_dev->id.device_id);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#273: FILE: drivers/net/enetc/enetc_ethdev.c:618:
+^Ireturn 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#274: FILE: drivers/net/enetc/enetc_ethdev.c:619:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#275: FILE: drivers/net/enetc/enetc_ethdev.c:620:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#276: FILE: drivers/net/enetc/enetc_ethdev.c:621:
+static int^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#277: FILE: drivers/net/enetc/enetc_ethdev.c:622:
+enetc_dev_uninit(struct rte_eth_dev *eth_dev __rte_unused)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#278: FILE: drivers/net/enetc/enetc_ethdev.c:623:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#279: FILE: drivers/net/enetc/enetc_ethdev.c:624:
+^IPMD_INIT_FUNC_TRACE();^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#280: FILE: drivers/net/enetc/enetc_ethdev.c:625:
+^Ireturn 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#281: FILE: drivers/net/enetc/enetc_ethdev.c:626:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#282: FILE: drivers/net/enetc/enetc_ethdev.c:627:
+^M$

total: 107 errors, 0 warnings, 0 checks, 255 lines checked


More information about the test-report mailing list