[dpdk-test-report] |WARNING| pw52883 [PATCH v2 5/7] net/atlantic: implement macsec statistics

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Apr 17 17:45:58 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52883

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#39: FILE: drivers/net/atlantic/atl_ethdev.c:196:
+enum atl_xstats_type {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#40: FILE: drivers/net/atlantic/atl_ethdev.c:197:
+^IXSTATS_TYPE_MSM = 0,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#41: FILE: drivers/net/atlantic/atl_ethdev.c:198:
+^IXSTATS_TYPE_MACSEC,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#42: FILE: drivers/net/atlantic/atl_ethdev.c:199:
+};^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#43: FILE: drivers/net/atlantic/atl_ethdev.c:200:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#47: FILE: drivers/net/atlantic/atl_ethdev.c:203:
+^Ioffsetof(struct aq_stats_s, name), \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#48: FILE: drivers/net/atlantic/atl_ethdev.c:204:
+^IXSTATS_TYPE_MSM \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#49: FILE: drivers/net/atlantic/atl_ethdev.c:205:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#50: FILE: drivers/net/atlantic/atl_ethdev.c:206:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#51: FILE: drivers/net/atlantic/atl_ethdev.c:207:
+#define ATL_MACSEC_XSTATS_FIELD(name) { \^M$

WARNING:WHITESPACE_AFTER_LINE_CONTINUATION: Whitespace after \ makes next lines useless
#51: FILE: drivers/net/atlantic/atl_ethdev.c:207:
+#define ATL_MACSEC_XSTATS_FIELD(name) { \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#51: FILE: drivers/net/atlantic/atl_ethdev.c:207:
+#define ATL_MACSEC_XSTATS_FIELD(name) { \

ERROR:DOS_LINE_ENDINGS: DOS line endings
#52: FILE: drivers/net/atlantic/atl_ethdev.c:208:
+^I#name, \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#53: FILE: drivers/net/atlantic/atl_ethdev.c:209:
+^Ioffsetof(struct macsec_stats, name), \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#54: FILE: drivers/net/atlantic/atl_ethdev.c:210:
+^IXSTATS_TYPE_MACSEC \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#60: FILE: drivers/net/atlantic/atl_ethdev.c:216:
+^Ienum atl_xstats_type type;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#68: FILE: drivers/net/atlantic/atl_ethdev.c:234:
+^I/* Ingress Common Counters */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: drivers/net/atlantic/atl_ethdev.c:235:
+^IATL_MACSEC_XSTATS_FIELD(in_ctl_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#70: FILE: drivers/net/atlantic/atl_ethdev.c:236:
+^IATL_MACSEC_XSTATS_FIELD(in_tagged_miss_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#71: FILE: drivers/net/atlantic/atl_ethdev.c:237:
+^IATL_MACSEC_XSTATS_FIELD(in_untagged_miss_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#72: FILE: drivers/net/atlantic/atl_ethdev.c:238:
+^IATL_MACSEC_XSTATS_FIELD(in_notag_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: drivers/net/atlantic/atl_ethdev.c:239:
+^IATL_MACSEC_XSTATS_FIELD(in_untagged_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#74: FILE: drivers/net/atlantic/atl_ethdev.c:240:
+^IATL_MACSEC_XSTATS_FIELD(in_bad_tag_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#75: FILE: drivers/net/atlantic/atl_ethdev.c:241:
+^IATL_MACSEC_XSTATS_FIELD(in_no_sci_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#76: FILE: drivers/net/atlantic/atl_ethdev.c:242:
+^IATL_MACSEC_XSTATS_FIELD(in_unknown_sci_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#77: FILE: drivers/net/atlantic/atl_ethdev.c:243:
+^I/* Ingress SA Counters */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: drivers/net/atlantic/atl_ethdev.c:244:
+^IATL_MACSEC_XSTATS_FIELD(in_untagged_hit_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#79: FILE: drivers/net/atlantic/atl_ethdev.c:245:
+^IATL_MACSEC_XSTATS_FIELD(in_not_using_sa),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#80: FILE: drivers/net/atlantic/atl_ethdev.c:246:
+^IATL_MACSEC_XSTATS_FIELD(in_unused_sa),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#81: FILE: drivers/net/atlantic/atl_ethdev.c:247:
+^IATL_MACSEC_XSTATS_FIELD(in_not_valid_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#82: FILE: drivers/net/atlantic/atl_ethdev.c:248:
+^IATL_MACSEC_XSTATS_FIELD(in_invalid_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#83: FILE: drivers/net/atlantic/atl_ethdev.c:249:
+^IATL_MACSEC_XSTATS_FIELD(in_ok_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#84: FILE: drivers/net/atlantic/atl_ethdev.c:250:
+^IATL_MACSEC_XSTATS_FIELD(in_unchecked_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#85: FILE: drivers/net/atlantic/atl_ethdev.c:251:
+^IATL_MACSEC_XSTATS_FIELD(in_validated_octets),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#86: FILE: drivers/net/atlantic/atl_ethdev.c:252:
+^IATL_MACSEC_XSTATS_FIELD(in_decrypted_octets),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#87: FILE: drivers/net/atlantic/atl_ethdev.c:253:
+^I/* Egress Common Counters */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#88: FILE: drivers/net/atlantic/atl_ethdev.c:254:
+^IATL_MACSEC_XSTATS_FIELD(out_ctl_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#89: FILE: drivers/net/atlantic/atl_ethdev.c:255:
+^IATL_MACSEC_XSTATS_FIELD(out_unknown_sa_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#90: FILE: drivers/net/atlantic/atl_ethdev.c:256:
+^IATL_MACSEC_XSTATS_FIELD(out_untagged_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#91: FILE: drivers/net/atlantic/atl_ethdev.c:257:
+^IATL_MACSEC_XSTATS_FIELD(out_too_long),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#92: FILE: drivers/net/atlantic/atl_ethdev.c:258:
+^I/* Egress SC Counters */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#93: FILE: drivers/net/atlantic/atl_ethdev.c:259:
+^IATL_MACSEC_XSTATS_FIELD(out_sc_protected_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#94: FILE: drivers/net/atlantic/atl_ethdev.c:260:
+^IATL_MACSEC_XSTATS_FIELD(out_sc_encrypted_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#95: FILE: drivers/net/atlantic/atl_ethdev.c:261:
+^I/* Egress SA Counters */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#96: FILE: drivers/net/atlantic/atl_ethdev.c:262:
+^IATL_MACSEC_XSTATS_FIELD(out_sa_hit_drop_redirect),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#97: FILE: drivers/net/atlantic/atl_ethdev.c:263:
+^IATL_MACSEC_XSTATS_FIELD(out_sa_protected2_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#98: FILE: drivers/net/atlantic/atl_ethdev.c:264:
+^IATL_MACSEC_XSTATS_FIELD(out_sa_protected_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#99: FILE: drivers/net/atlantic/atl_ethdev.c:265:
+^IATL_MACSEC_XSTATS_FIELD(out_sa_encrypted_pkts),^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#108: FILE: drivers/net/atlantic/atl_ethdev.c:1016:
+^Istruct atl_adapter *adapter =^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#109: FILE: drivers/net/atlantic/atl_ethdev.c:1017:
+^I(struct atl_adapter *)dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#111: FILE: drivers/net/atlantic/atl_ethdev.c:1019:
+^Istruct get_stats req = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#112: FILE: drivers/net/atlantic/atl_ethdev.c:1020:
+^Istruct macsec_msg_fw_request msg = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#113: FILE: drivers/net/atlantic/atl_ethdev.c:1021:
+^Istruct macsec_msg_fw_response resp = { 0 };^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#114: FILE: drivers/net/atlantic/atl_ethdev.c:1022:
+^Iint err = -1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#120: FILE: drivers/net/atlantic/atl_ethdev.c:1028:
+^Iif (hw->aq_fw_ops->send_macsec_req != NULL) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#121: FILE: drivers/net/atlantic/atl_ethdev.c:1029:
+^I^Ireq.ingress_sa_index = 0xff;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#122: FILE: drivers/net/atlantic/atl_ethdev.c:1030:
+^I^Ireq.egress_sc_index = 0xff;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#123: FILE: drivers/net/atlantic/atl_ethdev.c:1031:
+^I^Ireq.egress_sa_index = 0xff;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#124: FILE: drivers/net/atlantic/atl_ethdev.c:1032:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#125: FILE: drivers/net/atlantic/atl_ethdev.c:1033:
+^I^Imsg.msg_type = macsec_get_stats_msg;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#126: FILE: drivers/net/atlantic/atl_ethdev.c:1034:
+^I^Imsg.stats = req;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#127: FILE: drivers/net/atlantic/atl_ethdev.c:1035:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#128: FILE: drivers/net/atlantic/atl_ethdev.c:1036:
+^I^Ierr = hw->aq_fw_ops->send_macsec_req(hw, &msg, &resp);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#129: FILE: drivers/net/atlantic/atl_ethdev.c:1037:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#130: FILE: drivers/net/atlantic/atl_ethdev.c:1038:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#137: FILE: drivers/net/atlantic/atl_ethdev.c:1042:
+^I^Iswitch (atl_xstats_tbl[i].type) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#138: FILE: drivers/net/atlantic/atl_ethdev.c:1043:
+^I^Icase XSTATS_TYPE_MSM:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#139: FILE: drivers/net/atlantic/atl_ethdev.c:1044:
+^I^I^Istats[i].value = *(u64 *)((uint8_t *)&hw->curr_stats +^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#140: FILE: drivers/net/atlantic/atl_ethdev.c:1045:
+^I^I^I^I^I atl_xstats_tbl[i].offset);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#141: FILE: drivers/net/atlantic/atl_ethdev.c:1046:
+^I^I^Ibreak;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: drivers/net/atlantic/atl_ethdev.c:1047:
+^I^Icase XSTATS_TYPE_MACSEC:^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: drivers/net/atlantic/atl_ethdev.c:1048:
+^I^I^Iif (err)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: drivers/net/atlantic/atl_ethdev.c:1049:
+^I^I^I^Igoto done;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: drivers/net/atlantic/atl_ethdev.c:1050:
+^I^I^Istats[i].value = *(u64 *)((uint8_t *)&resp.stats +^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: drivers/net/atlantic/atl_ethdev.c:1051:
+^I^I^I^I^I atl_xstats_tbl[i].offset);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#147: FILE: drivers/net/atlantic/atl_ethdev.c:1052:
+^I^I^Ibreak;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#148: FILE: drivers/net/atlantic/atl_ethdev.c:1053:
+^I^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#149: FILE: drivers/net/atlantic/atl_ethdev.c:1054:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#150: FILE: drivers/net/atlantic/atl_ethdev.c:1055:
+done:^M$

total: 78 errors, 1 warnings, 0 checks, 116 lines checked


More information about the test-report mailing list