[dpdk-test-report] |WARNING| pw57503 [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57503

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: lib/dpif-netdev-perf.h:194:
+    return rte_get_tsc_hz();$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#100: FILE: lib/dpif-netdev-perf.h:198:
+ * A dummy function is sufficient when building without DPDK_NETDEV. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: lib/dpif-netdev-perf.h:202:
+    return 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: lib/dpif-netdev.c:756:
+    uint64_t last_rcu_quiesced;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: lib/dpif-netdev.c:5451:
+    uint64_t rcu_quiesce_interval = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: lib/dpif-netdev.c:5494:
+    if (get_tsc_hz() > 1) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: lib/dpif-netdev.c:5495:
+        /* Calculate ~10 ms interval. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#141: FILE: lib/dpif-netdev.c:5496:
+        rcu_quiesce_interval = get_tsc_hz() / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: lib/dpif-netdev.c:5496:
+        rcu_quiesce_interval = get_tsc_hz() / 100;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#142: FILE: lib/dpif-netdev.c:5497:
+        pmd->last_rcu_quiesced = cycles_counter_get(s);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: lib/dpif-netdev.c:5497:
+        pmd->last_rcu_quiesced = cycles_counter_get(s);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: lib/dpif-netdev.c:5498:
+    }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: lib/dpif-netdev.c:5507:
+        /* Do RCU synchronization at fixed interval instead of doing it$

ERROR:CODE_INDENT: code indent should use tabs where possible
#153: FILE: lib/dpif-netdev.c:5508:
+         * at fixed number of iterations. This ensures that synchronization$

ERROR:CODE_INDENT: code indent should use tabs where possible
#154: FILE: lib/dpif-netdev.c:5509:
+         * would not be delayed long even at high load of packet$

ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/dpif-netdev.c:5510:
+         * processing. */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#155: FILE: lib/dpif-netdev.c:5510:
+         * processing. */

ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/dpif-netdev.c:5512:
+        if (rcu_quiesce_interval &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: lib/dpif-netdev.c:5512:
+        if (rcu_quiesce_interval &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#157: FILE: lib/dpif-netdev.c:5512:
+        if (rcu_quiesce_interval &&
[...]
+            if (!ovsrcu_try_quiesce()) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: lib/dpif-netdev.c:5513:
+            ((cycles_counter_get(s) - pmd->last_rcu_quiesced) >$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: lib/dpif-netdev.c:5513:
+            ((cycles_counter_get(s) - pmd->last_rcu_quiesced) >$

ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: lib/dpif-netdev.c:5514:
+             rcu_quiesce_interval)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/dpif-netdev.c:5514:
+             rcu_quiesce_interval)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: lib/dpif-netdev.c:5515:
+            if (!ovsrcu_try_quiesce()) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: lib/dpif-netdev.c:5515:
+            if (!ovsrcu_try_quiesce()) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/dpif-netdev.c:5516:
+                pmd->last_rcu_quiesced = cycles_counter_get(s);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/dpif-netdev.c:5516:
+                pmd->last_rcu_quiesced = cycles_counter_get(s);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: lib/dpif-netdev.c:5517:
+            }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: lib/dpif-netdev.c:5517:
+            }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/dpif-netdev.c:5518:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/dpif-netdev.c:5518:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#172: FILE: lib/dpif-netdev.c:5554:
+                if (rcu_quiesce_interval) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: lib/dpif-netdev.c:5554:
+                if (rcu_quiesce_interval) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#172: FILE: lib/dpif-netdev.c:5554:
+                if (rcu_quiesce_interval) {
+                    pmd->last_rcu_quiesced = cycles_counter_get(s);

ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: lib/dpif-netdev.c:5555:
+                    pmd->last_rcu_quiesced = cycles_counter_get(s);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/dpif-netdev.c:5555:
+                    pmd->last_rcu_quiesced = cycles_counter_get(s);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: lib/dpif-netdev.c:5556:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: lib/dpif-netdev.c:5556:
+                }$

total: 17 errors, 22 warnings, 102 lines checked