[dpdk-test-report] |WARNING| pw63782 [PATCH] app/test-fib: add test-fib application
checkpatch at dpdk.org
checkpatch at dpdk.org
Wed Dec 11 19:45:59 CET 2019
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63782
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#121: FILE: app/test-fib/main.c:26:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end_fld; \
+ errno = 0; \
+ val = strtoul((in), &end_fld, (base)); \
+ if (errno != 0 || end_fld[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end_fld + 1; \
+} while (0)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#158: FILE: app/test-fib/main.c:63:
+#define NIPQUAD(addr) \
+ (unsigned)((unsigned char *)&addr)[3], \
+ (unsigned)((unsigned char *)&addr)[2], \
+ (unsigned)((unsigned char *)&addr)[1], \
+ (unsigned)((unsigned char *)&addr)[0]
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#159: FILE: app/test-fib/main.c:64:
+ (unsigned)((unsigned char *)&addr)[3], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#160: FILE: app/test-fib/main.c:65:
+ (unsigned)((unsigned char *)&addr)[2], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#161: FILE: app/test-fib/main.c:66:
+ (unsigned)((unsigned char *)&addr)[1], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#162: FILE: app/test-fib/main.c:67:
+ (unsigned)((unsigned char *)&addr)[0]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#165: FILE: app/test-fib/main.c:70:
+#define NIPQUAD6(addr) \
+ ((uint8_t *)addr)[0] << 8 | \
+ ((uint8_t *)addr)[1], \
+ ((uint8_t *)addr)[2] << 8 | \
+ ((uint8_t *)addr)[3], \
+ ((uint8_t *)addr)[4] << 8 | \
+ ((uint8_t *)addr)[5], \
+ ((uint8_t *)addr)[6] << 8 | \
+ ((uint8_t *)addr)[7], \
+ ((uint8_t *)addr)[8] << 8 | \
+ ((uint8_t *)addr)[9], \
+ ((uint8_t *)addr)[10] << 8 | \
+ ((uint8_t *)addr)[11], \
+ ((uint8_t *)addr)[12] << 8 | \
+ ((uint8_t *)addr)[13], \
+ ((uint8_t *)addr)[14] << 8 | \
+ ((uint8_t *)addr)[15]
total: 2 errors, 5 warnings, 1289 lines checked
More information about the test-report
mailing list