[dpdk-test-report] |WARNING| pw50433 [RFC, v3, 2/5] test/rcu_qsbr: add API and functional tests

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Feb 22 08:06:51 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50433

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#135: FILE: test/test/test_rcu_qsbr.c:18:
+#define RCU_QSBR_RETURN_IF_ERROR(cond, str, ...) do { \
+	if (cond) { \
+		printf("ERROR file %s, line %d: " str "
", __FILE__, \
+			__LINE__, ##__VA_ARGS__); \
+		return -1; \
+	} \
+} while (0)

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#992: FILE: test/test/test_rcu_qsbr_perf.c:38:
+extern int test_rcu_qsbr_get_memsize(void);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1060: FILE: test/test/test_rcu_qsbr_perf.c:106:
+		if (wait) rte_rcu_qsbr_start(&t, 1, &token);

total: 1 errors, 2 warnings, 1160 lines checked


More information about the test-report mailing list