[dpdk-test-report] |WARNING| pw50449 [v2] lib/metrics: add unregister api for metrics

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Feb 22 14:57:48 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50449

_coding style issues_


ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#35: FILE: lib/librte_latencystats/rte_latencystats.c

ERROR:TRAILING_WHITESPACE: trailing whitespace
#53: FILE: lib/librte_latencystats/rte_latencystats.c:294:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#56: FILE: lib/librte_latencystats/rte_latencystats.c:297:
+^I$

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#62: FILE: lib/librte_metrics/rte_metrics.c

ERROR:TRAILING_WHITESPACE: trailing whitespace
#121: FILE: lib/librte_metrics/rte_metrics.c:79:
+^I^Irte_exit(EXIT_FAILURE, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#128: FILE: lib/librte_metrics/rte_metrics.c:86:
+^I^Irte_exit(EXIT_FAILURE, $

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#129: FILE: lib/librte_metrics/rte_metrics.c:87:
+				"Failed to init vlan bitmap for bonded device 
");

ERROR:SPACING: space required after that ',' (ctx:VxV)
#141: FILE: lib/librte_metrics/rte_metrics.c:108:
+	uint16_t idx_name,idx;
 	                 ^

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#160: FILE: lib/librte_metrics/rte_metrics.c:129:
+	for (idx_name = 0; idx_name < RTE_METRICS_MAX_METRICS; idx_name++)
+	{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#162: FILE: lib/librte_metrics/rte_metrics.c:131:
+		if(!rte_bitmap_get(stats->bits,idx_name))
+		{

ERROR:SPACING: space required after that ',' (ctx:VxV)
#162: FILE: lib/librte_metrics/rte_metrics.c:131:
+		if(!rte_bitmap_get(stats->bits,idx_name))
 		                              ^

ERROR:SPACING: space required before the open parenthesis '('
#162: FILE: lib/librte_metrics/rte_metrics.c:131:
+		if(!rte_bitmap_get(stats->bits,idx_name))

ERROR:SPACING: space required before the open parenthesis '('
#165: FILE: lib/librte_metrics/rte_metrics.c:134:
+			if(idx_base + cnt_names > RTE_METRICS_MAX_METRICS)

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#167: FILE: lib/librte_metrics/rte_metrics.c:136:
+			for(idx = idx_base; idx < idx_base+cnt_names; idx++)
+			{

ERROR:SPACING: space required before the open parenthesis '('
#167: FILE: lib/librte_metrics/rte_metrics.c:136:
+			for(idx = idx_base; idx < idx_base+cnt_names; idx++)

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#169: FILE: lib/librte_metrics/rte_metrics.c:138:
+				if(rte_bitmap_get(stats->bits, idx))
+				{

ERROR:SPACING: space required before the open parenthesis '('
#169: FILE: lib/librte_metrics/rte_metrics.c:138:
+				if(rte_bitmap_get(stats->bits, idx))

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#174: FILE: lib/librte_metrics/rte_metrics.c:143:
+			if(idx == idx_base+cnt_names)
+			{

ERROR:SPACING: space required before the open parenthesis '('
#174: FILE: lib/librte_metrics/rte_metrics.c:143:
+			if(idx == idx_base+cnt_names)

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#183: FILE: lib/librte_metrics/rte_metrics.c:150:
+	for(idx = idx_base; idx < idx_base+cnt_names; idx++)
+	{

ERROR:SPACING: space required before the open parenthesis '('
#183: FILE: lib/librte_metrics/rte_metrics.c:150:
+	for(idx = idx_base; idx < idx_base+cnt_names; idx++)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: lib/librte_metrics/rte_metrics.c:157:
+    }$

ERROR:SPACING: space required before the open brace '{'
#216: FILE: lib/librte_metrics/rte_metrics.c:200:
+		if(rte_bitmap_get(stats->bits, idx_metric)){

ERROR:SPACING: space required before the open parenthesis '('
#216: FILE: lib/librte_metrics/rte_metrics.c:200:
+		if(rte_bitmap_get(stats->bits, idx_metric)){

ERROR:SPACING: space required after that close brace '}'
#219: FILE: lib/librte_metrics/rte_metrics.c:203:
+		}else

ERROR:SPACING: space prohibited before that close parenthesis ')'
#239: FILE: lib/librte_metrics/rte_metrics.c:238:
+	if (count < 1 )

ERROR:TRAILING_WHITESPACE: trailing whitespace
#245: FILE: lib/librte_metrics/rte_metrics.c:244:
+^I$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#250: FILE: lib/librte_metrics/rte_metrics.c:249:
+	if (key >= RTE_METRICS_MAX_METRICS) {
+		return -EINVAL;
+	}

ERROR:SPACING: space required after that ',' (ctx:VxV)
#259: FILE: lib/librte_metrics/rte_metrics.c:258:
+		if(rte_bitmap_get(stats->bits,idx_metric)){
 		                             ^

ERROR:SPACING: space required before the open brace '{'
#259: FILE: lib/librte_metrics/rte_metrics.c:258:
+		if(rte_bitmap_get(stats->bits,idx_metric)){

ERROR:SPACING: space required before the open parenthesis '('
#259: FILE: lib/librte_metrics/rte_metrics.c:258:
+		if(rte_bitmap_get(stats->bits,idx_metric)){

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#262: FILE: lib/librte_metrics/rte_metrics.c:261:
+		}else
+		break;

ERROR:SPACING: space required after that close brace '}'
#262: FILE: lib/librte_metrics/rte_metrics.c:261:
+		}else

ERROR:TRAILING_WHITESPACE: trailing whitespace
#271: FILE: lib/librte_metrics/rte_metrics.c:270:
+^I$

WARNING:SPACING: space prohibited before semicolon
#274: FILE: lib/librte_metrics/rte_metrics.c:273:
+		memset(stats->metadata[idx_metric].name, 0, RTE_METRICS_MAX_NAME_LEN) ;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#291: FILE: lib/librte_metrics/rte_metrics.c:289:
+	uint16_t idx_name, idx=0;
 	                      ^

WARNING:LONG_LINE: line over 90 characters
#303: FILE: lib/librte_metrics/rte_metrics.c:304:
+		for (idx_name = 0;idx< stats->cnt_stats && idx_name < RTE_METRICS_MAX_METRICS; idx_name++)

ERROR:SPACING: space required after that ';' (ctx:VxV)
#303: FILE: lib/librte_metrics/rte_metrics.c:304:
+		for (idx_name = 0;idx< stats->cnt_stats && idx_name < RTE_METRICS_MAX_METRICS; idx_name++)
 		                 ^

ERROR:SPACING: spaces required around that '<' (ctx:VxW)
#303: FILE: lib/librte_metrics/rte_metrics.c:304:
+		for (idx_name = 0;idx< stats->cnt_stats && idx_name < RTE_METRICS_MAX_METRICS; idx_name++)
 		                     ^

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#304: FILE: lib/librte_metrics/rte_metrics.c:305:
+			if(rte_bitmap_get(stats->bits,idx_name))
+			{

ERROR:SPACING: space required after that ',' (ctx:VxV)
#304: FILE: lib/librte_metrics/rte_metrics.c:305:
+			if(rte_bitmap_get(stats->bits,idx_name))
 			                             ^

ERROR:SPACING: space required before the open parenthesis '('
#304: FILE: lib/librte_metrics/rte_metrics.c:305:
+			if(rte_bitmap_get(stats->bits,idx_name))

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#309: FILE: lib/librte_metrics/rte_metrics.c:310:
+				idx ++;
 				    ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#319: FILE: lib/librte_metrics/rte_metrics.c:326:
+	uint16_t idx_name, idx=0;
 	                      ^

ERROR:SPACING: space required after that ';' (ctx:VxV)
#340: FILE: lib/librte_metrics/rte_metrics.c:347:
+		for (idx_name = 0;idx< stats->cnt_stats &&
 		                 ^

ERROR:SPACING: spaces required around that '<' (ctx:VxW)
#340: FILE: lib/librte_metrics/rte_metrics.c:347:
+		for (idx_name = 0;idx< stats->cnt_stats &&
 		                     ^

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#343: FILE: lib/librte_metrics/rte_metrics.c:350:
+			if(rte_bitmap_get(stats->bits,idx_name))
+			{

ERROR:SPACING: space required after that ',' (ctx:VxV)
#343: FILE: lib/librte_metrics/rte_metrics.c:350:
+			if(rte_bitmap_get(stats->bits,idx_name))
 			                             ^

ERROR:SPACING: space required before the open parenthesis '('
#343: FILE: lib/librte_metrics/rte_metrics.c:350:
+			if(rte_bitmap_get(stats->bits,idx_name))

ERROR:TRAILING_WHITESPACE: trailing whitespace
#355: FILE: lib/librte_metrics/rte_metrics.c:360:
+^I^I}^I^I$

WARNING:TYPO_SPELLING: 'registerd' may be misspelled - perhaps 'registered'?
#372: FILE: lib/librte_metrics/rte_metrics.h:128:
+ * Remove the metrics previously registerd

total: 44 errors, 7 warnings, 329 lines checked


More information about the test-report mailing list