[dpdk-test-report] |WARNING| pw50632 [6/8] net/ice: support RX AVX2 vector

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Feb 28 08:44:24 CET 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/50632

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#218: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:99:
+		vaddr0_1 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#220: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:101:
+		vaddr2_3 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#284: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:165:
+	const __m256i crc_adjust = _mm256_set_epi16(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#307: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:188:
+	const __m256i shuf_msk = _mm256_set_epi8(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#346: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:227:
+	const __m256i flags_mask = _mm256_set1_epi32(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#353: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:234:
+	const __m256i vlan_flags_shuf = _mm256_set_epi32(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#361: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:242:
+	const __m256i rss_flags_shuf = _mm256_set_epi8(

WARNING:LONG_LINE: line over 90 characters
#375: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:256:
+			(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,

WARNING:LONG_LINE: line over 90 characters
#376: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:257:
+			(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD) >> 1,

WARNING:LONG_LINE: line over 90 characters
#385: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:266:
+			(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,

WARNING:LONG_LINE: line over 90 characters
#386: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:267:
+			(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD) >> 1,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#394: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:275:
+	const __m256i cksum_mask = _mm256_set1_epi32(

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#425: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:306:
+		} else
[...]
+		do {

CHECK:BRACES: Unbalanced braces around else statement
#425: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:306:
+		} else

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#444: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:325:
+			raw_desc6_7 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#446: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:327:
+			raw_desc4_5 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#448: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:329:
+			raw_desc2_3 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#450: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:331:
+			raw_desc0_1 = _mm256_inserti128_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#528: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:409:
+		const __m256i flag_bits = _mm256_and_si256(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#531: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:412:
+		const __m256i vlan_flags = _mm256_shuffle_epi8(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#533: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:414:
+		const __m256i rss_flags = _mm256_shuffle_epi8(

WARNING:LONG_LINE: line over 90 characters
#566: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:447:
+		rearm6 = _mm256_blend_epi32(mbuf_init, _mm256_slli_si256(mbuf_flags, 8), 0x04);

WARNING:LONG_LINE: line over 90 characters
#567: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:448:
+		rearm4 = _mm256_blend_epi32(mbuf_init, _mm256_slli_si256(mbuf_flags, 4), 0x04);

WARNING:LONG_LINE: line over 90 characters
#569: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:450:
+		rearm0 = _mm256_blend_epi32(mbuf_init, _mm256_srli_si256(mbuf_flags, 4), 0x04);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#582: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:463:
+		const __m256i odd_flags = _mm256_castsi128_si256(

WARNING:LONG_LINE: line over 90 characters
#584: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:465:
+		rearm7 = _mm256_blend_epi32(mbuf_init, _mm256_slli_si256(odd_flags, 8), 0x04);

WARNING:LONG_LINE: line over 90 characters
#585: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:466:
+		rearm5 = _mm256_blend_epi32(mbuf_init, _mm256_slli_si256(odd_flags, 4), 0x04);

WARNING:LONG_LINE: line over 90 characters
#587: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:468:
+		rearm1 = _mm256_blend_epi32(mbuf_init, _mm256_srli_si256(odd_flags, 4), 0x04);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#601: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:482:
+			const __m128i eop_mask = _mm_set1_epi16(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#606: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:487:
+			const __m128i eop_bits = _mm_packus_epi32(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#623: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:504:
+			__m128i eop_shuffle = _mm_set_epi8(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#638: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:519:
+		uint64_t burst = __builtin_popcountll(_mm_cvtsi128_si64(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#640: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:521:
+		burst += __builtin_popcountll(_mm_cvtsi128_si64(

total: 0 errors, 12 warnings, 22 checks, 639 lines checked


More information about the test-report mailing list