[dpdk-test-report] |WARNING| pw56399 [PATCH v4 07/11] net/softnic: add config flexibility to softnic tm

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jul 12 11:59:07 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56399

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#367: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:834:
+					for (q = 0; q < RTE_SCHED_BE_QUEUES_PER_PIPE; q++) {

WARNING:LONG_LINE: line over 90 characters
#369: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:836:
+							queue_node_id(n_spp, n_pps, s, p, t, q),

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#376: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:843:
+						if (status)

CHECK:BRACES: braces {} should be used on all arms of this statement
#634: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1205:
+	if (strcmp(tokens[51], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#636: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1207:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#651: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1222:
+	if (strcmp(tokens[53], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#653: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1224:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#668: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1239:
+	if (strcmp(tokens[55], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#670: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1241:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#685: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1256:
+	if (strcmp(tokens[57], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#687: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1258:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#702: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1273:
+	if (strcmp(tokens[59], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#704: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1275:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#719: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1290:
+	if (strcmp(tokens[61], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#721: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1292:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#736: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1307:
+	if (strcmp(tokens[63], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#738: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1309:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#753: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1324:
+	if (strcmp(tokens[65], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#755: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1326:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#770: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1341:
+	if (strcmp(tokens[67], "none") == 0)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#772: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1343:
+	else {

WARNING:LONG_LINE: line over 90 characters
#854: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:371:
+		(n_queues_max * RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE) / RTE_SCHED_QUEUES_PER_PIPE;

total: 0 errors, 4 warnings, 18 checks, 944 lines checked


More information about the test-report mailing list