[dpdk-test-report] |WARNING| pw57323 [PATCH v4 2/2] vhost: Add vhost-user-blk example which support inflight

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jul 31 14:58:16 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57323

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#473: FILE: examples/vhost_blk/vhost_blk.c:96:
+	if (!!(cur_desc->flags & VIRTQ_DESC_F_NEXT)) {
+		return &inflight_packed->desc[cur_desc->next];
+	}

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#820: FILE: examples/vhost_blk/vhost_blk.c:443:
+		chunck_len = task->inflight_desc->len;;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#901: FILE: examples/vhost_blk/vhost_blk.c:524:
+^Iwhile (j++ < 1000000 && $

WARNING:LONG_LINE: line over 90 characters
#923: FILE: examples/vhost_blk/vhost_blk.c:546:
+		task[i]->desc_packed = descriptor_get_next_packed(task[i]->vq, &avail_idx);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#955: FILE: examples/vhost_blk/vhost_blk.c:578:
+		if (g_should_stop == 1) {
+			goto free_task;
+		}

WARNING:LONG_LINE: line over 90 characters
#1253: FILE: examples/vhost_blk/vhost_blk.c:876:
+	while (j++ < 1000000 && vq->avail->idx != blk_vq->last_avail_idx && i < MAX_TASK) {

WARNING:LONG_LINE: line over 90 characters
#1263: FILE: examples/vhost_blk/vhost_blk.c:886:
+		rte_vhost_set_inflight_desc_split(ctrlr->bdev->vid, q_idx, task[i]->req_idx);

ERROR:SPACING: space required before the open parenthesis '('
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+	while(g_should_stop != 2);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+	while(g_should_stop != 2);

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'JinYu <jin.yu at intel.com>'

total: 3 errors, 7 warnings, 1883 lines checked


More information about the test-report mailing list