[dpdk-test-report] |WARNING| pw54167 [PATCH v3 05/11] net/hinic/base: add eqs and context code

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jun 3 13:28:31 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54167

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sqs' - possible side-effects?
#69: FILE: drivers/net/hinic/base/hinic_ctx_def.h:31:
+#define RQ_CTXT_OFFSET(max_sqs, max_rqs, q_id)	\
+			(((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE \
+			+ (max_sqs) * Q_CTXT_SIZE + (q_id) * Q_CTXT_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#479: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:99:
+#define EQ_CONS_IDX(eq)		((eq)->cons_idx | \
+				((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#482: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:102:
+#define EQ_CONS_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#486: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:106:
+#define EQ_PROD_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#490: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#490: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#496: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#496: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#505: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:125:
+#define GET_CURR_AEQ_ELEM(eq)		GET_AEQ_ELEM((eq), (eq)->cons_idx)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#522: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:142:
+#define aeq_to_aeqs(eq) \
+		container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0])

total: 0 errors, 0 warnings, 10 checks, 1149 lines checked


More information about the test-report mailing list