[dpdk-test-report] |WARNING| pw54586 [PATCH 01/29] net/sfc/base: enable chained multicast on all EF10 cards

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 13 15:53:47 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54586

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#48: FILE: drivers/net/sfc/base/ef10_nic.c:1756:
+ef10_set_workaround_bug26807(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#51: FILE: drivers/net/sfc/base/ef10_nic.c:1759:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#94: FILE: drivers/net/sfc/base/ef10_nic.c:1802:
+	return (rc);

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#97: FILE: drivers/net/sfc/base/ef10_nic.c:1805:
+static	__checkReturn	efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#105: FILE: drivers/net/sfc/base/ef10_nic.c:1963:
+	if ((rc = ef10_set_workaround_bug26807(enp)) != 0)

total: 2 errors, 0 warnings, 3 checks, 160 lines checked


More information about the test-report mailing list