[dpdk-test-report] |WARNING| pw54611 [PATCH 28/29] net/sfc/base: provide API to fetch vPort statistics

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54611

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#41: FILE: drivers/net/sfc/base/ef10_evb.c:539:
+	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#42: FILE: drivers/net/sfc/base/ef10_evb.c:540:
+ef10_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#65: FILE: drivers/net/sfc/base/ef10_impl.h:1355:
+ef10_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/net/sfc/base/efx.h:3449:
+efx_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/efx_evb.c:507:
+efx_evb_vport_stats(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/net/sfc/base/efx_evb.c:533:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/efx_evb.c:541:
+	return (rc);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efsys_mem_t *' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#189: FILE: drivers/net/sfc/base/efx_impl.h:1379:
+efx_mcdi_mac_stats(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#237: FILE: drivers/net/sfc/base/efx_mcdi.c:1939:
+	if ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, NULL,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#247: FILE: drivers/net/sfc/base/efx_mcdi.c:1963:
+	if ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, esmp,

total: 4 errors, 4 warnings, 6 checks, 201 lines checked