[dpdk-test-report] |WARNING| pw54749 [PATCH v1 4/9] fslmc: identify internal only functions and tag them as __rte_internal

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54749

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#818: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_debug.h:29:
+uint32_t __rte_internal qbman_fq_state_frame_count(const struct qbman_fq_query_np_rslt *r);

WARNING:LONG_LINE: line over 90 characters
#838: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:280:
+void __rte_internal qbman_swp_push_set(struct qbman_swp *s, uint8_t channel_idx, int enable);

WARNING:LONG_LINE: line over 90 characters
#908: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:429:
+void __rte_internal qbman_swp_dqrr_consume(struct qbman_swp *s, const struct qbman_result *dq);

WARNING:LONG_LINE: line over 90 characters
#934: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:454:
+struct qbman_result *__rte_internal qbman_get_dqrr_from_idx(struct qbman_swp *s, uint8_t idx);

WARNING:LONG_LINE: line over 90 characters
#1018: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:864:
+void __rte_internal qbman_eq_desc_set_no_orp(struct qbman_eq_desc *d, int respond_success);

WARNING:LONG_LINE: line over 90 characters
#1090: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:991:
+void __rte_internal qbman_result_eqresp_set_rspid(struct qbman_result *eqresp, uint8_t val);

WARNING:LONG_LINE: line over 90 characters
#1151: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:1117:
+void __rte_internal qbman_release_desc_set_bpid(struct qbman_release_desc *d, uint16_t bpid);

WARNING:LONG_LINE: line over 90 characters
#1160: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:1135:
+int __rte_internal qbman_swp_release(struct qbman_swp *s, const struct qbman_release_desc *d,

WARNING:LONG_LINE: line over 90 characters
#1169: FILE: drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h:1160:
+int __rte_internal qbman_swp_acquire(struct qbman_swp *s, uint16_t bpid, uint64_t *buffers,

WARNING:LONG_LINE: line over 90 characters
#1304: FILE: drivers/bus/fslmc/qbman/qbman_portal.c:1166:
+void __rte_internal qbman_swp_push_set(struct qbman_swp *s, uint8_t channel_idx, int enable)

WARNING:LONG_LINE: line over 90 characters
#1469: FILE: drivers/bus/fslmc/qbman/qbman_portal.c:1741:
+void __rte_internal qbman_result_eqresp_set_rspid(struct qbman_result *eqresp, uint8_t val)

WARNING:LONG_LINE: line over 90 characters
#1497: FILE: drivers/bus/fslmc/qbman/qbman_portal.c:1771:
+void __rte_internal qbman_release_desc_set_bpid(struct qbman_release_desc *d, uint16_t bpid)

WARNING:LONG_LINE: line over 90 characters
#1515: FILE: drivers/bus/fslmc/qbman/qbman_portal.c:1882:
+int __rte_internal qbman_swp_acquire(struct qbman_swp *s, uint16_t bpid, uint64_t *buffers,

WARNING:LONG_LINE: line over 90 characters
#1530: FILE: drivers/bus/fslmc/qbman/qbman_portal.c:2105:
+struct qbman_result *__rte_internal qbman_get_dqrr_from_idx(struct qbman_swp *s, uint8_t idx)

total: 0 errors, 14 warnings, 1459 lines checked
INFO: symbol dpaa2_affine_qbman_ethrx_swp is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_affine_qbman_ethrx_swp is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol dpaa2_alloc_dpbp_dev is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_alloc_dpbp_dev is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_alloc_dq_storage is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_alloc_dq_storage is being removed, ensure that it has gone through the deprecation process
INFO: symbol dpaa2_dpbp_supported is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_dpbp_supported is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_dqrr_size is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_dqrr_size is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_eqcr_size is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_eqcr_size is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol dpaa2_free_dpbp_dev is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_free_dpbp_dev is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_free_dq_storage is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_free_dq_storage is being removed, ensure that it has gone through the deprecation process
INFO: symbol dpaa2_free_eq_descriptors is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_free_eq_descriptors is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_get_qbman_swp is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_get_qbman_swp is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_io_portal is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_io_portal is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_svr_family is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_svr_family is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpaa2_virt_mode is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpaa2_virt_mode is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol dpbp_disable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_disable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpbp_enable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_enable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpbp_get_attributes is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_get_attributes is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpbp_get_num_free_bufs is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_get_num_free_bufs is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpbp_open is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_open is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpbp_reset is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpbp_reset is being removed, ensure that it has gone through the deprecation process
INFO: symbol dpci_get_opr is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpci_get_opr is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpci_set_opr is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpci_set_opr is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpci_set_rx_queue is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpci_set_rx_queue is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpcon_get_attributes is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpcon_get_attributes is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpcon_open is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpcon_open is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_close is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_close is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_disable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_disable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_enable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_enable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_get_attributes is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_get_attributes is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_get_rx_queue is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_get_rx_queue is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_get_tx_queue is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_get_tx_queue is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_open is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_open is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpdmai_set_rx_queue is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpdmai_set_rx_queue is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_add_static_dequeue_channel is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_add_static_dequeue_channel is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol dpio_close is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_close is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_disable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_disable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_enable is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_enable is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_get_attributes is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_get_attributes is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_open is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_open is being removed, ensure that it has gone through the deprecation process
INFO: symbol dpio_remove_static_dequeue_channel is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_remove_static_dequeue_channel is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol dpio_reset is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_reset is being removed, ensure that it has gone through the deprecation process
ERROR: symbol dpio_set_stashing_destination is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol dpio_set_stashing_destination is being removed, ensure that it has gone through the deprecation process
INFO: symbol mc_get_soc_version is being removed, ensure that it has gone through the deprecation process
ERROR: symbol mc_get_soc_version is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol mc_get_version is being removed, ensure that it has gone through the deprecation process
ERROR: symbol mc_get_version is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol mc_send_command is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol mc_send_command is being removed, ensure that it has gone through the deprecation process
INFO: symbol per_lcore_dpaa2_held_bufs is being removed, ensure that it has gone through the deprecation process
ERROR: symbol per_lcore_dpaa2_held_bufs is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol per_lcore__dpaa2_io is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol per_lcore__dpaa2_io is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_check_command_complete is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_check_command_complete is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_check_new_result is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_check_new_result is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_eq_desc_clear is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_eq_desc_clear is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_eq_desc_set_dca is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_eq_desc_set_dca is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_eq_desc_set_fq is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_eq_desc_set_fq is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_eq_desc_set_no_orp is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_eq_desc_set_no_orp is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_eq_desc_set_orp is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_eq_desc_set_orp is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_eq_desc_set_qd is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_eq_desc_set_qd is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_eq_desc_set_response is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_eq_desc_set_response is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_eq_desc_set_token is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_eq_desc_set_token is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_fq_query_state is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_fq_query_state is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_fq_state_frame_count is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_fq_state_frame_count is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_get_dqrr_from_idx is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_get_dqrr_from_idx is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_get_dqrr_idx is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_get_dqrr_idx is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_pull_desc_clear is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_pull_desc_clear is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_pull_desc_set_fq is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_pull_desc_set_fq is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_pull_desc_set_numframes is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_pull_desc_set_numframes is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_pull_desc_set_storage is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_pull_desc_set_storage is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_release_desc_clear is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_release_desc_clear is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_release_desc_set_bpid is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_release_desc_set_bpid is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_DQ_fd is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_DQ_fd is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_DQ_flags is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_DQ_flags is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_result_DQ_fqd_ctx is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_DQ_fqd_ctx is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_DQ_odpid is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_DQ_odpid is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_DQ_seqnum is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_DQ_seqnum is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_eqresp_fd is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_eqresp_fd is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_eqresp_rc is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_eqresp_rc is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_eqresp_rspid is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_eqresp_rspid is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_eqresp_set_rspid is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_eqresp_set_rspid is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_result_has_new_result is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_result_has_new_result is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_result_SCN_state is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_result_SCN_state is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_swp_acquire is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_acquire is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_swp_dqrr_consume is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_dqrr_consume is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_dqrr_idx_consume is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_dqrr_idx_consume is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_dqrr_next is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_dqrr_next is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_enqueue_multiple_desc is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_enqueue_multiple_desc is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_enqueue_multiple is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_swp_enqueue_multiple_fd is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_enqueue_multiple_fd is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_swp_enqueue_multiple is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_interrupt_clear_status is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_interrupt_clear_status is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_prefetch_dqrr_next is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_prefetch_dqrr_next is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_swp_pull is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_pull is being removed, ensure that it has gone through the deprecation process
INFO: symbol qbman_swp_push_set is being removed, ensure that it has gone through the deprecation process
ERROR: symbol qbman_swp_push_set is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol qbman_swp_release is added in the INTERNAL section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol qbman_swp_release is being removed, ensure that it has gone through the deprecation process