[dpdk-test-report] |WARNING| pw54972 [PATCH 18/28] drivers/virtio_vhost_user: add virtio PCI framework

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54972

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#603: FILE: drivers/virtio_vhost_user/virtio_pci.h:44:
+				      * also clears the register (8, RO) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#607: FILE: drivers/virtio_vhost_user/virtio_pci.h:48:
+#define VIRTIO_MSI_QUEUE_VECTOR	  22 /* vector for selected VQ notifications
+				      (16, RW) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#607: FILE: drivers/virtio_vhost_user/virtio_pci.h:48:
+				      (16, RW) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#640: FILE: drivers/virtio_vhost_user/virtio_pci.h:81:
+ * suppressed them? */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#664: FILE: drivers/virtio_vhost_user/virtio_pci.h:105:
+ * at the end of the avail ring. Host should ignore the avail->flags field. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#666: FILE: drivers/virtio_vhost_user/virtio_pci.h:107:
+ * at the end of the used ring. Guest should ignore the used->flags field. */

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#810: FILE: drivers/virtio_vhost_user/virtio_pci.h:251:
+void virtio_pci_reset(struct virtio_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#812: FILE: drivers/virtio_vhost_user/virtio_pci.h:253:
+void virtio_pci_reinit_complete(struct virtio_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#814: FILE: drivers/virtio_vhost_user/virtio_pci.h:255:
+uint8_t virtio_pci_get_status(struct virtio_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#815: FILE: drivers/virtio_vhost_user/virtio_pci.h:256:
+void virtio_pci_set_status(struct virtio_hw *, uint8_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#815: FILE: drivers/virtio_vhost_user/virtio_pci.h:256:
+void virtio_pci_set_status(struct virtio_hw *, uint8_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#817: FILE: drivers/virtio_vhost_user/virtio_pci.h:258:
+uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#817: FILE: drivers/virtio_vhost_user/virtio_pci.h:258:
+uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#819: FILE: drivers/virtio_vhost_user/virtio_pci.h:260:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#819: FILE: drivers/virtio_vhost_user/virtio_pci.h:260:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const void *' should also have an identifier name
#819: FILE: drivers/virtio_vhost_user/virtio_pci.h:260:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#819: FILE: drivers/virtio_vhost_user/virtio_pci.h:260:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#821: FILE: drivers/virtio_vhost_user/virtio_pci.h:262:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#821: FILE: drivers/virtio_vhost_user/virtio_pci.h:262:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#821: FILE: drivers/virtio_vhost_user/virtio_pci.h:262:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#821: FILE: drivers/virtio_vhost_user/virtio_pci.h:262:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#823: FILE: drivers/virtio_vhost_user/virtio_pci.h:264:
+uint8_t virtio_pci_isr(struct virtio_hw *);

total: 0 errors, 22 warnings, 955 lines checked