[dpdk-test-report] |WARNING| pw55018 [PATCH v5 05/15] net/hinic/base: add eq mechanism function code

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jun 19 17:45:45 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55018

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#127: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:90:
+#define EQ_CONS_IDX(eq)		((eq)->cons_idx | \
+				((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#130: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:93:
+#define EQ_CONS_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#134: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:97:
+#define EQ_PROD_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#138: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:101:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#159: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:122:
+#define aeq_to_aeqs(eq) \
+		container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#679: FILE: drivers/net/hinic/base/hinic_pmd_eqs.h:27:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

total: 0 errors, 0 warnings, 8 checks, 710 lines checked


More information about the test-report mailing list