[dpdk-test-report] |WARNING| pw55069 [PATCH v5 14/15] net/hinic: add tx/rx package burst

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 20 11:53:12 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55069

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#283: FILE: drivers/net/hinic/hinic_pmd_rx.c:735:
+	volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
 	                 ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#717: FILE: drivers/net/hinic/hinic_pmd_tx.c:174:
+#define HINIC_GET_SQ_HW_CI(txq)	\
+	((be16_to_cpu(*(txq)->cons_idx_addr)) & HINIC_GET_SQ_WQE_MASK(txq))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#720: FILE: drivers/net/hinic/hinic_pmd_tx.c:177:
+#define HINIC_GET_SQ_LOCAL_CI(txq)	\
+	(((txq)->wq->cons_idx) & HINIC_GET_SQ_WQE_MASK(txq))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt)	\
+	do {						\
+		(txq)->wq->cons_idx += wqebb_cnt;	\
+		(txq)->wq->delta += wqebb_cnt;		\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_cnt' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt)	\
+	do {						\
+		(txq)->wq->cons_idx += wqebb_cnt;	\
+		(txq)->wq->delta += wqebb_cnt;		\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#731: FILE: drivers/net/hinic/hinic_pmd_tx.c:188:
+#define HINIC_IS_SQ_EMPTY(txq)	(((txq)->wq->delta) == ((txq)->q_depth))

total: 0 errors, 0 warnings, 6 checks, 1596 lines checked


More information about the test-report mailing list