[dpdk-test-report] |WARNING| pw55447 [PATCH v6 09/15] net/hinic/base: add context and work queue support

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 27 10:05:47 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55447

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sqs' - possible side-effects?
#973: FILE: drivers/net/hinic/base/hinic_pmd_nicio.h:32:
+#define RQ_CTXT_OFFSET(max_sqs, max_rqs, q_id)	\
+	(((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE +	\
+		(max_sqs) * Q_CTXT_SIZE + (q_id) * Q_CTXT_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1407: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:10:
+#define WQ_SIZE(wq)		(u32)((u64)(wq)->q_depth * (wq)->wqebb_size)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1409: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:12:
+#define	WQE_PAGE_NUM(wq, idx)	(((idx) >> ((wq)->wqebbs_per_page_shift)) & \
+				((wq)->num_q_pages - 1))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1412: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:15:
+#define	WQE_PAGE_OFF(wq, idx)	((u64)((wq)->wqebb_size) * \
+				((idx) & ((wq)->num_wqebbs_per_page - 1)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1417: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:20:
+#define WQ_PAGE_ADDR(wq, idx)		\
+		(u8 *)(*(u64 *)((u64)((wq)->shadow_block_vaddr) + \
+		(WQE_PAGE_NUM(wq, idx) << WQ_PAGE_ADDR_SIZE_SHIFT)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1433: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:36:
+#define WQ_BASE_VADDR(wqs, wq)		\
+		(u64 *)(((u64)((wqs)->page_vaddr[(wq)->page_idx])) \
+				+ (wq)->block_idx * WQ_BLOCK_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1437: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:40:
+#define WQ_BASE_PADDR(wqs, wq)	(((wqs)->page_paddr[(wq)->page_idx]) \
+				+ (u64)(wq)->block_idx * WQ_BLOCK_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1440: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:43:
+#define WQ_BASE_ADDR(wqs, wq)		\
+		(u64 *)(((u64)((wqs)->shadow_page_vaddr[(wq)->page_idx])) \
+				+ (wq)->block_idx * WQ_BLOCK_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1458: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:61:
+#define WQE_SHADOW_PAGE(wq, wqe)	\
+		(u16)(((unsigned long)(wqe) - (unsigned long)(wq)->shadow_wqe) \
+		/ (wq)->max_wqe_size)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqe' - possible side-effects?
#1462: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:65:
+#define WQE_IN_RANGE(wqe, start, end)	\
+		(((unsigned long)(wqe) >= (unsigned long)(start)) && \
+		((unsigned long)(wqe) < (unsigned long)(end)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1469: FILE: drivers/net/hinic/base/hinic_pmd_wq.h:72:
+#define	WQ_WQE_ADDR(wq, idx) ((void *)((u64)((wq)->queue_buf_vaddr) + \
+			      ((idx) << (wq)->wqebb_shift)))

total: 0 errors, 0 warnings, 11 checks, 1475 lines checked


More information about the test-report mailing list