[dpdk-test-report] |WARNING| pw53568 [PATCH 10/11] net/hinic: add TX module

checkpatch at dpdk.org checkpatch at dpdk.org
Tue May 21 10:14:23 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53568

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw_ci == sw_ci'
#469: FILE: drivers/net/hinic/hinic_pmd_tx.c:424:
+		if ((hw_ci == sw_ci) ||
+			(((hw_ci - sw_ci) & sq_mask) < tx_info->wqebb_cnt))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pool != mbuf_free[0]->pool'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+			if (unlikely((m->pool != mbuf_free[0]->pool) ||
+				(nb_free >= HINIC_MAX_TX_FREE_BULK))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_free >= HINIC_MAX_TX_FREE_BULK'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+			if (unlikely((m->pool != mbuf_free[0]->pool) ||
+				(nb_free >= HINIC_MAX_TX_FREE_BULK))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->tso_segsz == 0'
#579: FILE: drivers/net/hinic/hinic_pmd_tx.c:534:
+		if ((m->tso_segsz == 0) ||
+			((ol_flags & PKT_TX_IPV4) &&
+			!(ol_flags & PKT_TX_IP_CKSUM)))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#617: FILE: drivers/net/hinic/hinic_pmd_tx.c:572:
+			rte_cpu_to_be_16(

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#715: FILE: drivers/net/hinic/hinic_pmd_tx.c:670:
+		if (eth_type == ETHER_TYPE_IPv4) {

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#725: FILE: drivers/net/hinic/hinic_pmd_tx.c:680:
+		} else if (eth_type == ETHER_TYPE_IPv6) {

total: 0 errors, 0 warnings, 7 checks, 1044 lines checked


More information about the test-report mailing list