[dpdk-test-report] |WARNING| pw60693 [PATCH v3 5/5] app: add test-sad application
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Oct 8 11:42:11 CEST 2019
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60693
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#111: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end_fld; \
+ errno = 0; \
+ val = strtoul((in), &end_fld, (base)); \
+ if (errno != 0 || end_fld[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end_fld + 1; \
+} while (0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#319: FILE: app/test-sad/main.c:232:
+ unsigned i, j, rnd;
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#628: FILE: app/test-sad/main.c:541:
+ printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",
total: 0 errors, 3 warnings, 702 lines checked
More information about the test-report
mailing list