[dpdk-test-report] |WARNING| pw62023 [RFC v2 3/7] net/atlantic: Add helper functions for PHY access

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Oct 25 19:54:43 CEST 2019
Previous message: [dpdk-test-report] |SUCCESS| pw62022 [RFC v2 2/7] security: Update rte_security documentation
Next message: [dpdk-test-report] |WARNING| pw62024 [RFC v2 4/7] net/atlantic: add MACSEC internal HW data declaration and functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/62023

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
Some network features, like MACSec, are configured directly in the PHY part.

CHECK:CAMELCASE: Avoid CamelCase: <macValRead>
#78: FILE: drivers/net/atlantic/macsec/mdio.c:13:
+static inline uint32_t macValRead(uint32_t reg, uint32_t msk, uint32_t shift)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#80: FILE: drivers/net/atlantic/macsec/mdio.c:15:
+    return (reg & msk) >> shift;$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#83: FILE: drivers/net/atlantic/macsec/mdio.c:18:
+static inline void macValWrite(uint32_t* reg, uint32_t msk, uint32_t shift, uint32_t val)

CHECK:CAMELCASE: Avoid CamelCase: <macValWrite>
#83: FILE: drivers/net/atlantic/macsec/mdio.c:18:
+static inline void macValWrite(uint32_t* reg, uint32_t msk, uint32_t shift, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: drivers/net/atlantic/macsec/mdio.c:20:
+    *reg = (*reg & ~msk) | (val << shift);$

CHECK:CAMELCASE: Avoid CamelCase: <macBitRead>
#88: FILE: drivers/net/atlantic/macsec/mdio.c:23:
+static inline uint32_t macBitRead(uint32_t reg, uint32_t msk)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: drivers/net/atlantic/macsec/mdio.c:25:
+    return reg & msk;$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface1Get>
#93: FILE: drivers/net/atlantic/macsec/mdio.c:28:
+static inline uint32_t regGlobalMdioInterface1Get(void *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: drivers/net/atlantic/macsec/mdio.c:30:
+    return aq_hw_read_reg(hw, 0x280);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface1MdioClockEnableSet>
#98: FILE: drivers/net/atlantic/macsec/mdio.c:33:
+static inline void valGlobalMdioInterface1MdioClockEnableSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/atlantic/macsec/mdio.c:35:
+    macValWrite(reg, 0x00004000, 14, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface1Set>
#103: FILE: drivers/net/atlantic/macsec/mdio.c:38:
+static inline void regGlobalMdioInterface1Set(void *hw, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/net/atlantic/macsec/mdio.c:40:
+    aq_hw_write_reg(hw, 0x280, val);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface4MdioAddressSet>
#108: FILE: drivers/net/atlantic/macsec/mdio.c:43:
+static inline void valGlobalMdioInterface4MdioAddressSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: drivers/net/atlantic/macsec/mdio.c:45:
+    macValWrite(reg, 0x0000FFFF, 0, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface4Set>
#113: FILE: drivers/net/atlantic/macsec/mdio.c:48:
+static inline void regGlobalMdioInterface4Set(void *hw, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/net/atlantic/macsec/mdio.c:50:
+    aq_hw_write_reg(hw, 0x28C, val);$

WARNING:LONG_LINE: line over 90 characters
#118: FILE: drivers/net/atlantic/macsec/mdio.c:53:
+static inline void valGlobalMdioInterface2MdioExecuteOperationSet(uint32_t *reg, uint32_t val)

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface2MdioExecuteOperationSet>
#118: FILE: drivers/net/atlantic/macsec/mdio.c:53:
+static inline void valGlobalMdioInterface2MdioExecuteOperationSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#120: FILE: drivers/net/atlantic/macsec/mdio.c:55:
+    macValWrite(reg, 0x00008000, 15, val);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface2MdioOpModeSet>
#123: FILE: drivers/net/atlantic/macsec/mdio.c:58:
+static inline void valGlobalMdioInterface2MdioOpModeSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: drivers/net/atlantic/macsec/mdio.c:60:
+    macValWrite(reg, 0x00003000, 12, val);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface2MdioPhyAddressSet>
#128: FILE: drivers/net/atlantic/macsec/mdio.c:63:
+static inline void valGlobalMdioInterface2MdioPhyAddressSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: drivers/net/atlantic/macsec/mdio.c:65:
+    macValWrite(reg, 0x000003FF, 0, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface2Set>
#133: FILE: drivers/net/atlantic/macsec/mdio.c:68:
+static inline void regGlobalMdioInterface2Set(void *hw, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: drivers/net/atlantic/macsec/mdio.c:70:
+    aq_hw_write_reg(hw, 0x284, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface2Get>
#138: FILE: drivers/net/atlantic/macsec/mdio.c:73:
+static inline uint32_t regGlobalMdioInterface2Get(void *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: drivers/net/atlantic/macsec/mdio.c:75:
+    return aq_hw_read_reg(hw, 0x284);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface3MdioWriteDataSet>
#143: FILE: drivers/net/atlantic/macsec/mdio.c:78:
+static inline void valGlobalMdioInterface3MdioWriteDataSet(uint32_t *reg, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: drivers/net/atlantic/macsec/mdio.c:80:
+    macValWrite(reg, 0x0000FFFF, 0, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface3Set>
#148: FILE: drivers/net/atlantic/macsec/mdio.c:83:
+static inline void regGlobalMdioInterface3Set(void *hw, uint32_t val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: drivers/net/atlantic/macsec/mdio.c:85:
+    aq_hw_write_reg(hw, 0x288, val);$

CHECK:CAMELCASE: Avoid CamelCase: <regGlobalMdioInterface5Get>
#153: FILE: drivers/net/atlantic/macsec/mdio.c:88:
+static inline uint32_t regGlobalMdioInterface5Get(void *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: drivers/net/atlantic/macsec/mdio.c:90:
+    return aq_hw_read_reg(hw, 0x290);$

CHECK:CAMELCASE: Avoid CamelCase: <valGlobalMdioInterface5MdioReadDataGet>
#158: FILE: drivers/net/atlantic/macsec/mdio.c:93:
+static inline uint32_t valGlobalMdioInterface5MdioReadDataGet(uint32_t reg)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/net/atlantic/macsec/mdio.c:95:
+    return macValRead(reg, 0x0000FFFF, 0);$

CHECK:CAMELCASE: Avoid CamelCase: <bitGlobalMdioInterface2MdioBusyGet>
#163: FILE: drivers/net/atlantic/macsec/mdio.c:98:
+static inline uint32_t bitGlobalMdioInterface2MdioBusyGet(uint32_t reg)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: drivers/net/atlantic/macsec/mdio.c:100:
+    return macBitRead(reg, 0x80000000);$

WARNING:LONG_LINE: line over 90 characters
#182: FILE: drivers/net/atlantic/macsec/mdio.c:117:
+#define TIMEOUT_BUSY_WAIT_COUNT     ((MIPS_COUNT_HZ * MDIO_ONE_CMD_CLOCK_TICKS / MDIO_HZ) * 10)

CHECK:CAMELCASE: Avoid CamelCase: <mMdioBusyCheck>
#187: FILE: drivers/net/atlantic/macsec/mdio.c:122:
+static inline unsigned int mMdioBusyCheck(void *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: drivers/net/atlantic/macsec/mdio.c:124:
+    return bitGlobalMdioInterface2MdioBusyGet(regGlobalMdioInterface2Get(hw));$

CHECK:CAMELCASE: Avoid CamelCase: <mBusyWait>
#192: FILE: drivers/net/atlantic/macsec/mdio.c:127:
+static int mBusyWait(struct aq_hw_s *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: drivers/net/atlantic/macsec/mdio.c:129:
+    unsigned i = 0;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#194: FILE: drivers/net/atlantic/macsec/mdio.c:129:
+    unsigned i = 0;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: drivers/net/atlantic/macsec/mdio.c:131:
+    for (i = 1000U; mMdioBusyCheck(hw) && i; i--){};$

ERROR:SPACING: space required before the open brace '{'
#196: FILE: drivers/net/atlantic/macsec/mdio.c:131:
+    for (i = 1000U; mMdioBusyCheck(hw) && i; i--){};

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#196: FILE: drivers/net/atlantic/macsec/mdio.c:131:
+    for (i = 1000U; mMdioBusyCheck(hw) && i; i--){};

WARNING:BRACES: braces {} are not necessary for single statement blocks
#196: FILE: drivers/net/atlantic/macsec/mdio.c:131:
+    for (i = 1000U; mMdioBusyCheck(hw) && i; i--){};

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: drivers/net/atlantic/macsec/mdio.c:133:
+    if (i == 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: drivers/net/atlantic/macsec/mdio.c:136:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: drivers/net/atlantic/macsec/mdio.c:138:
+    return 0;$

WARNING:LONG_LINE: line over 90 characters
#207: FILE: drivers/net/atlantic/macsec/mdio.c:142:
+static inline void mSendPhyAddress(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr)

CHECK:CAMELCASE: Avoid CamelCase: <mSendPhyAddress>
#207: FILE: drivers/net/atlantic/macsec/mdio.c:142:
+static inline void mSendPhyAddress(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#209: FILE: drivers/net/atlantic/macsec/mdio.c:144:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#212: FILE: drivers/net/atlantic/macsec/mdio.c:147:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: drivers/net/atlantic/macsec/mdio.c:148:
+    valGlobalMdioInterface4MdioAddressSet(&reg, addr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: drivers/net/atlantic/macsec/mdio.c:149:
+    regGlobalMdioInterface4Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: drivers/net/atlantic/macsec/mdio.c:152:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: drivers/net/atlantic/macsec/mdio.c:153:
+    valGlobalMdioInterface2MdioExecuteOperationSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#219: FILE: drivers/net/atlantic/macsec/mdio.c:154:
+    valGlobalMdioInterface2MdioOpModeSet(&reg, MDIO_OP_ADDR);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: drivers/net/atlantic/macsec/mdio.c:155:
+    valGlobalMdioInterface2MdioPhyAddressSet(&reg, mdio_phy_addr | mmd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: drivers/net/atlantic/macsec/mdio.c:156:
+    regGlobalMdioInterface2Set(hw, reg);$

CHECK:CAMELCASE: Avoid CamelCase: <mSendDummyWriteCmd>
#224: FILE: drivers/net/atlantic/macsec/mdio.c:159:
+static void mSendDummyWriteCmd(struct aq_hw_s *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/net/atlantic/macsec/mdio.c:161:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: drivers/net/atlantic/macsec/mdio.c:164:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: drivers/net/atlantic/macsec/mdio.c:165:
+    valGlobalMdioInterface3MdioWriteDataSet(&reg, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: drivers/net/atlantic/macsec/mdio.c:166:
+    regGlobalMdioInterface3Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: drivers/net/atlantic/macsec/mdio.c:169:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: drivers/net/atlantic/macsec/mdio.c:170:
+    valGlobalMdioInterface2MdioExecuteOperationSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: drivers/net/atlantic/macsec/mdio.c:171:
+    valGlobalMdioInterface2MdioOpModeSet(&reg, MDIO_OP_WRITE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#237: FILE: drivers/net/atlantic/macsec/mdio.c:172:
+    valGlobalMdioInterface2MdioPhyAddressSet(&reg, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: drivers/net/atlantic/macsec/mdio.c:173:
+    regGlobalMdioInterface2Set(hw, reg);$

CHECK:CAMELCASE: Avoid CamelCase: <mSendReadCmd>
#241: FILE: drivers/net/atlantic/macsec/mdio.c:176:
+static inline void mSendReadCmd(struct aq_hw_s *hw, unsigned int mmd)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: drivers/net/atlantic/macsec/mdio.c:178:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: drivers/net/atlantic/macsec/mdio.c:181:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: drivers/net/atlantic/macsec/mdio.c:182:
+    valGlobalMdioInterface2MdioExecuteOperationSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: drivers/net/atlantic/macsec/mdio.c:183:
+    valGlobalMdioInterface2MdioOpModeSet(&reg, MDIO_OP_READ);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: drivers/net/atlantic/macsec/mdio.c:184:
+    valGlobalMdioInterface2MdioPhyAddressSet(&reg, mdio_phy_addr | mmd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: drivers/net/atlantic/macsec/mdio.c:185:
+    regGlobalMdioInterface2Set(hw, reg);$

CHECK:CAMELCASE: Avoid CamelCase: <mSendWriteCmd>
#253: FILE: drivers/net/atlantic/macsec/mdio.c:188:
+static inline void mSendWriteCmd(struct aq_hw_s *hw, unsigned int mmd)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#255: FILE: drivers/net/atlantic/macsec/mdio.c:190:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#258: FILE: drivers/net/atlantic/macsec/mdio.c:193:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: drivers/net/atlantic/macsec/mdio.c:194:
+    valGlobalMdioInterface2MdioExecuteOperationSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: drivers/net/atlantic/macsec/mdio.c:195:
+    valGlobalMdioInterface2MdioOpModeSet(&reg, MDIO_OP_WRITE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: drivers/net/atlantic/macsec/mdio.c:196:
+    valGlobalMdioInterface2MdioPhyAddressSet(&reg, mdio_phy_addr | mmd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: drivers/net/atlantic/macsec/mdio.c:197:
+    regGlobalMdioInterface2Set(hw, reg);$

CHECK:CAMELCASE: Avoid CamelCase: <mReadData>
#265: FILE: drivers/net/atlantic/macsec/mdio.c:200:
+static inline unsigned short int mReadData(struct aq_hw_s *hw)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: drivers/net/atlantic/macsec/mdio.c:203:
+    return valGlobalMdioInterface5MdioReadDataGet(regGlobalMdioInterface5Get(hw));$

CHECK:CAMELCASE: Avoid CamelCase: <mWriteData>
#271: FILE: drivers/net/atlantic/macsec/mdio.c:206:
+static inline void mWriteData(struct aq_hw_s *hw, unsigned short int val)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: drivers/net/atlantic/macsec/mdio.c:208:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#276: FILE: drivers/net/atlantic/macsec/mdio.c:211:
+    reg = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#277: FILE: drivers/net/atlantic/macsec/mdio.c:212:
+    valGlobalMdioInterface3MdioWriteDataSet(&reg, val);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#278: FILE: drivers/net/atlantic/macsec/mdio.c:213:
+    regGlobalMdioInterface3Set(hw, reg);$

WARNING:LONG_LINE: line over 90 characters
#282: FILE: drivers/net/atlantic/macsec/mdio.c:217:
+static int __mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#282: FILE: drivers/net/atlantic/macsec/mdio.c:217:
+static int __mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

CHECK:CAMELCASE: Avoid CamelCase: <__mdioRead>
#282: FILE: drivers/net/atlantic/macsec/mdio.c:217:
+static int __mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: drivers/net/atlantic/macsec/mdio.c:219:
+    int ret = -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: drivers/net/atlantic/macsec/mdio.c:222:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: drivers/net/atlantic/macsec/mdio.c:223:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: drivers/net/atlantic/macsec/mdio.c:223:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: drivers/net/atlantic/macsec/mdio.c:224:
+    mSendPhyAddress(hw, mmd, addr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: drivers/net/atlantic/macsec/mdio.c:227:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#293: FILE: drivers/net/atlantic/macsec/mdio.c:228:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#293: FILE: drivers/net/atlantic/macsec/mdio.c:228:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#294: FILE: drivers/net/atlantic/macsec/mdio.c:229:
+    mSendDummyWriteCmd(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#297: FILE: drivers/net/atlantic/macsec/mdio.c:232:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#298: FILE: drivers/net/atlantic/macsec/mdio.c:233:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: drivers/net/atlantic/macsec/mdio.c:233:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#299: FILE: drivers/net/atlantic/macsec/mdio.c:234:
+    mSendReadCmd(hw, mmd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: drivers/net/atlantic/macsec/mdio.c:237:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#303: FILE: drivers/net/atlantic/macsec/mdio.c:238:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: drivers/net/atlantic/macsec/mdio.c:238:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: drivers/net/atlantic/macsec/mdio.c:239:
+    *data = mReadData(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: drivers/net/atlantic/macsec/mdio.c:241:
+    ret = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: drivers/net/atlantic/macsec/mdio.c:244:
+    return ret;$

WARNING:LONG_LINE: line over 90 characters
#313: FILE: drivers/net/atlantic/macsec/mdio.c:248:
+int __mdioWrite(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int data)

CHECK:CAMELCASE: Avoid CamelCase: <__mdioWrite>
#313: FILE: drivers/net/atlantic/macsec/mdio.c:248:
+int __mdioWrite(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int data)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#315: FILE: drivers/net/atlantic/macsec/mdio.c:250:
+    int ret = -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: drivers/net/atlantic/macsec/mdio.c:253:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#319: FILE: drivers/net/atlantic/macsec/mdio.c:254:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#319: FILE: drivers/net/atlantic/macsec/mdio.c:254:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: drivers/net/atlantic/macsec/mdio.c:255:
+    mSendPhyAddress(hw, mmd, addr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#323: FILE: drivers/net/atlantic/macsec/mdio.c:258:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#324: FILE: drivers/net/atlantic/macsec/mdio.c:259:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#324: FILE: drivers/net/atlantic/macsec/mdio.c:259:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: drivers/net/atlantic/macsec/mdio.c:260:
+    mSendDummyWriteCmd(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: drivers/net/atlantic/macsec/mdio.c:263:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: drivers/net/atlantic/macsec/mdio.c:264:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: drivers/net/atlantic/macsec/mdio.c:264:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: drivers/net/atlantic/macsec/mdio.c:265:
+    mWriteData(hw, data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: drivers/net/atlantic/macsec/mdio.c:266:
+    mSendWriteCmd(hw, mmd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: drivers/net/atlantic/macsec/mdio.c:269:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#335: FILE: drivers/net/atlantic/macsec/mdio.c:270:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#335: FILE: drivers/net/atlantic/macsec/mdio.c:270:
+        goto _exit;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: drivers/net/atlantic/macsec/mdio.c:272:
+    ret = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: drivers/net/atlantic/macsec/mdio.c:275:
+    return ret;$

WARNING:LONG_LINE: line over 90 characters
#343: FILE: drivers/net/atlantic/macsec/mdio.c:278:
+int mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#343: FILE: drivers/net/atlantic/macsec/mdio.c:278:
+int mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

CHECK:CAMELCASE: Avoid CamelCase: <mdioRead>
#343: FILE: drivers/net/atlantic/macsec/mdio.c:278:
+int mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: drivers/net/atlantic/macsec/mdio.c:280:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: drivers/net/atlantic/macsec/mdio.c:281:
+    int ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#349: FILE: drivers/net/atlantic/macsec/mdio.c:284:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#350: FILE: drivers/net/atlantic/macsec/mdio.c:285:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#350: FILE: drivers/net/atlantic/macsec/mdio.c:285:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#351: FILE: drivers/net/atlantic/macsec/mdio.c:286:
+    mSendDummyWriteCmd(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: drivers/net/atlantic/macsec/mdio.c:289:
+    reg = regGlobalMdioInterface1Get(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#355: FILE: drivers/net/atlantic/macsec/mdio.c:290:
+    valGlobalMdioInterface1MdioClockEnableSet(&reg, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#356: FILE: drivers/net/atlantic/macsec/mdio.c:291:
+    regGlobalMdioInterface1Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: drivers/net/atlantic/macsec/mdio.c:293:
+    ret = __mdioRead(hw, mmd, addr, data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: drivers/net/atlantic/macsec/mdio.c:296:
+    reg = regGlobalMdioInterface1Get(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#362: FILE: drivers/net/atlantic/macsec/mdio.c:297:
+    valGlobalMdioInterface1MdioClockEnableSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#363: FILE: drivers/net/atlantic/macsec/mdio.c:298:
+    regGlobalMdioInterface1Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: drivers/net/atlantic/macsec/mdio.c:300:
+    return ret;$

WARNING:LONG_LINE: line over 90 characters
#368: FILE: drivers/net/atlantic/macsec/mdio.c:303:
+int mdioWrite(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int data)

CHECK:CAMELCASE: Avoid CamelCase: <mdioWrite>
#368: FILE: drivers/net/atlantic/macsec/mdio.c:303:
+int mdioWrite(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int data)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#370: FILE: drivers/net/atlantic/macsec/mdio.c:305:
+    uint32_t reg;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#371: FILE: drivers/net/atlantic/macsec/mdio.c:306:
+    int ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#374: FILE: drivers/net/atlantic/macsec/mdio.c:309:
+    if (mBusyWait(hw))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#375: FILE: drivers/net/atlantic/macsec/mdio.c:310:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#375: FILE: drivers/net/atlantic/macsec/mdio.c:310:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#376: FILE: drivers/net/atlantic/macsec/mdio.c:311:
+    mSendDummyWriteCmd(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#379: FILE: drivers/net/atlantic/macsec/mdio.c:314:
+    reg = regGlobalMdioInterface1Get(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#380: FILE: drivers/net/atlantic/macsec/mdio.c:315:
+    valGlobalMdioInterface1MdioClockEnableSet(&reg, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#381: FILE: drivers/net/atlantic/macsec/mdio.c:316:
+    regGlobalMdioInterface1Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#383: FILE: drivers/net/atlantic/macsec/mdio.c:318:
+    ret = __mdioWrite(hw, mmd, addr, data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#386: FILE: drivers/net/atlantic/macsec/mdio.c:321:
+    reg = regGlobalMdioInterface1Get(hw);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#387: FILE: drivers/net/atlantic/macsec/mdio.c:322:
+    valGlobalMdioInterface1MdioClockEnableSet(&reg, 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#388: FILE: drivers/net/atlantic/macsec/mdio.c:323:
+    regGlobalMdioInterface1Set(hw, reg);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#390: FILE: drivers/net/atlantic/macsec/mdio.c:325:
+    return ret;$

WARNING:LONG_LINE: line over 90 characters
#415: FILE: drivers/net/atlantic/macsec/mdio.h:16:
+int mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#415: FILE: drivers/net/atlantic/macsec/mdio.h:16:
+int mdioRead(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int* data);

WARNING:LONG_LINE: line over 90 characters
#416: FILE: drivers/net/atlantic/macsec/mdio.h:17:
+int mdioWrite(struct aq_hw_s *hw, unsigned int mmd, unsigned int addr, unsigned short int data);

total: 16 errors, 127 warnings, 30 checks, 365 lines checked
Previous message: [dpdk-test-report] |SUCCESS| pw62022 [RFC v2 2/7] security: Update rte_security documentation
Next message: [dpdk-test-report] |WARNING| pw62024 [RFC v2 4/7] net/atlantic: add MACSEC internal HW data declaration and functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list