[dpdk-test-report] |WARNING| pw58737 [PATCH 2/5] net/bnx2x: update HSI code

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 6 09:26:54 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/58737

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: drivers/net/bnx2x/ecore_hsi.h:277:
+          out of bits) */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#238: FILE: drivers/net/bnx2x/ecore_hsi.h:277:
+	/*  This field extends the mf mode chosen in nvm cfg #73 (as we ran
+          out of bits) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#238: FILE: drivers/net/bnx2x/ecore_hsi.h:277:
+          out of bits) */

CHECK:CAMELCASE: Avoid CamelCase: <Reserved2>
#355: FILE: drivers/net/bnx2x/ecore_hsi.h:1163:
+	uint32_t Reserved2[16];                                  /* 0x48C */

WARNING:TYPO_SPELLING: 'Overide' may be misspelled - perhaps 'Override'?
#412: FILE: drivers/net/bnx2x/ecore_hsi.h:1359:
+	/*  Overide PCIE revision ID when enabled the,

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#413: FILE: drivers/net/bnx2x/ecore_hsi.h:1360:
+	/*  Overide PCIE revision ID when enabled the,
+	    revision ID will set to B1=='0x11' */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#413: FILE: drivers/net/bnx2x/ecore_hsi.h:1360:
+	    revision ID will set to B1=='0x11' */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#634: FILE: drivers/net/bnx2x/ecore_hsi.h:2519:
+/*
+Used to suppoert NSCI get OS driver version

WARNING:SPACING: missing space after struct definition
#638: FILE: drivers/net/bnx2x/ecore_hsi.h:2523:
+struct os_drv_ver{

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#817: FILE: drivers/net/bnx2x/ecore_hsi.h:2777:
+		#define SHMEM_EEE_1G_ADV	   (1<<1)
 		                        	     ^

ERROR:CODE_INDENT: code indent should use tabs where possible
#860: FILE: drivers/net/bnx2x/ecore_hsi.h:2815:
+        /* driver version for each personality*/$

ERROR:CODE_INDENT: code indent should use tabs where possible
#861: FILE: drivers/net/bnx2x/ecore_hsi.h:2816:
+        struct os_drv_ver func_os_drv_ver[E2_FUNC_MAX]; /* Offset 0x16c */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#861: FILE: drivers/net/bnx2x/ecore_hsi.h:2816:
+        struct os_drv_ver func_os_drv_ver[E2_FUNC_MAX]; /* Offset 0x16c */$

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_pf_' may be better as '(_pf_)' to avoid precedence issues
#867: FILE: drivers/net/bnx2x/ecore_hsi.h:2822:
+	#define MFW_DRV_IND_READ_DONE_OFFSET(_pf_)  (1 << _pf_)

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1025: FILE: drivers/net/bnx2x/ecore_hsi.h:3633:
+#define DMAE_COMMAND_SRC (0x1<<0)
                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1028: FILE: drivers/net/bnx2x/ecore_hsi.h:3635:
+#define DMAE_COMMAND_DST (0x3<<1)
                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1031: FILE: drivers/net/bnx2x/ecore_hsi.h:3637:
+#define DMAE_COMMAND_C_DST (0x1<<3)
                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1034: FILE: drivers/net/bnx2x/ecore_hsi.h:3639:
+#define DMAE_COMMAND_C_TYPE_ENABLE (0x1<<4)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1037: FILE: drivers/net/bnx2x/ecore_hsi.h:3641:
+#define DMAE_COMMAND_C_TYPE_CRC_ENABLE (0x1<<5)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1040: FILE: drivers/net/bnx2x/ecore_hsi.h:3643:
+#define DMAE_COMMAND_C_TYPE_CRC_OFFSET (0x7<<6)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1043: FILE: drivers/net/bnx2x/ecore_hsi.h:3645:
+#define DMAE_COMMAND_ENDIANITY (0x3<<9)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1046: FILE: drivers/net/bnx2x/ecore_hsi.h:3647:
+#define DMAE_COMMAND_PORT (0x1<<11)
                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1049: FILE: drivers/net/bnx2x/ecore_hsi.h:3649:
+#define DMAE_COMMAND_CRC_RESET (0x1<<12)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1052: FILE: drivers/net/bnx2x/ecore_hsi.h:3651:
+#define DMAE_COMMAND_SRC_RESET (0x1<<13)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1055: FILE: drivers/net/bnx2x/ecore_hsi.h:3653:
+#define DMAE_COMMAND_DST_RESET (0x1<<14)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1058: FILE: drivers/net/bnx2x/ecore_hsi.h:3655:
+#define DMAE_COMMAND_E1HVN (0x3<<15)
                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1061: FILE: drivers/net/bnx2x/ecore_hsi.h:3657:
+#define DMAE_COMMAND_DST_VN (0x3<<17)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1064: FILE: drivers/net/bnx2x/ecore_hsi.h:3659:
+#define DMAE_COMMAND_C_FUNC (0x1<<19)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1067: FILE: drivers/net/bnx2x/ecore_hsi.h:3661:
+#define DMAE_COMMAND_ERR_POLICY (0x3<<20)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1070: FILE: drivers/net/bnx2x/ecore_hsi.h:3663:
+#define DMAE_COMMAND_RESERVED0 (0x3FF<<22)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1083: FILE: drivers/net/bnx2x/ecore_hsi.h:3671:
+#define DMAE_COMMAND_SRC_VFID (0x3F<<0)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1086: FILE: drivers/net/bnx2x/ecore_hsi.h:3673:
+#define DMAE_COMMAND_SRC_VFPF (0x1<<6)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1089: FILE: drivers/net/bnx2x/ecore_hsi.h:3675:
+#define DMAE_COMMAND_RESERVED1 (0x1<<7)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1092: FILE: drivers/net/bnx2x/ecore_hsi.h:3677:
+#define DMAE_COMMAND_DST_VFID (0x3F<<8)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1095: FILE: drivers/net/bnx2x/ecore_hsi.h:3679:
+#define DMAE_COMMAND_DST_VFPF (0x1<<14)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1098: FILE: drivers/net/bnx2x/ecore_hsi.h:3681:
+#define DMAE_COMMAND_RESERVED2 (0x1<<15)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1107: FILE: drivers/net/bnx2x/ecore_hsi.h:3687:
+#define DMAE_COMMAND_SRC_VFID (0x3F<<0)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1110: FILE: drivers/net/bnx2x/ecore_hsi.h:3689:
+#define DMAE_COMMAND_SRC_VFPF (0x1<<6)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1113: FILE: drivers/net/bnx2x/ecore_hsi.h:3691:
+#define DMAE_COMMAND_RESERVED1 (0x1<<7)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1116: FILE: drivers/net/bnx2x/ecore_hsi.h:3693:
+#define DMAE_COMMAND_DST_VFID (0x3F<<8)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1119: FILE: drivers/net/bnx2x/ecore_hsi.h:3695:
+#define DMAE_COMMAND_DST_VFPF (0x1<<14)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1122: FILE: drivers/net/bnx2x/ecore_hsi.h:3697:
+#define DMAE_COMMAND_RESERVED2 (0x1<<15)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1177: FILE: drivers/net/bnx2x/ecore_hsi.h:3734:
+#define DOORBELL_HDR_RX (0x1<<0)
                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1180: FILE: drivers/net/bnx2x/ecore_hsi.h:3736:
+#define DOORBELL_HDR_DB_TYPE (0x1<<1)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1183: FILE: drivers/net/bnx2x/ecore_hsi.h:3738:
+#define DOORBELL_HDR_DPM_SIZE (0x3<<2)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1186: FILE: drivers/net/bnx2x/ecore_hsi.h:3740:
+#define DOORBELL_HDR_CONN_TYPE (0xF<<4)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1201: FILE: drivers/net/bnx2x/ecore_hsi.h:3751:
+#define ETH_TX_DOORBELL_NUM_BDS (0x3F<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1204: FILE: drivers/net/bnx2x/ecore_hsi.h:3753:
+#define ETH_TX_DOORBELL_RESERVED_TX_FIN_FLAG (0x1<<6)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1207: FILE: drivers/net/bnx2x/ecore_hsi.h:3755:
+#define ETH_TX_DOORBELL_SPARE (0x1<<7)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1214: FILE: drivers/net/bnx2x/ecore_hsi.h:3761:
+#define ETH_TX_DOORBELL_NUM_BDS (0x3F<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1217: FILE: drivers/net/bnx2x/ecore_hsi.h:3763:
+#define ETH_TX_DOORBELL_RESERVED_TX_FIN_FLAG (0x1<<6)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1220: FILE: drivers/net/bnx2x/ecore_hsi.h:3765:
+#define ETH_TX_DOORBELL_SPARE (0x1<<7)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1320: FILE: drivers/net/bnx2x/ecore_hsi.h:3831:
+#define IGU_ACK_REGISTER_STATUS_BLOCK_ID (0x1F<<0)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1323: FILE: drivers/net/bnx2x/ecore_hsi.h:3833:
+#define IGU_ACK_REGISTER_STORM_ID (0x7<<5)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1326: FILE: drivers/net/bnx2x/ecore_hsi.h:3835:
+#define IGU_ACK_REGISTER_UPDATE_INDEX (0x1<<8)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1329: FILE: drivers/net/bnx2x/ecore_hsi.h:3837:
+#define IGU_ACK_REGISTER_INTERRUPT_MODE (0x3<<9)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1332: FILE: drivers/net/bnx2x/ecore_hsi.h:3839:
+#define IGU_ACK_REGISTER_RESERVED (0x1F<<11)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1342: FILE: drivers/net/bnx2x/ecore_hsi.h:3845:
+#define IGU_ACK_REGISTER_STATUS_BLOCK_ID (0x1F<<0)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1345: FILE: drivers/net/bnx2x/ecore_hsi.h:3847:
+#define IGU_ACK_REGISTER_STORM_ID (0x7<<5)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1348: FILE: drivers/net/bnx2x/ecore_hsi.h:3849:
+#define IGU_ACK_REGISTER_UPDATE_INDEX (0x1<<8)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1351: FILE: drivers/net/bnx2x/ecore_hsi.h:3851:
+#define IGU_ACK_REGISTER_INTERRUPT_MODE (0x3<<9)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1354: FILE: drivers/net/bnx2x/ecore_hsi.h:3853:
+#define IGU_ACK_REGISTER_RESERVED (0x1F<<11)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1370: FILE: drivers/net/bnx2x/ecore_hsi.h:3864:
+#define IGU_BACKWARD_COMPATIBLE_SB_INDEX (0xFFFF<<0)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1373: FILE: drivers/net/bnx2x/ecore_hsi.h:3866:
+#define IGU_BACKWARD_COMPATIBLE_SB_SELECT (0x1F<<16)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1376: FILE: drivers/net/bnx2x/ecore_hsi.h:3868:
+#define IGU_BACKWARD_COMPATIBLE_SEGMENT_ACCESS (0x7<<21)
                                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1379: FILE: drivers/net/bnx2x/ecore_hsi.h:3870:
+#define IGU_BACKWARD_COMPATIBLE_BUPDATE (0x1<<24)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1382: FILE: drivers/net/bnx2x/ecore_hsi.h:3872:
+#define IGU_BACKWARD_COMPATIBLE_ENABLE_INT (0x3<<25)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1385: FILE: drivers/net/bnx2x/ecore_hsi.h:3874:
+#define IGU_BACKWARD_COMPATIBLE_RESERVED_0 (0x1F<<27)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1398: FILE: drivers/net/bnx2x/ecore_hsi.h:3885:
+#define IGU_REGULAR_SB_INDEX (0xFFFFF<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1401: FILE: drivers/net/bnx2x/ecore_hsi.h:3887:
+#define IGU_REGULAR_RESERVED0 (0x1<<20)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1404: FILE: drivers/net/bnx2x/ecore_hsi.h:3889:
+#define IGU_REGULAR_SEGMENT_ACCESS (0x7<<21)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1407: FILE: drivers/net/bnx2x/ecore_hsi.h:3891:
+#define IGU_REGULAR_BUPDATE (0x1<<24)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1410: FILE: drivers/net/bnx2x/ecore_hsi.h:3893:
+#define IGU_REGULAR_ENABLE_INT (0x3<<25)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1413: FILE: drivers/net/bnx2x/ecore_hsi.h:3895:
+#define IGU_REGULAR_RESERVED_1 (0x1<<27)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1416: FILE: drivers/net/bnx2x/ecore_hsi.h:3897:
+#define IGU_REGULAR_CLEANUP_TYPE (0x3<<28)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1419: FILE: drivers/net/bnx2x/ecore_hsi.h:3899:
+#define IGU_REGULAR_CLEANUP_SET (0x1<<30)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1422: FILE: drivers/net/bnx2x/ecore_hsi.h:3901:
+#define IGU_REGULAR_BCLEANUP (0x1<<31)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1455: FILE: drivers/net/bnx2x/ecore_hsi.h:3929:
+#define IGU_CTRL_REG_ADDRESS (0xFFF<<0)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1458: FILE: drivers/net/bnx2x/ecore_hsi.h:3931:
+#define IGU_CTRL_REG_FID (0x7F<<12)
                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1461: FILE: drivers/net/bnx2x/ecore_hsi.h:3933:
+#define IGU_CTRL_REG_RESERVED (0x1<<19)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1464: FILE: drivers/net/bnx2x/ecore_hsi.h:3935:
+#define IGU_CTRL_REG_TYPE (0x1<<20)
                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1467: FILE: drivers/net/bnx2x/ecore_hsi.h:3937:
+#define IGU_CTRL_REG_UNUSED (0x7FF<<21)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1501: FILE: drivers/net/bnx2x/ecore_hsi.h:3968:
+#define PARSING_FLAGS_ETHERNET_ADDRESS_TYPE (0x1<<0)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1504: FILE: drivers/net/bnx2x/ecore_hsi.h:3970:
+#define PARSING_FLAGS_VLAN (0x1<<1)
                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1507: FILE: drivers/net/bnx2x/ecore_hsi.h:3972:
+#define PARSING_FLAGS_EXTRA_VLAN (0x1<<2)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1510: FILE: drivers/net/bnx2x/ecore_hsi.h:3974:
+#define PARSING_FLAGS_OVER_ETHERNET_PROTOCOL (0x3<<3)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1513: FILE: drivers/net/bnx2x/ecore_hsi.h:3976:
+#define PARSING_FLAGS_IP_OPTIONS (0x1<<5)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1516: FILE: drivers/net/bnx2x/ecore_hsi.h:3978:
+#define PARSING_FLAGS_FRAGMENTATION_STATUS (0x1<<6)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1519: FILE: drivers/net/bnx2x/ecore_hsi.h:3980:
+#define PARSING_FLAGS_OVER_IP_PROTOCOL (0x3<<7)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1522: FILE: drivers/net/bnx2x/ecore_hsi.h:3982:
+#define PARSING_FLAGS_PURE_ACK_INDICATION (0x1<<9)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1525: FILE: drivers/net/bnx2x/ecore_hsi.h:3984:
+#define PARSING_FLAGS_TCP_OPTIONS_EXIST (0x1<<10)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1528: FILE: drivers/net/bnx2x/ecore_hsi.h:3986:
+#define PARSING_FLAGS_TIME_STAMP_EXIST_FLAG (0x1<<11)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1531: FILE: drivers/net/bnx2x/ecore_hsi.h:3988:
+#define PARSING_FLAGS_CONNECTION_MATCH (0x1<<12)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1534: FILE: drivers/net/bnx2x/ecore_hsi.h:3990:
+#define PARSING_FLAGS_LLC_SNAP (0x1<<13)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1537: FILE: drivers/net/bnx2x/ecore_hsi.h:3992:
+#define PARSING_FLAGS_RESERVED0 (0x3<<14)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1591: FILE: drivers/net/bnx2x/ecore_hsi.h:4041:
+#define SDM_OP_GEN_COMP_PARAM (0x1F<<0)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1594: FILE: drivers/net/bnx2x/ecore_hsi.h:4043:
+#define SDM_OP_GEN_COMP_TYPE (0x7<<5)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1597: FILE: drivers/net/bnx2x/ecore_hsi.h:4045:
+#define SDM_OP_GEN_AGG_VECT_IDX (0xFF<<8)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1600: FILE: drivers/net/bnx2x/ecore_hsi.h:4047:
+#define SDM_OP_GEN_AGG_VECT_IDX_VALID (0x1<<16)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1603: FILE: drivers/net/bnx2x/ecore_hsi.h:4049:
+#define SDM_OP_GEN_RESERVED (0x7FFF<<17)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1622: FILE: drivers/net/bnx2x/ecore_hsi.h:4062:
+#define __TIMERS_BLOCK_CONTEXT_NUM_OF_ACTIVE_TIMERS (0x3<<0)
                                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1625: FILE: drivers/net/bnx2x/ecore_hsi.h:4064:
+#define TIMERS_BLOCK_CONTEXT_CONN_VALID_FLG (0x1<<2)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1628: FILE: drivers/net/bnx2x/ecore_hsi.h:4066:
+#define __TIMERS_BLOCK_CONTEXT_RESERVED0 (0x1FFFFFFF<<3)
                                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1819: FILE: drivers/net/bnx2x/ecore_hsi.h:4204:
+#define CLIENT_INIT_RX_DATA_TPA_EN_IPV4 (0x1<<0)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1822: FILE: drivers/net/bnx2x/ecore_hsi.h:4206:
+#define CLIENT_INIT_RX_DATA_TPA_EN_IPV6 (0x1<<1)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1825: FILE: drivers/net/bnx2x/ecore_hsi.h:4208:
+#define CLIENT_INIT_RX_DATA_TPA_MODE (0x1<<2)
                                          ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1853: FILE: drivers/net/bnx2x/ecore_hsi.h:4210:
+#define CLIENT_INIT_RX_DATA_TPA_OVER_VLAN_DISABLE (0x1<<3)
                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1855: FILE: drivers/net/bnx2x/ecore_hsi.h:4212:
+#define CLIENT_INIT_RX_DATA_RESERVED5 (0xF<<4)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1888: FILE: drivers/net/bnx2x/ecore_hsi.h:4242:
+#define CLIENT_INIT_RX_DATA_UCAST_DROP_ALL (0x1<<0)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1891: FILE: drivers/net/bnx2x/ecore_hsi.h:4244:
+#define CLIENT_INIT_RX_DATA_UCAST_ACCEPT_ALL (0x1<<1)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1894: FILE: drivers/net/bnx2x/ecore_hsi.h:4246:
+#define CLIENT_INIT_RX_DATA_UCAST_ACCEPT_UNMATCHED (0x1<<2)
                                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1897: FILE: drivers/net/bnx2x/ecore_hsi.h:4248:
+#define CLIENT_INIT_RX_DATA_MCAST_DROP_ALL (0x1<<3)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1900: FILE: drivers/net/bnx2x/ecore_hsi.h:4250:
+#define CLIENT_INIT_RX_DATA_MCAST_ACCEPT_ALL (0x1<<4)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1903: FILE: drivers/net/bnx2x/ecore_hsi.h:4252:
+#define CLIENT_INIT_RX_DATA_BCAST_ACCEPT_ALL (0x1<<5)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1906: FILE: drivers/net/bnx2x/ecore_hsi.h:4254:
+#define CLIENT_INIT_RX_DATA_ACCEPT_ANY_VLAN (0x1<<6)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1909: FILE: drivers/net/bnx2x/ecore_hsi.h:4256:
+#define CLIENT_INIT_RX_DATA_RESERVED2 (0x1FF<<7)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1965: FILE: drivers/net/bnx2x/ecore_hsi.h:4285:
+#define CLIENT_INIT_TX_DATA_UCAST_ACCEPT_ALL (0x1<<0)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1968: FILE: drivers/net/bnx2x/ecore_hsi.h:4287:
+#define CLIENT_INIT_TX_DATA_MCAST_ACCEPT_ALL (0x1<<1)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1971: FILE: drivers/net/bnx2x/ecore_hsi.h:4289:
+#define CLIENT_INIT_TX_DATA_BCAST_ACCEPT_ALL (0x1<<2)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1974: FILE: drivers/net/bnx2x/ecore_hsi.h:4291:
+#define CLIENT_INIT_TX_DATA_ACCEPT_ANY_VLAN (0x1<<3)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1977: FILE: drivers/net/bnx2x/ecore_hsi.h:4293:
+#define CLIENT_INIT_TX_DATA_RESERVED0 (0xFFF<<4)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2121: FILE: drivers/net/bnx2x/ecore_hsi.h:4385:
+#define ETH_CLASSIFY_CMD_HEADER_RX_CMD (0x1<<0)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2124: FILE: drivers/net/bnx2x/ecore_hsi.h:4387:
+#define ETH_CLASSIFY_CMD_HEADER_TX_CMD (0x1<<1)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2127: FILE: drivers/net/bnx2x/ecore_hsi.h:4389:
+#define ETH_CLASSIFY_CMD_HEADER_OPCODE (0x3<<2)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2130: FILE: drivers/net/bnx2x/ecore_hsi.h:4391:
+#define ETH_CLASSIFY_CMD_HEADER_IS_ADD (0x1<<4)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2133: FILE: drivers/net/bnx2x/ecore_hsi.h:4393:
+#define ETH_CLASSIFY_CMD_HEADER_RESERVED0 (0x7<<5)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2351: FILE: drivers/net/bnx2x/ecore_hsi.h:4542:
+#define ETH_END_AGG_RX_CQE_TYPE (0x3<<0)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2354: FILE: drivers/net/bnx2x/ecore_hsi.h:4544:
+#define ETH_END_AGG_RX_CQE_SGL_RAW_SEL (0x1<<2)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2357: FILE: drivers/net/bnx2x/ecore_hsi.h:4546:
+#define ETH_END_AGG_RX_CQE_RESERVED0 (0x1F<<3)
                                           ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#2384: FILE: drivers/net/bnx2x/ecore_hsi.h:4565:
+	ETH_OK=0x00,
 	      ^

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#2385: FILE: drivers/net/bnx2x/ecore_hsi.h:4566:
+	ETH_RAMROD_DATA_READ_ERROR=0x01,
 	                          ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2411: FILE: drivers/net/bnx2x/ecore_hsi.h:4588:
+#define ETH_FAST_PATH_RX_CQE_TYPE (0x3<<0)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2414: FILE: drivers/net/bnx2x/ecore_hsi.h:4590:
+#define ETH_FAST_PATH_RX_CQE_SGL_RAW_SEL (0x1<<2)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2417: FILE: drivers/net/bnx2x/ecore_hsi.h:4592:
+#define ETH_FAST_PATH_RX_CQE_PHY_DECODE_ERR_FLG (0x1<<3)
                                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2420: FILE: drivers/net/bnx2x/ecore_hsi.h:4594:
+#define ETH_FAST_PATH_RX_CQE_IP_BAD_XSUM_FLG (0x1<<4)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2423: FILE: drivers/net/bnx2x/ecore_hsi.h:4596:
+#define ETH_FAST_PATH_RX_CQE_L4_BAD_XSUM_FLG (0x1<<5)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2427: FILE: drivers/net/bnx2x/ecore_hsi.h:4598:
+#define ETH_FAST_PATH_RX_CQE_PTP_PKT (0x1<<6)
                                          ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2429: FILE: drivers/net/bnx2x/ecore_hsi.h:4600:
+#define ETH_FAST_PATH_RX_CQE_RESERVED0 (0x1<<7)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2433: FILE: drivers/net/bnx2x/ecore_hsi.h:4603:
+#define ETH_FAST_PATH_RX_CQE_RSS_HASH_TYPE (0x7<<0)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2436: FILE: drivers/net/bnx2x/ecore_hsi.h:4605:
+#define ETH_FAST_PATH_RX_CQE_RSS_HASH_FLG (0x1<<3)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2439: FILE: drivers/net/bnx2x/ecore_hsi.h:4607:
+#define ETH_FAST_PATH_RX_CQE_BROADCAST_FLG (0x1<<4)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2442: FILE: drivers/net/bnx2x/ecore_hsi.h:4609:
+#define ETH_FAST_PATH_RX_CQE_MAC_MATCH_FLG (0x1<<5)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2445: FILE: drivers/net/bnx2x/ecore_hsi.h:4611:
+#define ETH_FAST_PATH_RX_CQE_IP_XSUM_NO_VALIDATION_FLG (0x1<<6)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2448: FILE: drivers/net/bnx2x/ecore_hsi.h:4613:
+#define ETH_FAST_PATH_RX_CQE_L4_XSUM_NO_VALIDATION_FLG (0x1<<7)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2484: FILE: drivers/net/bnx2x/ecore_hsi.h:4637:
+#define ETH_FILTER_RULES_CMD_RX_CMD (0x1<<0)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2487: FILE: drivers/net/bnx2x/ecore_hsi.h:4639:
+#define ETH_FILTER_RULES_CMD_TX_CMD (0x1<<1)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2490: FILE: drivers/net/bnx2x/ecore_hsi.h:4641:
+#define ETH_FILTER_RULES_CMD_RESERVED0 (0x3F<<2)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2500: FILE: drivers/net/bnx2x/ecore_hsi.h:4647:
+#define ETH_FILTER_RULES_CMD_UCAST_DROP_ALL (0x1<<0)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2503: FILE: drivers/net/bnx2x/ecore_hsi.h:4649:
+#define ETH_FILTER_RULES_CMD_UCAST_ACCEPT_ALL (0x1<<1)
                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2506: FILE: drivers/net/bnx2x/ecore_hsi.h:4651:
+#define ETH_FILTER_RULES_CMD_UCAST_ACCEPT_UNMATCHED (0x1<<2)
                                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2509: FILE: drivers/net/bnx2x/ecore_hsi.h:4653:
+#define ETH_FILTER_RULES_CMD_MCAST_DROP_ALL (0x1<<3)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2512: FILE: drivers/net/bnx2x/ecore_hsi.h:4655:
+#define ETH_FILTER_RULES_CMD_MCAST_ACCEPT_ALL (0x1<<4)
                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2515: FILE: drivers/net/bnx2x/ecore_hsi.h:4657:
+#define ETH_FILTER_RULES_CMD_BCAST_ACCEPT_ALL (0x1<<5)
                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2518: FILE: drivers/net/bnx2x/ecore_hsi.h:4659:
+#define ETH_FILTER_RULES_CMD_ACCEPT_ANY_VLAN (0x1<<6)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2521: FILE: drivers/net/bnx2x/ecore_hsi.h:4661:
+#define ETH_FILTER_RULES_CMD_RESERVED2 (0x1FF<<7)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2648: FILE: drivers/net/bnx2x/ecore_hsi.h:4744:
+#define ETH_TUNNEL_DATA_IPV6_OUTER (0x1<<0)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2650: FILE: drivers/net/bnx2x/ecore_hsi.h:4746:
+#define ETH_TUNNEL_DATA_RESERVED (0x7F<<1)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2687: FILE: drivers/net/bnx2x/ecore_hsi.h:4764:
+#define ETH_MULTICAST_RULES_CMD_RX_CMD (0x1<<0)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2690: FILE: drivers/net/bnx2x/ecore_hsi.h:4766:
+#define ETH_MULTICAST_RULES_CMD_TX_CMD (0x1<<1)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2693: FILE: drivers/net/bnx2x/ecore_hsi.h:4768:
+#define ETH_MULTICAST_RULES_CMD_IS_ADD (0x1<<2)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2696: FILE: drivers/net/bnx2x/ecore_hsi.h:4770:
+#define ETH_MULTICAST_RULES_CMD_RESERVED0 (0x1F<<3)
                                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2785: FILE: drivers/net/bnx2x/ecore_hsi.h:4840:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV4_CAPABILITY (0x1<<0)
                                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2788: FILE: drivers/net/bnx2x/ecore_hsi.h:4842:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV4_TCP_CAPABILITY (0x1<<1)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2791: FILE: drivers/net/bnx2x/ecore_hsi.h:4844:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV4_UDP_CAPABILITY (0x1<<2)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2811: FILE: drivers/net/bnx2x/ecore_hsi.h:4846:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV4_VXLAN_CAPABILITY (0x1<<3)
                                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2813: FILE: drivers/net/bnx2x/ecore_hsi.h:4848:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV6_CAPABILITY (0x1<<4)
                                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2815: FILE: drivers/net/bnx2x/ecore_hsi.h:4850:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV6_TCP_CAPABILITY (0x1<<5)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2817: FILE: drivers/net/bnx2x/ecore_hsi.h:4852:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV6_UDP_CAPABILITY (0x1<<6)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2819: FILE: drivers/net/bnx2x/ecore_hsi.h:4854:
+#define ETH_RSS_UPDATE_RAMROD_DATA_IPV6_VXLAN_CAPABILITY (0x1<<7)
                                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2821: FILE: drivers/net/bnx2x/ecore_hsi.h:4856:
+#define ETH_RSS_UPDATE_RAMROD_DATA_TUNN_INNER_HDRS_CAPABILITY (0x1<<8)
                                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2823: FILE: drivers/net/bnx2x/ecore_hsi.h:4858:
+#define ETH_RSS_UPDATE_RAMROD_DATA_UPDATE_RSS_KEY (0x1<<9)
                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2825: FILE: drivers/net/bnx2x/ecore_hsi.h:4860:
+#define ETH_RSS_UPDATE_RAMROD_DATA_RESERVED (0x3F<<10)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2859: FILE: drivers/net/bnx2x/ecore_hsi.h:4886:
+#define COMMON_RAMROD_ETH_RX_CQE_TYPE (0x3<<0)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2862: FILE: drivers/net/bnx2x/ecore_hsi.h:4888:
+#define COMMON_RAMROD_ETH_RX_CQE_ERROR (0x1<<2)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2865: FILE: drivers/net/bnx2x/ecore_hsi.h:4890:
+#define COMMON_RAMROD_ETH_RX_CQE_RESERVED0 (0x1F<<3)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2874: FILE: drivers/net/bnx2x/ecore_hsi.h:4895:
+#define COMMON_RAMROD_ETH_RX_CQE_CID (0xFFFFFF<<0)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2877: FILE: drivers/net/bnx2x/ecore_hsi.h:4897:
+#define COMMON_RAMROD_ETH_RX_CQE_CMD_ID (0xFF<<24)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2964: FILE: drivers/net/bnx2x/ecore_hsi.h:4958:
+#define SPE_HDR_CID (0xFFFFFF<<0)
                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2967: FILE: drivers/net/bnx2x/ecore_hsi.h:4960:
+#define SPE_HDR_CMD_ID (0xFF<<24)
                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2972: FILE: drivers/net/bnx2x/ecore_hsi.h:4963:
+#define SPE_HDR_CONN_TYPE (0xFF<<0)
                                ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2975: FILE: drivers/net/bnx2x/ecore_hsi.h:4965:
+#define SPE_HDR_FUNCTION_ID (0xFF<<8)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3140: FILE: drivers/net/bnx2x/ecore_hsi.h:5075:
+#define ETH_TX_BD_FLAGS_IP_CSUM (0x1<<0)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3143: FILE: drivers/net/bnx2x/ecore_hsi.h:5077:
+#define ETH_TX_BD_FLAGS_L4_CSUM (0x1<<1)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3146: FILE: drivers/net/bnx2x/ecore_hsi.h:5079:
+#define ETH_TX_BD_FLAGS_VLAN_MODE (0x3<<2)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3149: FILE: drivers/net/bnx2x/ecore_hsi.h:5081:
+#define ETH_TX_BD_FLAGS_START_BD (0x1<<4)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3152: FILE: drivers/net/bnx2x/ecore_hsi.h:5083:
+#define ETH_TX_BD_FLAGS_IS_UDP (0x1<<5)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3155: FILE: drivers/net/bnx2x/ecore_hsi.h:5085:
+#define ETH_TX_BD_FLAGS_SW_LSO (0x1<<6)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3158: FILE: drivers/net/bnx2x/ecore_hsi.h:5087:
+#define ETH_TX_BD_FLAGS_IPV6 (0x1<<7)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3181: FILE: drivers/net/bnx2x/ecore_hsi.h:5102:
+#define ETH_TX_START_BD_HDR_NBDS (0x7<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3184: FILE: drivers/net/bnx2x/ecore_hsi.h:5104:
+#define ETH_TX_START_BD_NO_ADDED_TAGS (0x1<<3)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3186: FILE: drivers/net/bnx2x/ecore_hsi.h:5106:
+#define ETH_TX_START_BD_FORCE_VLAN_MODE (0x1<<4)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3189: FILE: drivers/net/bnx2x/ecore_hsi.h:5108:
+#define ETH_TX_START_BD_PARSE_NBDS (0x3<<5)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3192: FILE: drivers/net/bnx2x/ecore_hsi.h:5110:
+#define ETH_TX_START_BD_TUNNEL_EXIST (0x1<<7)
                                          ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3206: FILE: drivers/net/bnx2x/ecore_hsi.h:5119:
+#define ETH_TX_PARSE_BD_E1X_IP_HDR_START_OFFSET_W (0xF<<0)
                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3209: FILE: drivers/net/bnx2x/ecore_hsi.h:5121:
+#define ETH_TX_PARSE_BD_E1X_ETH_ADDR_TYPE (0x3<<4)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3212: FILE: drivers/net/bnx2x/ecore_hsi.h:5123:
+#define ETH_TX_PARSE_BD_E1X_PSEUDO_CS_WITHOUT_LEN (0x1<<6)
                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3215: FILE: drivers/net/bnx2x/ecore_hsi.h:5125:
+#define ETH_TX_PARSE_BD_E1X_LLC_SNAP_EN (0x1<<7)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3218: FILE: drivers/net/bnx2x/ecore_hsi.h:5127:
+#define ETH_TX_PARSE_BD_E1X_NS_FLG (0x1<<8)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3221: FILE: drivers/net/bnx2x/ecore_hsi.h:5129:
+#define ETH_TX_PARSE_BD_E1X_RESERVED0 (0x7F<<9)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3225: FILE: drivers/net/bnx2x/ecore_hsi.h:5132:
+#define ETH_TX_PARSE_BD_E1X_FIN_FLG (0x1<<0)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3228: FILE: drivers/net/bnx2x/ecore_hsi.h:5134:
+#define ETH_TX_PARSE_BD_E1X_SYN_FLG (0x1<<1)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3231: FILE: drivers/net/bnx2x/ecore_hsi.h:5136:
+#define ETH_TX_PARSE_BD_E1X_RST_FLG (0x1<<2)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3234: FILE: drivers/net/bnx2x/ecore_hsi.h:5138:
+#define ETH_TX_PARSE_BD_E1X_PSH_FLG (0x1<<3)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3237: FILE: drivers/net/bnx2x/ecore_hsi.h:5140:
+#define ETH_TX_PARSE_BD_E1X_ACK_FLG (0x1<<4)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3240: FILE: drivers/net/bnx2x/ecore_hsi.h:5142:
+#define ETH_TX_PARSE_BD_E1X_URG_FLG (0x1<<5)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3243: FILE: drivers/net/bnx2x/ecore_hsi.h:5144:
+#define ETH_TX_PARSE_BD_E1X_ECE_FLG (0x1<<6)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3246: FILE: drivers/net/bnx2x/ecore_hsi.h:5146:
+#define ETH_TX_PARSE_BD_E1X_CWR_FLG (0x1<<7)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3274: FILE: drivers/net/bnx2x/ecore_hsi.h:5162:
+#define ETH_TX_PARSE_BD_E2_L4_HDR_START_OFFSET_W (0x7FF<<0)
                                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3277: FILE: drivers/net/bnx2x/ecore_hsi.h:5164:
+#define ETH_TX_PARSE_BD_E2_TCP_HDR_LENGTH_DW (0xF<<11)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3280: FILE: drivers/net/bnx2x/ecore_hsi.h:5166:
+#define ETH_TX_PARSE_BD_E2_IPV6_WITH_EXT_HDR (0x1<<15)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3283: FILE: drivers/net/bnx2x/ecore_hsi.h:5168:
+#define ETH_TX_PARSE_BD_E2_LSO_MSS (0x3FFF<<16)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3286: FILE: drivers/net/bnx2x/ecore_hsi.h:5170:
+#define ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE (0x3<<30)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3300: FILE: drivers/net/bnx2x/ecore_hsi.h:5179:
+#define ETH_TX_PARSE_2ND_BD_IP_HDR_START_OUTER_W (0xF<<0)
                                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3303: FILE: drivers/net/bnx2x/ecore_hsi.h:5181:
+#define ETH_TX_PARSE_2ND_BD_RESERVED0 (0x1<<4)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3306: FILE: drivers/net/bnx2x/ecore_hsi.h:5183:
+#define ETH_TX_PARSE_2ND_BD_LLC_SNAP_EN (0x1<<5)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3309: FILE: drivers/net/bnx2x/ecore_hsi.h:5185:
+#define ETH_TX_PARSE_2ND_BD_NS_FLG (0x1<<6)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3312: FILE: drivers/net/bnx2x/ecore_hsi.h:5187:
+#define ETH_TX_PARSE_2ND_BD_TUNNEL_UDP_EXIST (0x1<<7)
                                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3315: FILE: drivers/net/bnx2x/ecore_hsi.h:5189:
+#define ETH_TX_PARSE_2ND_BD_IP_HDR_LEN_OUTER_W (0x1F<<8)
                                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3318: FILE: drivers/net/bnx2x/ecore_hsi.h:5191:
+#define ETH_TX_PARSE_2ND_BD_RESERVED1 (0x7<<13)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3322: FILE: drivers/net/bnx2x/ecore_hsi.h:5194:
+#define ETH_TX_PARSE_2ND_BD_TYPE (0xF<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3324: FILE: drivers/net/bnx2x/ecore_hsi.h:5196:
+#define ETH_TX_PARSE_2ND_BD_RESERVED2 (0xF<<4)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3329: FILE: drivers/net/bnx2x/ecore_hsi.h:5200:
+#define ETH_TX_PARSE_2ND_BD_FIN_FLG (0x1<<0)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3332: FILE: drivers/net/bnx2x/ecore_hsi.h:5202:
+#define ETH_TX_PARSE_2ND_BD_SYN_FLG (0x1<<1)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3335: FILE: drivers/net/bnx2x/ecore_hsi.h:5204:
+#define ETH_TX_PARSE_2ND_BD_RST_FLG (0x1<<2)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3338: FILE: drivers/net/bnx2x/ecore_hsi.h:5206:
+#define ETH_TX_PARSE_2ND_BD_PSH_FLG (0x1<<3)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3341: FILE: drivers/net/bnx2x/ecore_hsi.h:5208:
+#define ETH_TX_PARSE_2ND_BD_ACK_FLG (0x1<<4)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3344: FILE: drivers/net/bnx2x/ecore_hsi.h:5210:
+#define ETH_TX_PARSE_2ND_BD_URG_FLG (0x1<<5)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3347: FILE: drivers/net/bnx2x/ecore_hsi.h:5212:
+#define ETH_TX_PARSE_2ND_BD_ECE_FLG (0x1<<6)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3350: FILE: drivers/net/bnx2x/ecore_hsi.h:5214:
+#define ETH_TX_PARSE_2ND_BD_CWR_FLG (0x1<<7)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3475: FILE: drivers/net/bnx2x/ecore_hsi.h:5294:
+#define MAC_CONFIGURATION_ENTRY_ACTION_TYPE (0x1<<0)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3478: FILE: drivers/net/bnx2x/ecore_hsi.h:5296:
+#define MAC_CONFIGURATION_ENTRY_RDMA_MAC (0x1<<1)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3481: FILE: drivers/net/bnx2x/ecore_hsi.h:5298:
+#define MAC_CONFIGURATION_ENTRY_VLAN_FILTERING_MODE (0x3<<2)
                                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3484: FILE: drivers/net/bnx2x/ecore_hsi.h:5300:
+#define MAC_CONFIGURATION_ENTRY_OVERRIDE_VLAN_REMOVAL (0x1<<4)
                                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3487: FILE: drivers/net/bnx2x/ecore_hsi.h:5302:
+#define MAC_CONFIGURATION_ENTRY_BROADCAST (0x1<<5)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3490: FILE: drivers/net/bnx2x/ecore_hsi.h:5304:
+#define MAC_CONFIGURATION_ENTRY_RESERVED1 (0x3<<6)
                                               ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3595: FILE: drivers/net/bnx2x/ecore_hsi.h:5373:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV4_CAPABILITY (0x1<<0)
                                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3598: FILE: drivers/net/bnx2x/ecore_hsi.h:5375:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV4_TCP_CAPABILITY (0x1<<1)
                                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3601: FILE: drivers/net/bnx2x/ecore_hsi.h:5377:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV6_CAPABILITY (0x1<<2)
                                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3604: FILE: drivers/net/bnx2x/ecore_hsi.h:5379:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_IPV6_TCP_CAPABILITY (0x1<<3)
                                                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3607: FILE: drivers/net/bnx2x/ecore_hsi.h:5381:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_RSS_MODE (0x7<<4)
                                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3610: FILE: drivers/net/bnx2x/ecore_hsi.h:5383:
+#define TSTORM_ETH_FUNCTION_COMMON_CONFIG_VLAN_FILTERING_ENABLE (0x1<<7)
                                                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3613: FILE: drivers/net/bnx2x/ecore_hsi.h:5385:
+#define __TSTORM_ETH_FUNCTION_COMMON_CONFIG_RESERVED0 (0xFF<<8)
                                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3802: FILE: drivers/net/bnx2x/ecore_hsi.h:5527:
+#define CMNG_FLAGS_PER_PORT_FAIRNESS_VN (0x1<<0)
                                             ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3805: FILE: drivers/net/bnx2x/ecore_hsi.h:5529:
+#define CMNG_FLAGS_PER_PORT_RATE_SHAPING_VN (0x1<<1)
                                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3808: FILE: drivers/net/bnx2x/ecore_hsi.h:5531:
+#define CMNG_FLAGS_PER_PORT_FAIRNESS_COS (0x1<<2)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3811: FILE: drivers/net/bnx2x/ecore_hsi.h:5533:
+#define CMNG_FLAGS_PER_PORT_FAIRNESS_COS_MODE (0x1<<3)
                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#3814: FILE: drivers/net/bnx2x/ecore_hsi.h:5535:
+#define __CMNG_FLAGS_PER_PORT_RESERVED0 (0xFFFFFFF<<4)
                                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4152: FILE: drivers/net/bnx2x/ecore_hsi.h:5772:
+#define E2_INTEG_DATA_TESTING_EN (0x1<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4155: FILE: drivers/net/bnx2x/ecore_hsi.h:5774:
+#define E2_INTEG_DATA_LB_TX (0x1<<1)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4158: FILE: drivers/net/bnx2x/ecore_hsi.h:5776:
+#define E2_INTEG_DATA_COS_TX (0x1<<2)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4161: FILE: drivers/net/bnx2x/ecore_hsi.h:5778:
+#define E2_INTEG_DATA_OPPORTUNISTICQM (0x1<<3)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4164: FILE: drivers/net/bnx2x/ecore_hsi.h:5780:
+#define E2_INTEG_DATA_DPMTESTRELEASEDQ (0x1<<4)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4167: FILE: drivers/net/bnx2x/ecore_hsi.h:5782:
+#define E2_INTEG_DATA_RESERVED (0x7<<5)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4184: FILE: drivers/net/bnx2x/ecore_hsi.h:5792:
+#define E2_INTEG_DATA_TESTING_EN (0x1<<0)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4187: FILE: drivers/net/bnx2x/ecore_hsi.h:5794:
+#define E2_INTEG_DATA_LB_TX (0x1<<1)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4190: FILE: drivers/net/bnx2x/ecore_hsi.h:5796:
+#define E2_INTEG_DATA_COS_TX (0x1<<2)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4193: FILE: drivers/net/bnx2x/ecore_hsi.h:5798:
+#define E2_INTEG_DATA_OPPORTUNISTICQM (0x1<<3)
                                           ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4196: FILE: drivers/net/bnx2x/ecore_hsi.h:5800:
+#define E2_INTEG_DATA_DPMTESTRELEASEDQ (0x1<<4)
                                            ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4199: FILE: drivers/net/bnx2x/ecore_hsi.h:5802:
+#define E2_INTEG_DATA_RESERVED (0x7<<5)
                                    ^

CHECK:CAMELCASE: Avoid CamelCase: <ramEn>
#4206: FILE: drivers/net/bnx2x/ecore_hsi.h:5808:
+	uint8_t ramEn;

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4645: FILE: drivers/net/bnx2x/ecore_hsi.h:6088:
+#define FW_VERSION_OPTIMIZED (0x1<<0)
                                  ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4648: FILE: drivers/net/bnx2x/ecore_hsi.h:6090:
+#define FW_VERSION_BIG_ENDIEN (0x1<<1)
                                   ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4651: FILE: drivers/net/bnx2x/ecore_hsi.h:6092:
+#define FW_VERSION_CHIP_VERSION (0x3<<2)
                                     ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4654: FILE: drivers/net/bnx2x/ecore_hsi.h:6094:
+#define __FW_VERSION_RESERVED (0xFFFFFFF<<4)
                                         ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4702: FILE: drivers/net/bnx2x/ecore_hsi.h:6113:
+#define HC_INDEX_DATA_SM_ID (0x1<<0)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4705: FILE: drivers/net/bnx2x/ecore_hsi.h:6115:
+#define HC_INDEX_DATA_HC_ENABLED (0x1<<1)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4708: FILE: drivers/net/bnx2x/ecore_hsi.h:6117:
+#define HC_INDEX_DATA_DYNAMIC_HC_ENABLED (0x1<<2)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4711: FILE: drivers/net/bnx2x/ecore_hsi.h:6119:
+#define HC_INDEX_DATA_RESERVE (0x1F<<3)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4720: FILE: drivers/net/bnx2x/ecore_hsi.h:6125:
+#define HC_INDEX_DATA_SM_ID (0x1<<0)
                                 ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4723: FILE: drivers/net/bnx2x/ecore_hsi.h:6127:
+#define HC_INDEX_DATA_HC_ENABLED (0x1<<1)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4726: FILE: drivers/net/bnx2x/ecore_hsi.h:6129:
+#define HC_INDEX_DATA_DYNAMIC_HC_ENABLED (0x1<<2)
                                              ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#4729: FILE: drivers/net/bnx2x/ecore_hsi.h:6131:
+#define HC_INDEX_DATA_RESERVE (0x1F<<3)
                                    ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#5134: FILE: drivers/net/bnx2x/ecore_hsi.h:6403:
+#define PRAM_FW_VERSION_OPTIMIZED (0x1<<0)
                                       ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#5137: FILE: drivers/net/bnx2x/ecore_hsi.h:6405:
+#define PRAM_FW_VERSION_STORM_ID (0x3<<1)
                                      ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#5140: FILE: drivers/net/bnx2x/ecore_hsi.h:6407:
+#define PRAM_FW_VERSION_BIG_ENDIEN (0x1<<3)
                                        ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#5143: FILE: drivers/net/bnx2x/ecore_hsi.h:6409:
+#define PRAM_FW_VERSION_CHIP_VERSION (0x3<<4)
                                          ^

CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#5146: FILE: drivers/net/bnx2x/ecore_hsi.h:6411:
+#define __PRAM_FW_VERSION_RESERVED0 (0x3<<6)
                                         ^

CHECK:CAMELCASE: Avoid CamelCase: <funcID>
#5262: FILE: drivers/net/bnx2x/ecore_hsi.h:6482:
+	__le16 funcID;

total: 5 errors, 8 warnings, 265 checks, 5427 lines checked


More information about the test-report mailing list