[dpdk-test-report] |WARNING| pw59618 [PATCH v2 2/2] net/enic: add flow implementation based on Flow Manager API

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Sep 23 16:43:25 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59618

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#298: FILE: drivers/net/enic/base/vnic_flowman.h:33:
+#define FKM_BITS		\
+	FBIT(FKM_QTAG)		\
+	FBIT(FKM_CMD)		\
+	FBIT(FKM_IPV4)		\
+	FBIT(FKM_IPV6)		\
+	FBIT(FKM_ROCE)		\
+	FBIT(FKM_UDP)		\
+	FBIT(FKM_TCP)		\
+	FBIT(FKM_TCPORUDP)	\
+	FBIT(FKM_IPFRAG)	\
+	FBIT(FKM_NVGRE)		\
+	FBIT(FKM_VXLAN)		\
+	FBIT(FKM_GENEVE)	\
+	FBIT(FKM_NSH)		\
+	FBIT(FKM_ROCEV2)	\
+	FBIT(FKM_VLAN_PRES)	\
+	FBIT(FKM_IPOK)		\
+	FBIT(FKM_L4OK)		\
+	FBIT(FKM_ROCEOK)	\
+	FBIT(FKM_FCSOK)		\
+	FBIT(FKM_EG_SPAN)	\
+	FBIT(FKM_IG_SPAN)	\
+	FBIT(FKM_EG_HAIRPINNED)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#331: FILE: drivers/net/enic/base/vnic_flowman.h:66:
+#define FKH_BITS	\
+	FBIT(FKH_ETHER)	\
+	FBIT(FKH_QTAG)	\
+	FBIT(FKH_L2RAW)	\
+	FBIT(FKH_IPV4)	\
+	FBIT(FKH_IPV6)	\
+	FBIT(FKH_L3RAW)	\
+	FBIT(FKH_UDP)	\
+	FBIT(FKH_TCP)	\
+	FBIT(FKH_ICMP)	\
+	FBIT(FKH_VXLAN)	\
+	FBIT(FKH_L4RAW)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/enic/base/vnic_flowman.h:90:
+#define FBIT(X) X = (1 << X##_BIT),

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1406: FILE: drivers/net/enic/enic_fm_flow.c:674:
+	ENICPMD_LOG(DEBUG, "allocated exact match table: handle=0x%" PRIx64,

total: 3 errors, 0 warnings, 1 checks, 3142 lines checked


More information about the test-report mailing list