[dpdk-test-report] |WARNING| pw60117 [PATCH 4/9] net/qede/base: rename HSI datatypes and funcs

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60117

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map' - possible side-effects?
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map' may be better as '(map)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pq_id' may be better as '(pq_id)' to avoid precedence issues
#2957: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:163:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, pq_id, vp_pq_id, \
+			   rl_valid, rl_id, voq, wrr) \
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_PQ_VALID, 1); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_VALID, rl_valid ? 1 : 0); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_RL_ID, rl_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VP_PQ_ID, vp_pq_id); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_VOQ, voq); \
+	SET_FIELD(map.reg, QM_RF_PQ_MAP_WRR_WEIGHT_GROUP, wrr); \
+	STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + pq_id, *((u32 *)&map));\
 	} while (0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2959: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:165:
+	do { \
+	OSAL_MEMSET(&map, 0, sizeof(map)); \

total: 0 errors, 1 warnings, 3 checks, 3176 lines checked