[dpdk-test-report] |WARNING| pw67959 [PATCH v3 06/11] net/iavf: add flow director enabled switch value

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Apr 8 08:32:37 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67959

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ad' - possible side-effects?
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ad' may be better as '(ad)' to avoid precedence issues
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'on' - possible side-effects?
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 48 lines checked


More information about the test-report mailing list