[dpdk-test-report] |WARNING| pw68330 [PATCH v2 07/34] net/bnxt: add initial tf core resource mgmt support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Apr 13 21:44:37 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68330

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hquery' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'squery' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dtype' - possible side-effects?
#390: FILE: drivers/net/bnxt/tf_core/tf_rm.c:72:
+#define TF_RESC_RSVD(dir, type, dtype) do {	\
+		if ((dir) == TF_DIR_RX)		\
+			(dtype) = type ## _RX;	\
+		else				\
+			(dtype) = type ## _TX;	\
+	} while (0)

total: 0 errors, 0 warnings, 7 checks, 2339 lines checked


More information about the test-report mailing list