[dpdk-test-report] |WARNING| pw75534 [PATCH 17/22] uio: Use request handler that guarantees execution in correct context
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Aug 14 01:25:57 CEST 2020
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75534
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: kernel/windows/netuio/netuio_dev.c:53:
+ WdfDeviceInitSetIoInCallerContextCallback(DeviceInit, netuio_evt_IO_in_caller_context);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: kernel/windows/netuio/netuio_queue.c:180:
+ IN WDFDEVICE Device,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: kernel/windows/netuio/netuio_queue.c:181:
+ IN WDFREQUEST Request$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: kernel/windows/netuio/netuio_queue.c:184:
+ WDF_REQUEST_PARAMETERS params = { 0 };$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: kernel/windows/netuio/netuio_queue.c:189:
+ PNETUIO_CONTEXT_DATA netuio_contextdata = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: kernel/windows/netuio/netuio_queue.c:191:
+ netuio_contextdata = netuio_get_context_data(Device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: kernel/windows/netuio/netuio_queue.c:193:
+ WDF_REQUEST_PARAMETERS_INIT(¶ms);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: kernel/windows/netuio/netuio_queue.c:194:
+ WdfRequestGetParameters(Request, ¶ms);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: kernel/windows/netuio/netuio_queue.c:196:
+ // We only need to be in the context of the process that initiated the request$
ERROR:C99_COMMENTS: do not use C99 // comments
#145: FILE: kernel/windows/netuio/netuio_queue.c:196:
+ // We only need to be in the context of the process that initiated the request
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: kernel/windows/netuio/netuio_queue.c:197:
+ //when we need to map memory to userspace. Otherwise, send the request back to framework.$
ERROR:C99_COMMENTS: do not use C99 // comments
#146: FILE: kernel/windows/netuio/netuio_queue.c:197:
+ //when we need to map memory to userspace. Otherwise, send the request back to framework.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: kernel/windows/netuio/netuio_queue.c:198:
+ if (!((params.Type == WdfRequestTypeDeviceControl) &&$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#147: FILE: kernel/windows/netuio/netuio_queue.c:198:
+ if (!((params.Type == WdfRequestTypeDeviceControl) &&
+ (params.Parameters.DeviceIoControl.IoControlCode == IOCTL_NETUIO_MAP_HW_INTO_USERMODE)))
+ {
ERROR:CODE_INDENT: code indent should use tabs where possible
#148: FILE: kernel/windows/netuio/netuio_queue.c:199:
+ (params.Parameters.DeviceIoControl.IoControlCode == IOCTL_NETUIO_MAP_HW_INTO_USERMODE)))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: kernel/windows/netuio/netuio_queue.c:199:
+ (params.Parameters.DeviceIoControl.IoControlCode == IOCTL_NETUIO_MAP_HW_INTO_USERMODE)))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#149: FILE: kernel/windows/netuio/netuio_queue.c:200:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#150: FILE: kernel/windows/netuio/netuio_queue.c:201:
+ status = WdfDeviceEnqueueRequest(Device, Request);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: kernel/windows/netuio/netuio_queue.c:201:
+ status = WdfDeviceEnqueueRequest(Device, Request);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ if (!NT_SUCCESS(status))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ if (!NT_SUCCESS(status))$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#159: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ if (!NT_SUCCESS(status))
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#159: FILE: kernel/windows/netuio/netuio_queue.c:203:
+ if (!NT_SUCCESS(status))
+ {
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: kernel/windows/netuio/netuio_queue.c:204:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: kernel/windows/netuio/netuio_queue.c:204:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: kernel/windows/netuio/netuio_queue.c:205:
+ WdfRequestCompleteWithInformation(Request, status, bytes_returned);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: kernel/windows/netuio/netuio_queue.c:205:
+ WdfRequestCompleteWithInformation(Request, status, bytes_returned);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: kernel/windows/netuio/netuio_queue.c:207:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: kernel/windows/netuio/netuio_queue.c:207:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: kernel/windows/netuio/netuio_queue.c:208:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: kernel/windows/netuio/netuio_queue.c:210:
+ // First retrieve the input buffer and see if it matches our device$
ERROR:C99_COMMENTS: do not use C99 // comments
#170: FILE: kernel/windows/netuio/netuio_queue.c:210:
+ // First retrieve the input buffer and see if it matches our device
WARNING:LONG_LINE: line over 100 characters
#171: FILE: kernel/windows/netuio/netuio_queue.c:211:
+ status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_private_info), &input_buf, &input_buf_size);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: kernel/windows/netuio/netuio_queue.c:211:
+ status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_private_info), &input_buf, &input_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: kernel/windows/netuio/netuio_queue.c:212:
+ if (!NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: kernel/windows/netuio/netuio_queue.c:213:
+ status = STATUS_INVALID_BUFFER_SIZE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: kernel/windows/netuio/netuio_queue.c:213:
+ status = STATUS_INVALID_BUFFER_SIZE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#174: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#175: FILE: kernel/windows/netuio/netuio_queue.c:215:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ struct dpdk_private_info* dpdk_pvt_info = (struct dpdk_private_info*)input_buf;$
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#183: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ struct dpdk_private_info* dpdk_pvt_info = (struct dpdk_private_info*)input_buf;
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#183: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ struct dpdk_private_info* dpdk_pvt_info = (struct dpdk_private_info*)input_buf;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ // Ensure that the B:D:F match - otherwise, fail the IOCTL$
ERROR:C99_COMMENTS: do not use C99 // comments
#184: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ // Ensure that the B:D:F match - otherwise, fail the IOCTL
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: kernel/windows/netuio/netuio_queue.c:219:
+ if ((netuio_contextdata->addr.bus_num != dpdk_pvt_info->dev_addr.bus_num) ||$
ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ (netuio_contextdata->addr.dev_num != dpdk_pvt_info->dev_addr.dev_num) ||$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ (netuio_contextdata->addr.dev_num != dpdk_pvt_info->dev_addr.dev_num) ||$
ERROR:CODE_INDENT: code indent should use tabs where possible
#187: FILE: kernel/windows/netuio/netuio_queue.c:221:
+ (netuio_contextdata->addr.func_num != dpdk_pvt_info->dev_addr.func_num)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: kernel/windows/netuio/netuio_queue.c:221:
+ (netuio_contextdata->addr.func_num != dpdk_pvt_info->dev_addr.func_num)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#188: FILE: kernel/windows/netuio/netuio_queue.c:222:
+ status = STATUS_NOT_SAME_DEVICE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: kernel/windows/netuio/netuio_queue.c:222:
+ status = STATUS_NOT_SAME_DEVICE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#189: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: kernel/windows/netuio/netuio_queue.c:224:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: kernel/windows/netuio/netuio_queue.c:226:
+ if (netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr != NULL) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: kernel/windows/netuio/netuio_queue.c:227:
+ status = STATUS_ALREADY_COMMITTED;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: kernel/windows/netuio/netuio_queue.c:227:
+ status = STATUS_ALREADY_COMMITTED;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#196: FILE: kernel/windows/netuio/netuio_queue.c:228:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: kernel/windows/netuio/netuio_queue.c:228:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: kernel/windows/netuio/netuio_queue.c:229:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: kernel/windows/netuio/netuio_queue.c:231:
+ // Return relevant data to the caller$
ERROR:C99_COMMENTS: do not use C99 // comments
#203: FILE: kernel/windows/netuio/netuio_queue.c:231:
+ // Return relevant data to the caller
WARNING:LONG_LINE: line over 100 characters
#204: FILE: kernel/windows/netuio/netuio_queue.c:232:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: kernel/windows/netuio/netuio_queue.c:232:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: kernel/windows/netuio/netuio_queue.c:233:
+ if (!NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: kernel/windows/netuio/netuio_queue.c:234:
+ status = STATUS_INVALID_BUFFER_SIZE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: kernel/windows/netuio/netuio_queue.c:234:
+ status = STATUS_INVALID_BUFFER_SIZE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: kernel/windows/netuio/netuio_queue.c:235:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: kernel/windows/netuio/netuio_queue.c:235:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: kernel/windows/netuio/netuio_queue.c:236:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: kernel/windows/netuio/netuio_queue.c:238:
+ // Zero out the physically contiguous block$
ERROR:C99_COMMENTS: do not use C99 // comments
#213: FILE: kernel/windows/netuio/netuio_queue.c:238:
+ // Zero out the physically contiguous block
WARNING:LONG_LINE: line over 100 characters
#214: FILE: kernel/windows/netuio/netuio_queue.c:239:
+ RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: kernel/windows/netuio/netuio_queue.c:239:
+ RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: kernel/windows/netuio/netuio_queue.c:241:
+ status = netuio_map_address_into_user_process(netuio_contextdata);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: kernel/windows/netuio/netuio_queue.c:242:
+ if (status != STATUS_SUCCESS) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#218: FILE: kernel/windows/netuio/netuio_queue.c:242:
+ if (status != STATUS_SUCCESS) {
+ goto end;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#219: FILE: kernel/windows/netuio/netuio_queue.c:243:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#219: FILE: kernel/windows/netuio/netuio_queue.c:243:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: kernel/windows/netuio/netuio_queue.c:244:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: kernel/windows/netuio/netuio_queue.c:246:
+ netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: kernel/windows/netuio/netuio_queue.c:247:
+ bytes_returned = output_buf_size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: kernel/windows/netuio/netuio_queue.c:250:
+ WdfRequestCompleteWithInformation(Request, status, bytes_returned);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: kernel/windows/netuio/netuio_queue.c:252:
+ return;$
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#284: FILE: kernel/windows/netuio/netuio_queue.c:256:
+/*
+Routine Description:
ERROR:CODE_INDENT: code indent should use tabs where possible
#292: FILE: kernel/windows/netuio/netuio_queue.c:264:
+ _In_ size_t OutputBufferLength, _In_ size_t InputBufferLength,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: kernel/windows/netuio/netuio_queue.c:264:
+ _In_ size_t OutputBufferLength, _In_ size_t InputBufferLength,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#293: FILE: kernel/windows/netuio/netuio_queue.c:265:
+ _In_ ULONG IoControlCode)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#293: FILE: kernel/windows/netuio/netuio_queue.c:265:
+ _In_ ULONG IoControlCode)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#295: FILE: kernel/windows/netuio/netuio_queue.c:267:
+ UNREFERENCED_PARAMETER(OutputBufferLength);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: kernel/windows/netuio/netuio_queue.c:268:
+ UNREFERENCED_PARAMETER(InputBufferLength);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: kernel/windows/netuio/netuio_queue.c:270:
+ NTSTATUS status = STATUS_SUCCESS;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#299: FILE: kernel/windows/netuio/netuio_queue.c:271:
+ PVOID input_buf = NULL, output_buf = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: kernel/windows/netuio/netuio_queue.c:272:
+ size_t input_buf_size, output_buf_size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: kernel/windows/netuio/netuio_queue.c:273:
+ size_t bytes_returned = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: kernel/windows/netuio/netuio_queue.c:275:
+ WDFDEVICE device = WdfIoQueueGetDevice(Queue);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: kernel/windows/netuio/netuio_queue.c:277:
+ PNETUIO_CONTEXT_DATA netuio_contextdata;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#307: FILE: kernel/windows/netuio/netuio_queue.c:278:
+ netuio_contextdata = netuio_get_context_data(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: kernel/windows/netuio/netuio_queue.c:280:
+ if (IoControlCode != IOCTL_NETUIO_PCI_CONFIG_IO)$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#309: FILE: kernel/windows/netuio/netuio_queue.c:280:
+ if (IoControlCode != IOCTL_NETUIO_PCI_CONFIG_IO)
+ {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: kernel/windows/netuio/netuio_queue.c:281:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#311: FILE: kernel/windows/netuio/netuio_queue.c:282:
+ status = STATUS_INVALID_DEVICE_REQUEST;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#311: FILE: kernel/windows/netuio/netuio_queue.c:282:
+ status = STATUS_INVALID_DEVICE_REQUEST;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: kernel/windows/netuio/netuio_queue.c:283:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: kernel/windows/netuio/netuio_queue.c:283:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#313: FILE: kernel/windows/netuio/netuio_queue.c:284:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#315: FILE: kernel/windows/netuio/netuio_queue.c:286:
+ // First retrieve the input buffer and see if it matches our device$
ERROR:C99_COMMENTS: do not use C99 // comments
#315: FILE: kernel/windows/netuio/netuio_queue.c:286:
+ // First retrieve the input buffer and see if it matches our device
WARNING:LONG_LINE: line over 100 characters
#316: FILE: kernel/windows/netuio/netuio_queue.c:287:
+ status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#316: FILE: kernel/windows/netuio/netuio_queue.c:287:
+ status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: kernel/windows/netuio/netuio_queue.c:288:
+ if (!NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#318: FILE: kernel/windows/netuio/netuio_queue.c:289:
+ status = STATUS_INVALID_BUFFER_SIZE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: kernel/windows/netuio/netuio_queue.c:289:
+ status = STATUS_INVALID_BUFFER_SIZE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#319: FILE: kernel/windows/netuio/netuio_queue.c:290:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#319: FILE: kernel/windows/netuio/netuio_queue.c:290:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: kernel/windows/netuio/netuio_queue.c:291:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#322: FILE: kernel/windows/netuio/netuio_queue.c:293:
+ struct dpdk_pci_config_io *dpdk_pci_io_input = (struct dpdk_pci_config_io *)input_buf;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#324: FILE: kernel/windows/netuio/netuio_queue.c:295:
+ if (dpdk_pci_io_input->access_size != 1 &&$
ERROR:CODE_INDENT: code indent should use tabs where possible
#325: FILE: kernel/windows/netuio/netuio_queue.c:296:
+ dpdk_pci_io_input->access_size != 2 &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: kernel/windows/netuio/netuio_queue.c:296:
+ dpdk_pci_io_input->access_size != 2 &&$
ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: kernel/windows/netuio/netuio_queue.c:297:
+ dpdk_pci_io_input->access_size != 4 &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: kernel/windows/netuio/netuio_queue.c:297:
+ dpdk_pci_io_input->access_size != 4 &&$
ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: kernel/windows/netuio/netuio_queue.c:298:
+ dpdk_pci_io_input->access_size != 8) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: kernel/windows/netuio/netuio_queue.c:298:
+ dpdk_pci_io_input->access_size != 8) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: kernel/windows/netuio/netuio_queue.c:299:
+ status = STATUS_INVALID_PARAMETER;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: kernel/windows/netuio/netuio_queue.c:299:
+ status = STATUS_INVALID_PARAMETER;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: kernel/windows/netuio/netuio_queue.c:300:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: kernel/windows/netuio/netuio_queue.c:300:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: kernel/windows/netuio/netuio_queue.c:301:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: kernel/windows/netuio/netuio_queue.c:303:
+ // Ensure that the B:D:F match - otherwise, fail the IOCTL$
ERROR:C99_COMMENTS: do not use C99 // comments
#334: FILE: kernel/windows/netuio/netuio_queue.c:303:
+ // Ensure that the B:D:F match - otherwise, fail the IOCTL
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#335: FILE: kernel/windows/netuio/netuio_queue.c:304:
+ if ((netuio_contextdata->addr.bus_num != dpdk_pci_io_input->dev_addr.bus_num) ||$
ERROR:CODE_INDENT: code indent should use tabs where possible
#336: FILE: kernel/windows/netuio/netuio_queue.c:305:
+ (netuio_contextdata->addr.dev_num != dpdk_pci_io_input->dev_addr.dev_num) ||$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: kernel/windows/netuio/netuio_queue.c:305:
+ (netuio_contextdata->addr.dev_num != dpdk_pci_io_input->dev_addr.dev_num) ||$
ERROR:CODE_INDENT: code indent should use tabs where possible
#337: FILE: kernel/windows/netuio/netuio_queue.c:306:
+ (netuio_contextdata->addr.func_num != dpdk_pci_io_input->dev_addr.func_num)) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: kernel/windows/netuio/netuio_queue.c:306:
+ (netuio_contextdata->addr.func_num != dpdk_pci_io_input->dev_addr.func_num)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: kernel/windows/netuio/netuio_queue.c:307:
+ status = STATUS_NOT_SAME_DEVICE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#338: FILE: kernel/windows/netuio/netuio_queue.c:307:
+ status = STATUS_NOT_SAME_DEVICE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#339: FILE: kernel/windows/netuio/netuio_queue.c:308:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#339: FILE: kernel/windows/netuio/netuio_queue.c:308:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: kernel/windows/netuio/netuio_queue.c:309:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#341: FILE: kernel/windows/netuio/netuio_queue.c:310:
+ // Retrieve output buffer$
ERROR:C99_COMMENTS: do not use C99 // comments
#341: FILE: kernel/windows/netuio/netuio_queue.c:310:
+ // Retrieve output buffer
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#342: FILE: kernel/windows/netuio/netuio_queue.c:311:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: kernel/windows/netuio/netuio_queue.c:312:
+ if (!NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: kernel/windows/netuio/netuio_queue.c:313:
+ status = STATUS_INVALID_BUFFER_SIZE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: kernel/windows/netuio/netuio_queue.c:313:
+ status = STATUS_INVALID_BUFFER_SIZE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#345: FILE: kernel/windows/netuio/netuio_queue.c:314:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: kernel/windows/netuio/netuio_queue.c:314:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: kernel/windows/netuio/netuio_queue.c:315:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#347: FILE: kernel/windows/netuio/netuio_queue.c:316:
+ ASSERT(output_buf_size == OutputBufferLength);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#349: FILE: kernel/windows/netuio/netuio_queue.c:318:
+ if (dpdk_pci_io_input->op == PCI_IO_READ) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#350: FILE: kernel/windows/netuio/netuio_queue.c:319:
+ *(UINT64 *)output_buf = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#350: FILE: kernel/windows/netuio/netuio_queue.c:319:
+ *(UINT64 *)output_buf = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#351: FILE: kernel/windows/netuio/netuio_queue.c:320:
+ bytes_returned = netuio_contextdata->bus_interface.GetBusData($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#351: FILE: kernel/windows/netuio/netuio_queue.c:320:
+ bytes_returned = netuio_contextdata->bus_interface.GetBusData($
ERROR:CODE_INDENT: code indent should use tabs where possible
#352: FILE: kernel/windows/netuio/netuio_queue.c:321:
+ netuio_contextdata->bus_interface.Context,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#352: FILE: kernel/windows/netuio/netuio_queue.c:321:
+ netuio_contextdata->bus_interface.Context,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#353: FILE: kernel/windows/netuio/netuio_queue.c:322:
+ PCI_WHICHSPACE_CONFIG,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#353: FILE: kernel/windows/netuio/netuio_queue.c:322:
+ PCI_WHICHSPACE_CONFIG,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#354: FILE: kernel/windows/netuio/netuio_queue.c:323:
+ output_buf,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: kernel/windows/netuio/netuio_queue.c:323:
+ output_buf,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#355: FILE: kernel/windows/netuio/netuio_queue.c:324:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#355: FILE: kernel/windows/netuio/netuio_queue.c:324:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#356: FILE: kernel/windows/netuio/netuio_queue.c:325:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#356: FILE: kernel/windows/netuio/netuio_queue.c:325:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#357: FILE: kernel/windows/netuio/netuio_queue.c:326:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: kernel/windows/netuio/netuio_queue.c:327:
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {$
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#358: FILE: kernel/windows/netuio/netuio_queue.c:327:
+ }
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#359: FILE: kernel/windows/netuio/netuio_queue.c:328:
+ // returns bytes written$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#359: FILE: kernel/windows/netuio/netuio_queue.c:328:
+ // returns bytes written$
ERROR:C99_COMMENTS: do not use C99 // comments
#359: FILE: kernel/windows/netuio/netuio_queue.c:328:
+ // returns bytes written
ERROR:CODE_INDENT: code indent should use tabs where possible
#360: FILE: kernel/windows/netuio/netuio_queue.c:329:
+ bytes_returned = netuio_contextdata->bus_interface.SetBusData($
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: kernel/windows/netuio/netuio_queue.c:329:
+ bytes_returned = netuio_contextdata->bus_interface.SetBusData($
ERROR:CODE_INDENT: code indent should use tabs where possible
#361: FILE: kernel/windows/netuio/netuio_queue.c:330:
+ netuio_contextdata->bus_interface.Context,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: kernel/windows/netuio/netuio_queue.c:330:
+ netuio_contextdata->bus_interface.Context,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#362: FILE: kernel/windows/netuio/netuio_queue.c:331:
+ PCI_WHICHSPACE_CONFIG,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#362: FILE: kernel/windows/netuio/netuio_queue.c:331:
+ PCI_WHICHSPACE_CONFIG,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#363: FILE: kernel/windows/netuio/netuio_queue.c:332:
+ (PVOID)&dpdk_pci_io_input->data,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#363: FILE: kernel/windows/netuio/netuio_queue.c:332:
+ (PVOID)&dpdk_pci_io_input->data,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#364: FILE: kernel/windows/netuio/netuio_queue.c:333:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#364: FILE: kernel/windows/netuio/netuio_queue.c:333:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: kernel/windows/netuio/netuio_queue.c:334:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: kernel/windows/netuio/netuio_queue.c:334:
+ dpdk_pci_io_input->access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#366: FILE: kernel/windows/netuio/netuio_queue.c:335:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#367: FILE: kernel/windows/netuio/netuio_queue.c:336:
+ else {$
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#367: FILE: kernel/windows/netuio/netuio_queue.c:336:
+ }
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#368: FILE: kernel/windows/netuio/netuio_queue.c:337:
+ status = STATUS_INVALID_PARAMETER;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#368: FILE: kernel/windows/netuio/netuio_queue.c:337:
+ status = STATUS_INVALID_PARAMETER;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: kernel/windows/netuio/netuio_queue.c:338:
+ goto end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: kernel/windows/netuio/netuio_queue.c:338:
+ goto end;$
total: 67 errors, 125 warnings, 299 lines checked
More information about the test-report
mailing list