[dpdk-test-report] |WARNING| pw85081 [PATCH] eal/windows: add pthread TLS function support

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Dec 13 21:02:40 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85081

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#78: FILE: lib/librte_eal/windows/include/pthread.h:186:
+		    __rte_unused void (*destructor)(void*))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#80: FILE: lib/librte_eal/windows/include/pthread.h:188:
+	if (((*key) = TlsAlloc()) == TLS_OUT_OF_INDEXES) {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#82: FILE: lib/librte_eal/windows/include/pthread.h:190:
+		return ENOMEM;

total: 2 errors, 1 warnings, 54 lines checked


More information about the test-report mailing list