[dpdk-test-report] |WARNING| pw64933 [PATCH 2/2] net/virtio: add link speed devarg

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jan 20 15:19:43 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64933

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#134: FILE: drivers/net/virtio/virtio_ethdev.c:49:
+static int virtio_dev_devargs_parse(

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#169: FILE: drivers/net/virtio/virtio_ethdev.c:1969:
+static const char *valid_args[] = {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#181: FILE: drivers/net/virtio/virtio_ethdev.c:1986:
+static uint32_t
+virtio_dev_speed_capa_get(uint32_t link_speed) {

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#183: FILE: drivers/net/virtio/virtio_ethdev.c:1988:
+	switch (link_speed) {
+		case ETH_SPEED_NUM_10G:
[...]
+		case ETH_SPEED_NUM_20G:
[...]
+		case ETH_SPEED_NUM_25G:
[...]
+		case ETH_SPEED_NUM_40G:
[...]
+		case ETH_SPEED_NUM_50G:
[...]
+		case ETH_SPEED_NUM_56G:
[...]
+		case ETH_SPEED_NUM_100G:
[...]
+		default:

total: 2 errors, 1 warnings, 1 checks, 168 lines checked


More information about the test-report mailing list