[dpdk-test-report] |WARNING| pw65271 [PATCH v3 02/25] drivers: introduce mlx5 common library

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jan 28 17:56:00 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65271

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#769: FILE: drivers/common/mlx5/mlx5_common.h:18:
+#define PMD_DRV_LOG_OPAREN (

ERROR:SPACING: space prohibited before that close parenthesis ')'
#770: FILE: drivers/common/mlx5/mlx5_common.h:19:
+#define PMD_DRV_LOG_CPAREN )

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#770: FILE: drivers/common/mlx5/mlx5_common.h:19:
+#define PMD_DRV_LOG_CPAREN )

ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
#771: FILE: drivers/common/mlx5/mlx5_common.h:20:
+#define PMD_DRV_LOG_COMMA ,
                           ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#771: FILE: drivers/common/mlx5/mlx5_common.h:20:
+#define PMD_DRV_LOG_COMMA ,

ERROR:SPACING: space required after that ',' (ctx:VxB)
#789: FILE: drivers/common/mlx5/mlx5_common.h:38:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#790: FILE: drivers/common/mlx5/mlx5_common.h:39:
+		RTE_FMT_TAIL(__VA_ARGS__,)))
 		                        ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1826: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:956:
+			void *tx_domain __rte_unused, FILE *file __rte_unused)
 			                                   ^

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2283: FILE: drivers/common/mlx5/mlx5_glue.c:194:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2342: FILE: drivers/common/mlx5/mlx5_glue.c:253:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2357: FILE: drivers/common/mlx5/mlx5_glue.c:268:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2370: FILE: drivers/common/mlx5/mlx5_glue.c:281:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2395: FILE: drivers/common/mlx5/mlx5_glue.c:306:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2410: FILE: drivers/common/mlx5/mlx5_glue.c:321:
+	return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2427: FILE: drivers/common/mlx5/mlx5_glue.c:338:
+	return ENOTSUP;

total: 8 errors, 7 warnings, 5961 lines checked


More information about the test-report mailing list